Mike Kolesnik has posted comments on this change. Change subject: core: filter the vds by query ......................................................................
Patch Set 5: (2 inline comments) How about test for the get by array method? .................................................... File backend/manager/dbscripts/upgrade/03_01_1270_drop_getvdsbytype.sql Line 2: drop function if exists GetVdsByType(v_vds_type INTEGER); No need to do this, part of DB upgrade is to drop all functions and recreate from files, so if it's not in file anymore it won't be created .................................................... File backend/manager/dbscripts/vds_sp.sql Line 708: AND cpu_cores >= v_vds_minnrcpus; name not updated to v_min_cpu_cores -- To view, visit http://gerrit.ovirt.org/5848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia899a81c46f7c0b3fc1e6addecaeb874d356df00 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
