Alex Lourie has posted comments on this change. Change subject: packaging, tools: Generate engine-config.xml from template ......................................................................
Patch Set 7: (2 inline comments) .................................................... File packaging/fedora/setup/engine-setup.py Line 1800: controller.CONF["ENCRYPTED_DB_PASS"]) Is it possible to ident this line into an inner level? Otherwise it reads as if it was a statement on its own, which is confusing a bit. Line 1817: dbUrl = "jdbc:postgresql://" + getDbHostName() + ":" + getDbPort() + "/engine" I recommend we use 'basedefs.DB_NAME' instead of 'engine' here. -- To view, visit http://gerrit.ovirt.org/5362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36c8ff572307a31e5f9f9749e6c3cc41858a2765 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
