Yair Zaslavsky has posted comments on this change. Change subject: Config tool: Get password via file or interactive console ......................................................................
Patch Set 1: Basically I understand what you did so far. I don't like all the stubs of setParser, and it could have been nice if we could have avoided them somehow. I know I'm not a fan of singletons, but maybe changing the parser to Singleton could have saved you the effort of passing it. But besides this issue - the design looks good to me. (Please add me as reviewer to engine-config patches, thanks!) -- To view, visit http://gerrit.ovirt.org/5943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0fe737e9d63ea5d066e31baa83126678e41fc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
