Doron Fediuck has posted comments on this change.
Change subject: core: filter the vds by query
......................................................................
Patch Set 6: (1 inline comment)
Adding to Kublin's remark, some readability improvements.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
Line 115: if (getDestinationVdsId() != null) {
While reading Kublin's comment I noticed......
This function has multiple exit points. Although I do not like it, if you
really want to use it, do it wisely;
ie- if getDestinationVdsId() is null, return the empty guid, and the rest of
the block can be un-indented.
Also, the whole logic of this function is hiding in an inner else block.
Putting that first will be much more readable, and give the logging its
appropriate location- the lower part of the function.
--
To view, visit http://gerrit.ovirt.org/5848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia899a81c46f7c0b3fc1e6addecaeb874d356df00
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
