Allon Mureinik has posted comments on this change.
Change subject: Initial refactoring for ReconstructMasterDomain
..
Patch Set 1: (2 inline comments)
1. See question inline.
2. I'd like to see a unit test alongside this refact
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup LUN pathes parsing
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
rebaed, no changes since last +2 review - pending SUB
Allon Mureinik has posted comments on this change.
Change subject: core: Un-mock GetDeviceListVDSCommandTest
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
rebaed, no changes since last +2 review - pe
Tomas Jelinek has abandoned this change.
Change subject: webadmin: Exception when removing disk from running VM (#825786)
..
Patch Set 1: Abandoned
already fixed
--
To view, visit http://gerrit.ovirt.org/5292
To unsubscribe, v
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vds_installer.py: change to always download deployUtils.py
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://
Amador Pahim has uploaded a new change for review.
Change subject: core: Changing vds_spm_id to be autofilled using a DB sequence.
..
core: Changing vds_spm_id to be autofilled using a DB sequence.
https://bugzilla.redhat.com/sh
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: empty confirm dialog in Edit Management Net
..
webadmin: empty confirm dialog in Edit Management Net
https://bugzilla.redhat.com/show_bug.cgi?id=820844
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/1035/
Build Number: 1035
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,674
-
Changes Since La
Daniel Erez has posted comments on this change.
Change subject: userportal: ctrl+alt+del for spice enabled by default
..
Patch Set 1:
Do we want the same behavior to be reflected both in the UserPortal and
WebAdmin (ctrl+alt+d
Omer Frenkel has posted comments on this change.
Change subject: core : Adding in memory lock to RunVmCommand
..
Patch Set 1: (1 inline comment)
Commit Message
Line 9: The fo
Eli Mesika has uploaded a new change for review.
Change subject: core: database restore fixes
..
core: database restore fixes
This patch enables restoring the database from a old backup and will
perform all necessary data and sc
Daniel Erez has posted comments on this change.
Change subject: webadmin: Exception when removing disk from running VM (#825786)
..
Patch Set 1:
already been fixed in:
http://gerrit.ovirt.org/#/c/5316/1
--
To view, visit http:
Itamar Heim has posted comments on this change.
Change subject: core : Adding in memory lock to RunVmCommand
..
Patch Set 1: (1 inline comment)
please fix spelling in commit message before merging
.
Itamar Heim has posted comments on this change.
Change subject: Initial refactoring for ReconstructMasterDomain
..
Patch Set 1: (1 inline comment)
File
backend/manager/modul
Michael Kublin has posted comments on this change.
Change subject: core: Use the hostSpmId during reconstructMaster
..
Patch Set 7: I would prefer that you didn't submit this
(5 inline comments)
...
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: dc->logical network add/new design
..
Patch Set 12:
For example, in DataCenterNetworkPopupView:
clustersTable.getVisibleItems() -> clustersTable.flush
Michael Kublin has posted comments on this change.
Change subject: core: [rmd] VdsManager
..
Patch Set 2: Looks good to me, approved
not exactly purpose of AtomicBoolean, but I have not better solution except
full rewrite
--
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: dc->logical network add/new design
..
Patch Set 12:
Regarding the table redraw() issue that Gilad mentioned some comments ago: it's
not a technical, b
Michael Kublin has posted comments on this change.
Change subject: engine-core: remove singleton from QuotaHelper
..
Patch Set 2: Looks good to me, approved
great clean up
--
To view, visit http://gerrit.ovirt.org/3008
To unsu
Michael Kublin has posted comments on this change.
Change subject: core: Un-mock GetDeviceListVDSCommandTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5333
To unsubscribe, visit http:/
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup LUN pathes parsing
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5334
To unsubscribe, visit http://gerrit.o
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cluster->Logical network->assign/detach- redesign
..
Patch Set 7:
I think we should decide on the "Required All" header checkbox behavior, which
one i
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cluster->Logical network->assign/detach- redesign
..
Patch Set 7:
As Gilad pointed out, "Required All" header checkbox can be checked even though
not
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: refactor capabilities resource to behave as restfull
collection
..
restapi: refactor capabilities resource to behave as restfull collection
Michael Pasternak has posted comments on this change.
Change subject: restapi: refactor capabilities resource to behave as restfull
collection
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerri
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add and to VersionCaps
..
restapi: add and to VersionCaps
currently these two elements defined under /Capabilities collection
while the
Michael Pasternak has posted comments on this change.
Change subject: restapi: add and to VersionCaps
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5330
To unsubscribe, visit h
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup LUN pathes parsing
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5334
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Un-mock GetDeviceListVDSCommandTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5333
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup LUN pathes parsing
..
core: Cleanup LUN pathes parsing
This patch unifies the code that parses LUN paths from the two places it
was separated in
Allon Mureinik has uploaded a new change for review.
Change subject: core: Un-mock GetDeviceListVDSCommandTest
..
core: Un-mock GetDeviceListVDSCommandTest
GetDeviceListVDSCommandTest uses Mockito to mock XmlRpcStruct, which is
Mike Kolesnik has posted comments on this change.
Change subject: core: use ValidationResult singleton in succesful validation
..
Patch Set 3: Looks good to me, approved
(1 inline comment)
.
Eli Mesika has uploaded a new change for review.
Change subject: core: Can not run VM that was created...(#827883)
..
core: Can not run VM that was created...(#827883)
https://bugzilla.redhat.com/827883
This occurs when importi
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: refactor capabilities resource to behave as restfull
collection
..
restapi: refactor capabilities resource to behave as restfull collection
1. to
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: add and to VersionCaps
..
restapi: add and to VersionCaps
currently these two elements defined under /Capabilities collection
while they should
Federico Simoncelli has uploaded a new change for review.
Change subject: Initial refactoring for ReconstructMasterDomain
..
Initial refactoring for ReconstructMasterDomain
Signed-off-by: Federico Simoncelli
Change-Id: I79fdcf9
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Don't validate MTU on host NIC
..
core: Don't validate MTU on host NIC
No need to validate the MTU field of VdsNetworkInterface since it is
not us
Mike Kolesnik has posted comments on this change.
Change subject: core: Don't validate MTU on host NIC
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, ack by lpeer
--
To view, visit http://gerrit.ovirt.org/5273
T
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Added net_config_dirty to caps (#830488)
..
core: Added net_config_dirty to caps (#830488)
https://bugzilla.redhat.com/830488
When calling getVds
Mike Kolesnik has posted comments on this change.
Change subject: core: Added net_config_dirty to caps (#830488)
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, ack by lpeer
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 5: Verified
Added login permission to the new role, as per ovedo's review.
--
To view, visit http
Yair Zaslavsky has posted comments on this change.
Change subject: core : Adding in memory lock to RunVmCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5324
To unsubscribe, visit htt
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Fix slave changes detection
..
core: Fix slave changes detection
Old detection method detected just added slaves (bond grew).
Added detection for
Mike Kolesnik has posted comments on this change.
Change subject: core: Fix slave changes detection
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, ack by lpeer
--
To view, visit http://gerrit.ovirt.org/5307
To u
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Change removed bonds to strings
..
core: Change removed bonds to strings
No need to hold the whole interface, hold just the names of the bonds
tha
Mike Kolesnik has posted comments on this change.
Change subject: core: Change removed bonds to strings
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, ack by lpeer
--
To view, visit http://gerrit.ovirt.org/5306
Mike Kolesnik has posted comments on this change.
Change subject: core: SetupNetworksHelper handle unmanaged VLAN
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5236
To unsubscribe, visit http://gerrit.ovirt
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: SetupNetworksHelper handle unmanaged VLAN
..
core: SetupNetworksHelper handle unmanaged VLAN
Code didn't handle a case of unmanaged network on VLA
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add test for bond with no slaves
..
core: Add test for bond with no slaves
Bond with no slaves should not be sent, just as bond with only 1 slave,
Mike Kolesnik has posted comments on this change.
Change subject: core: Add test for bond with no slaves
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, ack by lpeer
--
To view, visit http://gerrit.ovirt.org/5235
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Overhaul SetupNetworksHelper
..
core: Overhaul SetupNetworksHelper
Now that tests are in order, we can rewrite SetupNetworksHelper a bit:
1. Chang
Mike Kolesnik has posted comments on this change.
Change subject: core: Overhaul SetupNetworksHelper
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: SetupNetworksHelperTest rework
..
core: SetupNetworksHelperTest rework
1. Added tests for bonds & networks basic changes & validations.
2. Got rid
Mike Kolesnik has posted comments on this change.
Change subject: core: SetupNetworksHelperTest rework
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, ack by lpeer
--
To view, visit http://gerrit.ovirt.org/5233
T
Livnat Peer has posted comments on this change.
Change subject: core: SetupNetworksHelper handle unmanaged VLAN
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5236
To unsubscribe, visit htt
Livnat Peer has posted comments on this change.
Change subject: core: Overhaul SetupNetworksHelper
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5234
To unsubscribe, visit http://gerrit.ov
Mike Kolesnik has posted comments on this change.
Change subject: core: Fix slave changes detection
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/m
Oved Ourfali has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 4: (1 inline comment)
see comment.
Maybe worth having a comment near each action group you add in t
Omer Frenkel has posted comments on this change.
Change subject: core : Adding in memory lock to RunVmCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5324
To uns
Mike Kolesnik has posted comments on this change.
Change subject: core: SetupNetworksHelper handle unmanaged VLAN
..
Patch Set 2: (1 inline comment)
File
backend/manager/mod
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Enable context-sensitive help in dialogs
..
Patch Set 1:
In future, we should refactor
Configurator/WebAdminConfigurator/UserPortalConfigurator clas
Allon Mureinik has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 4:
Added a template owner user role, in response to iheim's comments.
--
To view, visit http://ge
Mike Kolesnik has posted comments on this change.
Change subject: core: SetupNetworksHelperTest rework
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules/bll/s
Vojtech Szocs has uploaded a new change for review.
Change subject: userportal: Enable context-sensitive help in dialogs
..
userportal: Enable context-sensitive help in dialogs
This patch enables context-sensitive help feature f
Oved Ourfali has submitted this change and it was merged.
Change subject: core: adding login permissions
..
core: adding login permissions
This patch adds the login action group, relevant to LoginUserCommand and
LoginAdminComma
Oved Ourfali has posted comments on this change.
Change subject: core: adding login permissions
..
Patch Set 9: Verified; Looks good to me, approved
based on previous acks
--
To view, visit http://gerrit.ovirt.org/5251
To unsu
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding login permissions
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5251
To unsubscribe, visit http://gerrit.ovi
Michael Kublin has submitted this change and it was merged.
Change subject: core: Minor cleanup in GetDeviceListVDSCommandTest
..
core: Minor cleanup in GetDeviceListVDSCommandTest
Made a private helper method static.
Change-I
Michael Kublin has posted comments on this change.
Change subject: core: Minor cleanup in GetDeviceListVDSCommandTest
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5315
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 3:
arg, indeed.
I don't want to touch the template admin role - I'll create a new template
owner
Livnat Peer has posted comments on this change.
Change subject: core: Added net_config_dirty to caps (#830488)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5270
To unsubscribe, visit http
Roy Golan has uploaded a new change for review.
Change subject: core: make the getTimeZone query OS bounded
..
core: make the getTimeZone query OS bounded
this query will return different timezone for windows OS (the default
and
Mike Kolesnik has posted comments on this change.
Change subject: core: Overhaul SetupNetworksHelper
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules/bll/src
Livnat Peer has posted comments on this change.
Change subject: core: Fix slave changes detection
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
File
backend
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/1474/
Build Number: 1474
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,662
-
Ch
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/1473/
Build Number: 1473
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,661
-
Itamar Heim has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 3:
but isn't template_admin an admin role, so won't solve the problem for users?
(actually, i think i
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: validation added for volume brick directory(#829664)
..
webadmin: validation added for volume brick directory(#829664)
https://bugzilla.redhat
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: validation added for volume brick directory(#829664)
..
Patch Set 3: Verified; Looks good to me, approved
rebased & verified.
--
To view, visit http:/
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: disabling host address in host dialog(#829844)
..
webadmin: disabling host address in host dialog(#829844)
https://bugzilla.redhat.com/829844
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: disabling host address in host dialog(#829844)
..
Patch Set 2: Verified; Looks good to me, approved
rebased.
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Explicit permission when adding a template
..
Patch Set 3: Verified
changed granted role to TEMPLATE_ADMIN as per iheim's review.
--
To view, visit http:
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: fixing typo GetAllFromExportDomainQueryParameters
..
engine: fixing typo GetAllFromExportDomainQueryParameters
typo in GetAllFromExportDomainQue
Gilad Chaplik has posted comments on this change.
Change subject: engine: fixing typo GetAllFromExportDomainQueryParameters
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: no timeout in webadmin
..
engine: no timeout in webadmin
Change-Id: Ida970380d808d460a5db85f070e3a8d988669ab8
Signed-off-by: Gilad Chaplik
---
Gilad Chaplik has posted comments on this change.
Change subject: engine: no timeout in webadmin
..
Patch Set 4: Verified; Looks good to me, approved
rebased & verified.
--
To view, visit http://gerrit.ovirt.org/5218
To unsubs
Livnat Peer has posted comments on this change.
Change subject: core: Change removed bonds to strings
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5306
To unsubscribe, visit http://gerrit
Michael Kublin has posted comments on this change.
Change subject: core: Minor cleanup in GetDeviceListVDSCommandTest
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5315
To unsubs
Alona Kaplan has posted comments on this change.
Change subject: engine: fixing typo GetAllFromExportDomainQueryParameters
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Tal Nisan has submitted this change and it was merged.
Change subject: core: Showing correct status on attempting to destroy active SD
(#819279)
..
core: Showing correct status on attempting to destroy active SD (#819279)
http
Tal Nisan has posted comments on this change.
Change subject: core: Showing correct status on attempting to destroy active SD
(#819279)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Alona Kaplan has posted comments on this change.
Change subject: engine: no timeout in webadmin
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5218
To unsubscribe, visi
Michael Kublin has posted comments on this change.
Change subject: core: Minor cleanup in GetDeviceListVDSCommandTest
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5315
To unsubs
Michael Kublin has submitted this change and it was merged.
Change subject: core: VdsUpdateRunTimeInfo w/o devices (#827820)
..
core: VdsUpdateRunTimeInfo w/o devices (#827820)
https://bugzilla.redhat.com/827820
This patch fix
Michael Kublin has posted comments on this change.
Change subject: core: VdsUpdateRunTimeInfo w/o devices (#827820)
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5256
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: Minor cleanup in GetDeviceListVDSCommandTest
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 r
Allon Mureinik has posted comments on this change.
Change subject: core: VdsUpdateRunTimeInfo w/o devices (#827820)
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 rev
Michael Kublin has submitted this change and it was merged.
Change subject: core: cleanup of StorageHelperDirector
..
core: cleanup of StorageHelperDirector
changed StorageHelperDirector to use FQCN imports, removed FQCN from
c
Michael Kublin has posted comments on this change.
Change subject: core: cleanup of StorageHelperDirector
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5180
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: cleanup of StorageHelperDirector
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5180
To unsubscribe, visit http://ge
1 - 100 of 231 matches
Mail list logo
