Allon Mureinik has posted comments on this change. Change subject: Initial refactoring for ReconstructMasterDomain ......................................................................
Patch Set 1: (2 inline comments) 1. See question inline. 2. I'd like to see a unit test alongside this refactor - there is some non-trivial logic here, and we'd like to prove nothing was broken. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java Line 95: You're attempting to stop the SPM regardless of whether it's the last master or not - is this intentional? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java Line 8: why no simply isInactive()? -- To view, visit http://gerrit.ovirt.org/5329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79fdcf9870a003fc79e273a6fc89351e3dad5b5c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
