Allon Mureinik has uploaded a new change for review. Change subject: core: Un-mock GetDeviceListVDSCommandTest ......................................................................
core: Un-mock GetDeviceListVDSCommandTest GetDeviceListVDSCommandTest uses Mockito to mock XmlRpcStruct, which is quite redundent - it's a simple data-object, with no underlying logic. This patch removed the mocking and uses XmlRpcStruct directly, which makes the test easier to read and maintain. Change-Id: I599fd0050deab4142245af3ccce08d790fbf139c Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java 1 file changed, 10 insertions(+), 15 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/5333/1 -- To view, visit http://gerrit.ovirt.org/5333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I599fd0050deab4142245af3ccce08d790fbf139c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
