Vojtech Szocs has posted comments on this change. Change subject: webadmin: dc->logical network add/new design ......................................................................
Patch Set 12: Regarding the table redraw() issue that Gilad mentioned some comments ago: it's not a technical, but more of a design issue. EntityModelCellTable is an Editor of ListModel objects -> it works with ListModel's EntityModel items. We always try to handle model <-> UI updates through the Editor framework, calling edit(model) to update UI from model, and calling flush() to get updated model from UI. For this reason, instead of working with table data directly via getVisibleItems() and calling redraw(), we should flush() the table to get up-to-date ListModel, modify its items, and then call edit(model) to update/refresh the table. -- To view, visit http://gerrit.ovirt.org/5095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c31ce6a9b6907cab04c5f3041808945fb40885b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
