Vojtech Szocs has posted comments on this change.

Change subject: webadmin: cluster->Logical network->assign/detach- redesign
......................................................................


Patch Set 7:

I think we should decide on the "Required All" header checkbox behavior, which 
one is correct?
- (1) clicking "Required All" will set "Required" flag to all "editable" 
networks in the table -> current behavior
- (2) "Required All" header checkbox will be disabled if there is at least one 
"non-editable" network in the table

By "editable" network, I mean ClusterNetworkManageModel for which 
ClusterManageNetworkPopupView.canEditRequired() == true.

--
To view, visit http://gerrit.ovirt.org/5225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43df91cf11846af00130440f30b38e2288fe5047
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to