Oved Ourfali has posted comments on this change. Change subject: core: Explicit permission when adding a template ......................................................................
Patch Set 4: (1 inline comment) see comment. Maybe worth having a comment near each action group you add in the upgrader, so that it will be clear by looking at it what are the action groups in that role. Othat than that it looks okay. +1 from me if addressing the login permission comment, if needed. .................................................... File backend/manager/dbscripts/upgrade/03_01_1240_add_template_owner_role.sql Line 26: will he need login permissions? If so, you need to also add action_group_id 1300. -- To view, visit http://gerrit.ovirt.org/5267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7885c03a09c9315fd8eb2f554bc266250fa7e181 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
