[Engine-patches] Change in ovirt-engine[master]: engine-core: removing windows line terminations from sql scr...

2012-01-26 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: removing windows line terminations from sql scripts .. engine-core: removing windows line terminations from sql scripts removed all of the window

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-26 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM .. Patch Set 2: (3 inline comments) File backend/

[Engine-patches] Change in ovirt-engine[master]: core: Refactoring the CreateVDSCommand

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Refactoring the CreateVDSCommand .. -- To view, visit http://gerrit.ovirt.org/1151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Message

[Engine-patches] Change in ovirt-engine[master]: core: Refactoring the CreateVDSCommand

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Refactoring the CreateVDSCommand .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1151 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: adding hash column to vm_dynamic

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: adding hash column to vm_dynamic .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1152 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: Adding vm_device table

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding vm_device table .. Patch Set 5: Looks good to me, but someone else must approve I suspect 140 is already taken. please check. either than that - +1

[Engine-patches] Change in ovirt-engine[master]: core: Adding CRUD stored procedures for vm_device

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding CRUD stored procedures for vm_device .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1155

[Engine-patches] Change in ovirt-engine[master]: core: Adding VM Device BE

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VM Device BE .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1156 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Add VmDeviceDAODbFacadeImpl

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Add VmDeviceDAODbFacadeImpl .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1158 To un

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOHibernateImpl

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VmDeviceDAOHibernateImpl .. Patch Set 5: (1 inline comment) File backend/manager/modules/dal/

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOTest

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VmDeviceDAOTest .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1161 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDEviceDAO to engine-daos.properties

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VmDEviceDAO to engine-daos.properties .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1160 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: Adding VmDeviceDAOTest

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding VmDeviceDAOTest .. Patch Set 5: URLs to files do not work. please re-submit -- To view, visit http://gerrit.ovirt.org/1161 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: porting old boot order values to new vm_device

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: porting old boot order values to new vm_device .. Patch Set 5: the url to the diff of the file is not working, please re-submit. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core : adding common utilities for VmDevice - VmDeviceCommon...

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : adding common utilities for VmDevice - VmDeviceCommonUtils .. Patch Set 5: (1 inline comment) File

[Engine-patches] Change in ovirt-engine[master]: core : Adding utility class for VmDevice - VmDeviceUtils

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Adding utility class for VmDevice - VmDeviceUtils .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core : modify UpdateVmCommand

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : modify UpdateVmCommand .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1165 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in RemoveDiskFromVmCommand

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handle changes in RemoveDiskFromVmCommand .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1168 T

[Engine-patches] Change in ovirt-engine[master]: core: handle changes in RemoveVmInterfaceCommand

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: handle changes in RemoveVmInterfaceCommand .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1169

[Engine-patches] Change in ovirt-engine[master]: core: Handle changes in AddDiskToVmCommand

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handle changes in AddDiskToVmCommand .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1170 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Handlig boot order in CreateVdsCommand

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Handlig boot order in CreateVdsCommand .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: rename upgrade scripts

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: rename upgrade scripts .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1199 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Variable renaming for CreateVdsComamnd

2012-01-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Variable renaming for CreateVdsComamnd .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1181 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: webadmin: Create GwtCommon and UserPortal GWTP PoC

2012-01-26 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Create GwtCommon and UserPortal GWTP PoC .. Patch Set 4: Latest patch set with following changes: - in frontend GwtDynamicHostPageServlet, fixed Backen

[Engine-patches] Change in ovirt-engine[master]: webadmin: Missing cursor on most of new windows opened

2012-01-26 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Missing cursor on most of new windows opened .. webadmin: Missing cursor on most of new windows opened https://bugzilla.redhat.com/show_bug.cgi?id=7839

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: storage tab is sluggish (#769615)

2012-01-26 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: backend, webadmin: storage tab is sluggish (#769615) .. Patch Set 2: (2 inline comments) File backend/mana

[Engine-patches] Change in ovirt-engine[master]: core: Seperating engine reports views from backend views

2012-01-26 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Seperating engine reports views from backend views .. -- To view, visit http://gerrit.ovirt.org/1275 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: core: Seperating engine reports views from backend views

2012-01-26 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core: Seperating engine reports views from backend views .. core: Seperating engine reports views from backend views This patch separates engine reports vi

[Engine-patches] Change in ovirt-engine[master]: core: Seperating engine reports views from backend views

2012-01-26 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Seperating engine reports views from backend views .. Patch Set 2: Verified; Looks good to me, approved rebase only , acked by M Koles -- To view, visit http

[Engine-patches] Change in ovirt-engine[master]: restapi: fix datacenter-version param in yaml

2012-01-26 Thread oliel
ol...@redhat.com has uploaded a new change for review. Change subject: restapi: fix datacenter-version param in yaml .. restapi: fix datacenter-version param in yaml Change-Id: I0851475d2adbaeb8e1286eb6769e40e3a5cf4dc8 --- M ba

[Engine-patches] Change in ovirt-engine[master]: Create Vm From Template - mem ignored

2012-01-26 Thread oliel
ol...@redhat.com has uploaded a new change for review. Change subject: Create Vm From Template - mem ignored .. Create Vm From Template - mem ignored Change-Id: I8a34e6a38845d27da137e1adf2238b8b91c269b6 --- M backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: webadmin: Buttons text - middle vertical alignment

2012-01-26 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Buttons text - middle vertical alignment .. webadmin: Buttons text - middle vertical alignment Vertically aligned dialog buttons' text to middle

[Engine-patches] Change in ovirt-engine[master]: webadmin: Buttons text - middle vertical alignment

2012-01-26 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Buttons text - middle vertical alignment .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/1271 To

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: storage tab is sluggish (#769615)

2012-01-26 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: backend, webadmin: storage tab is sluggish (#769615) .. Patch Set 2: (1 inline comment) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: core: Seperating engine reports views from backend views

2012-01-26 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Seperating engine reports views from backend views .. Patch Set 1: Verified; Looks good to me, approved I think next logical step is to have a separate DB

[Engine-patches] Change in ovirt-engine[master]: restapi: add missing RSDL parameters

2012-01-26 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: add missing RSDL parameters .. restapi: add missing RSDL parameters Change-Id: I76ecbc8e9dd7598219096974906ca471b3b55bb0 --- M backend/man

[Engine-patches] Change in ovirt-engine[master]: restapi: add missing RSDL parameters

2012-01-26 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: add missing RSDL parameters .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1209 To unsubscribe, visi

[Engine-patches] Change in ovirt-reports[master]: reports: fixed poms maven files.

2012-01-26 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: reports: fixed poms maven files. .. -- To view, visit http://gerrit.ovirt.org/1260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comm

[Engine-patches] Change in ovirt-reports[master]: reports: fixed poms maven files.

2012-01-26 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: reports: fixed poms maven files. .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1260 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - Remove locale check (#769319)

2012-01-26 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-setup - Remove locale check (#769319) .. packaging: engine-setup - Remove locale check (#769319) https://bugzilla.redhat.com/show_bug

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - Remove locale check (#769319)

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup - Remove locale check (#769319) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1269 To u

[Engine-patches] Change in ovirt-engine[master]: restapi: add missing RSDL parameters

2012-01-26 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: add missing RSDL parameters .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1209 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update ssh configuration in logcollector (#784568...

2012-01-26 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Packaging: Update ssh configuration in logcollector (#784568) https://bugzilla.redhat.

[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update ssh configuration in logcollector (#784568...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/127

[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update ssh configuration in logcollector (#784568...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/127

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: storage tab is sluggish (#769615)

2012-01-26 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: backend, webadmin: storage tab is sluggish (#769615) .. Patch Set 2: (1 inline comment) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: core: Seperating engine reports views from backend views

2012-01-26 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Seperating engine reports views from backend views .. Patch Set 1: Looks good to me, but someone else must approve The only comment I have is that a user

[Engine-patches] Change in ovirt-engine[master]: backend, frontend: Remove TimeLeapseVmPool.

2012-01-26 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend,frontend: Remove TimeLeapseVmPool. .. Patch Set 4: (2 inline comments) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update ssh configuration in logcollector (#784568...

2012-01-26 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Packaging: Update ssh configuration in logcollector (#784568) https://bugzilla.redhat.com/show_bu

[Engine-patches] Change in ovirt-reports[master]: reports: fixed poms maven files.

2012-01-26 Thread masayag
Moti Asayag has posted comments on this change. Change subject: reports: fixed poms maven files. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1260 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: webadmin: Buttons text - middle vertical alignment

2012-01-26 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Buttons text - middle vertical alignment .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1271 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: backend: Remove the time_lease_vm_pool_map in updating scrip...

2012-01-26 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Remove the time_lease_vm_pool_map in updating scripts. .. Patch Set 1: (1 inline comment) File backe

[Engine-patches] Change in ovirt-engine[master]: backend: Remove time_lease_vm_pool_map from db initing scrip...

2012-01-26 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Remove time_lease_vm_pool_map from db initing scripts. .. Patch Set 1: (1 inline comment) File backe

[Engine-patches] Change in ovirt-engine[master]: core: Seperating engine reports views from backend views

2012-01-26 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: Seperating engine reports views from backend views .. core: Seperating engine reports views from backend views This patch separates engine reports views from

[Engine-patches] Change in ovirt-engine[master]: Packaging: Update ssh configuration in logcollector (#784568...

2012-01-26 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Packaging: Update ssh configuration in logcollector (#784568) https://bugzilla.redhat.

[Engine-patches] Change in ovirt-engine[master]: Packaging: Update ssh configuration in logcollector (#784568...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update ssh configuration in logcollector (#784568) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/127

[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update configuration in logcollector and isouploa...

2012-01-26 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Packaging: Update configuration in logcollector and isouploader (#784303)

[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update configuration in logcollector and isouploa...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: tools: New tool to upload OVF archives (#782182)

2012-01-26 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: tools: New tool to upload OVF archives (#782182) .. Patch Set 10: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/574 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: Packaging: Update issh configuration in logcollector (#78456...

2012-01-26 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: Packaging: Update issh configuration in logcollector (#784568) .. Packaging: Update issh configuration in logcollector (#784568) https://bugzilla.redhat.com/show_

[Engine-patches] Change in ovirt-engine[engine_3.0]: Packaging: Update configuration in logcollector and isouploa...

2012-01-26 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Packaging: Update configuration in logcollector and isouploader (#784303) https://bu

[Engine-patches] Change in ovirt-reports[master]: reports: fixed inefficient subquery in all the reports (#783...

2012-01-26 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: reports: fixed inefficient subquery in all the reports (#783194) .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://

[Engine-patches] Change in ovirt-reports[master]: reports: removed trailing white spaces.

2012-01-26 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: reports: removed trailing white spaces. .. Patch Set 4: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1261 To

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...

2012-01-26 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: core : "User is already logged in" error when trying to login" .. core : "User is already logged in" error when trying to login" The following fix shou

[Engine-patches] Change in ovirt-reports[master]: reports: fixed poms maven files.

2012-01-26 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: reports: fixed poms maven files. .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1260 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - Remove locale check (#769319)

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-setup - Remove locale check (#769319) .. Patch Set 1: Fails (1 inline comment) Please fix whitespace and resend. all other stuff looks good.

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : Clean up - "User is already logged in" error when try...

2012-01-26 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: core : Clean up - "User is already logged in" error when trying to login" .. core : Clean up - "User is already logged in" error when trying to login"

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : Clean up - "User is already logged in" error when try...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: core : Clean up - "User is already logged in" error when trying to login" .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...

2012-01-26 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Packaging: Update configuration in logcollector and isouploader (#784303)

[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Patch Set 2: Verified; Looks good to me, approved Perfect -- To view, visit http:

[Engine-patches] Change in ovirt-dwh[master]: etl: removed unreachable maven repositories.

2012-01-26 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: etl: removed unreachable maven repositories. .. etl: removed unreachable maven repositories. Change-Id: Ic9c9b923c4b7dfce6144628384784dcce2fda953 --- M dat

[Engine-patches] Change in ovirt-dwh[master]: etl: removed unreachable maven repositories.

2012-01-26 Thread emesika
Eli Mesika has posted comments on this change. Change subject: etl: removed unreachable maven repositories. .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1259 To unsubscribe, vis

[Engine-patches] Change in ovirt-dwh[master]: history: removed trailing white spaces

2012-01-26 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: history: removed trailing white spaces .. history: removed trailing white spaces Change-Id: Iecc429f77792f74e169bb92dd25e73dc28164e42 --- M data-warehouse/

[Engine-patches] Change in ovirt-dwh[master]: history: removed trailing white spaces

2012-01-26 Thread emesika
Eli Mesika has posted comments on this change. Change subject: history: removed trailing white spaces .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1256 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-dwh[master]: history: changed daily table time column to type date (#7831...

2012-01-26 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: history: changed daily table time column to type date (#783197) .. history: changed daily table time column to type date (#783197) - Added development 3.1

[Engine-patches] Change in ovirt-dwh[master]: history: changed daily table time column to type date (#7831...

2012-01-26 Thread emesika
Eli Mesika has posted comments on this change. Change subject: history: changed daily table time column to type date (#783197) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1255

[Engine-patches] Change in ovirt-engine[master]: engine-core: vdsstaticdao redundancies

2012-01-26 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine-core: vdsstaticdao redundancies .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/552 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...

2012-01-26 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" .. Patch Set 1: Verified; Looks good to me, approved I'm fine with my comment being implemented in

[Engine-patches] Change in ovirt-engine[master]: backend: Event when VM goes down internally

2012-01-26 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: backend: Event when VM goes down internally .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/901 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-dwh[master]: etl: fixed avg calculation of vm disk read\write rate. (#781...

2012-01-26 Thread emesika
Eli Mesika has posted comments on this change. Change subject: etl: fixed avg calculation of vm disk read\write rate. (#781470) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1254

[Engine-patches] Change in ovirt-dwh[master]: etl: fixed avg calculation of vm disk read\write rate. (#781...

2012-01-26 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: etl: fixed avg calculation of vm disk read\write rate. (#781470) .. etl: fixed avg calculation of vm disk read\write rate. (#781470) This is a temporary fi

[Engine-patches] Change in ovirt-engine[master]: Preparation for query permissions - allow typing of queries ...

2012-01-26 Thread amureini
Allon Mureinik has abandoned this change. Change subject: Preparation for query permissions - allow typing of queries as admin/user queries and add runAsUser property to params .. Patch Set 1: Abandoned lots Git newbe mistakes

[Engine-patches] Change in ovirt-engine[master]: Take 2: Prepration for query permissions - allowing typing o...

2012-01-26 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: Take 2: Prepration for query permissions - allowing typing of queries as admin/user and add runAsUser property to params .. Take 2: Prepration for query permis

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - support long host fqdn in create_c...

2012-01-26 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: packaging: engine-setup - support long host fqdn in create_ca (#782810) .. Patch Set 4: (2 inline comments) See inline

[Engine-patches] Change in ovirt-engine[master]: webadmin: Buttons text - middle vertical alignment

2012-01-26 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: Buttons text - middle vertical alignment .. webadmin: Buttons text - middle vertical alignment Vertically aligned dialog buttons' text to middle. Chang

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...

2012-01-26 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" .. Patch Set 1: Because of it is cherry pick I would prefer not to make changes for commit espec

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...

2012-01-26 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" .. Patch Set 1: Because of it is cherry pick I would prefer not to make changes for commit espec

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...

2012-01-26 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" .. Patch Set 1: Because of it is cherry pick I would prefer not to make changes for commit espec

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...

2012-01-26 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" .. Patch Set 1: Hi, because of it is cherry pick, I will prefer not to make changes for that pat

[Engine-patches] Change in ovirt-engine[engine_3.0]: core : "User is already logged in" error when trying to logi...

2012-01-26 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : "User is already logged in" error when trying to login" .. Patch Set 1: Hi, because of it is cherry pick, I will prefer not to make changes for that pat

[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...

2012-01-26 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Patch Set 1: Fails (2 inline comments) Commit looks good. Please fix the log path

[Engine-patches] Change in ovirt-engine[master]: Packaging: Update configuration in logcollector and isouploa...

2012-01-26 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: Packaging: Update configuration in logcollector and isouploader (#784303) .. Packaging: Update configuration in logcollector and isouploader (#784303) https://bu

[Engine-patches] Change in ovirt-engine[master]: Preparation for query permissions - allow typing of queries ...

2012-01-26 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: Preparation for query permissions - allow typing of queries as admin/user queries and add runAsUser property to params .. Patch Set 1: (3 inline comments) ..

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-26 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM .. Patch Set 2: (3 inline comments) some minor comments .

[Engine-patches] Change in ovirt-engine[master]: restapi: add missing RSDL parameters

2012-01-26 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: add missing RSDL parameters .. Patch Set 2: (3 inline comments) File backend/manager/modules/r

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - Remove locale check (#769319)

2012-01-26 Thread imansano
Idan Mansano has uploaded a new change for review. Change subject: packaging: engine-setup - Remove locale check (#769319) .. packaging: engine-setup - Remove locale check (#769319) https://bugzilla.redhat.com/show_bug.cgi?id=76

[Engine-patches] Change in ovirt-engine[master]: webadmin: HostVm subtab- migrate action doesn't work

2012-01-26 Thread danny . ran
Danny Rankevich has submitted this change and it was merged. Change subject: webadmin: HostVm subtab- migrate action doesn't work .. webadmin: HostVm subtab- migrate action doesn't work https://bugzilla.redhat.com/show_bug.cgi?

[Engine-patches] Change in ovirt-engine[master]: webadmin: HostVm subtab- migrate action doesn't work

2012-01-26 Thread danny . ran
Danny Rankevich has posted comments on this change. Change subject: webadmin: HostVm subtab- migrate action doesn't work .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1232 To uns

  1   2   >