Ofer Schreiber has posted comments on this change.

Change subject: Packaging: Update configuration in logcollector and isouploader 
(#784303)
......................................................................


Patch Set 1: Fails

(2 inline comments)

Commit looks good.
Please fix the log path as well

....................................................
File backend/manager/tools/engine-iso-uploader/src/engine-iso-uploader.py
Line 46: DEFAULT_LOG_FILE='/var/log/engine/engine-iso-uploader.log'
I think this path is also wrong

....................................................
File backend/manager/tools/engine-logcollector/src/rhev/logcollector.py
Line 29: DEFAULT_LOG_FILE='/var/log/engine/engine-log-collector.log'
what about this path?

--
To view, visit http://gerrit.ovirt.org/1270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I625e804d9a421af990edf32dbadbc21c83e6739e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to