Yair Zaslavsky has posted comments on this change. Change subject: core : adding common utilities for VmDevice - VmDeviceCommonUtils ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java Line 11: public final static String DISK = "disk"; About my enum question - I think that defining it logically as enum helps the user understand what is this set of strings. We have similar cases in the code. -- To view, visit http://gerrit.ovirt.org/1163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie61cccbe2c866997558dc84041fb0c588133f8a8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
