Einav Cohen has posted comments on this change. Change subject: backend, webadmin: storage tab is sluggish (#769615) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java Line 283: the change that Gilad has made actually causes the QueryableId to be the storage domain ID, unless telling it otherwise; The QueryableId of the storage domain should, in most cases, simply be the domain ID. The only scenario in which we want it to be otherwise is when dealing with the results for the GetStorageDomainListById query: each item in the returned list of that query has the same ID but a different storagePoolId; in this case, the GUI sets the QueryableId to be a concatenation of the storage-id and the storage-pool-id (see the other file in this patch). The only change that should (maybe) introduced to this patch is to set the special QueriableID as part of GetStorageDomainListById query execution, instead of setting it in the GUI code only after getting the results (as the GUI probably shouldn't manipulate the properties of the backend-results) Gilad/Michael: Thoughts? -- To view, visit http://gerrit.ovirt.org/1226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49d9fada489168f093deb273e8b9510146f58522 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Danny Rankevich <danny....@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Haim Ateya <hat...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
