Omer Frenkel has posted comments on this change. Change subject: Preparation for query permissions - allow typing of queries as admin/user queries and add runAsUser property to params ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java Line 139: private static final String QuerySuffix = "Query"; AFAIR, java convention is to declare members in the beginning of the class. Line 140: if we need the code anyway, why add extra code for setting it from outside? its a property the entity can calc by itself, and if its cached as kublin suggested it will be done once, .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java Line 204: @XmlElement(name = "Refresh", defaultValue = "true") this fix is funny, as i think this annotation can be removed -- To view, visit http://gerrit.ovirt.org/1243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83c3f85a9ad41638135c4c05a2660a27fda67a1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
