Yair Zaslavsky has posted comments on this change.

Change subject: core: Adding VmDeviceDAOHibernateImpl
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAOHibernateImpl.java
Line 18:         // TODO Auto-generated method stub
Actually, in such cases I would prefer to throw the NotImplementedException

--
To view, visit http://gerrit.ovirt.org/1159
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7163e5e9a5cbee29508b865aad756bb2e2944bc8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to