Re: [dev-servo] Merging mozjs and rust-mozjs

2020-01-10 Thread Manish Goregaokar
This seems good to me. On Fri, Jan 10, 2020, 9:59 PM Josh Matthews wrote: > Given how closely intertwined the two repositories are, and especially > given we can no longer publish them to crates.io and have a pinned git > revision in rust-mozjs's Cargo.toml, I propose that we merge the > servo/

Re: [dev-servo] The future of irc.mozilla.org/#servo

2019-12-19 Thread Manish Goregaokar
okay with staying. -Manish Goregaokar On Thu, Dec 19, 2019 at 10:27 AM Alan Jeffrey wrote: > I've been using the IRC <-> Matrix bridge and the matrix client, and I've > been quite happy with them. I'd be in favour of moving to matrix, it seems > pretty decent, the

Re: [dev-servo] Last week for testing potential IRC replacements

2019-10-09 Thread Manish Goregaokar
I never used it, I have a screen session on a server running irssi. I wouldn't recommend it unless you like terminal UIs. On Wed, Oct 9, 2019, 4:40 AM Paul Rouget wrote: > Now that irccloud is gone, what do you people do? Use a IRC client? Moved > to one of these platforms? > > On Fri, Oct 4, 2

Re: [dev-servo] Question About the Merging Process

2019-04-29 Thread Manish Goregaokar
Yep! On Mon, Apr 29, 2019, 4:33 PM Maria Sable wrote: > Hi Manish, > > Thank you! By ping, do you mean @them in the pull request conversation? > > Kind regards, > Maria Sable > > On Mon, Apr 29, 2019 at 7:26 PM Manish Goregaokar > wrote: > > > The reviewer

Re: [dev-servo] Question About the Merging Process

2019-04-29 Thread Manish Goregaokar
The reviewer has to leave a comment saying `@bors-servo r+` to inform our bot that the pull request needs merging. Once that happens, you can wait. If you have an approving Github review but no r+, make sure you've addressed any straggling issues and ping the reviewer. -Manish Goregaokar

Re: [dev-servo] How to Run Servo/Media/Examples?

2019-04-27 Thread Manish Goregaokar
one reporting similar issues on servo/media. > > > > Do you have any suggestions on how to fix this? > > > > Kind regards, > > Maria > > > > On Sat, Apr 27, 2019 at 3:54 PM Manish Goregaokar > > > wrote: > > > > > Ah. The params.rs te

Re: [dev-servo] How to Run Servo/Media/Examples?

2019-04-27 Thread Manish Goregaokar
te and set the PKG_CONFIG_PATH environment variable by following these > instructions: https://github.com/sdroege/gstreamer-rs#installation . I > did > not see anyone reporting similar issues on servo/media. > > Do you have any suggestions on how to fix this? > > Kind regards, >

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-27 Thread Manish Goregaokar
Yeah, please leave a todo comment. Currently there's no way to validate this, in the future the DOM side will also have a timeline struct so that it can do this. Thanks, -Manish Goregaokar On Sat, Apr 27, 2019 at 6:52 AM Josh Bowman-Matthews wrote: > It's not clear to me how

Re: [dev-servo] How to Run Servo/Media/Examples?

2019-04-27 Thread Manish Goregaokar
something different to get it work with servo/media? When I run > "cargo build" in servo/media, it works fine. > > Kind regards, > Maria > > On Sat, Apr 27, 2019 at 3:13 PM Manish Goregaokar > wrote: > > > `cargo ex name_of_example` > > > > In the c

Re: [dev-servo] How to Run Servo/Media/Examples?

2019-04-27 Thread Manish Goregaokar
. Thanks, -Manish Goregaokar On Sat, Apr 27, 2019 at 12:06 PM Maria Sable wrote: > Hi all, > > I'm working on finishing up our final project at NCSU, and I need to create > a runnable example for StereoPannerNode based on the example for > PannerNode. However, it would be immensely

Re: [dev-servo] println!("Hello from NCSU");

2019-04-06 Thread Manish Goregaokar
Yes, that is correct. This is mostly a matter of hooking up your new servo-media additions into the JS DOM apis. -Manish Goregaokar On Sat, Apr 6, 2019 at 2:02 PM BAlaji wrote: > Hi Josh > Appears to be libgstreamer0.10-dev is outdated in Ubuntu 18.04. > > Running the below in te

Re: [dev-servo] rust-webvr and media repositories now use homu

2019-02-21 Thread Manish Goregaokar
The webhooks weren't set up. Fixed. -Manish Goregaokar On Thu, Feb 21, 2019 at 2:07 AM Fernando Jiménez Moreno < ferjmor...@gmail.com> wrote: > It does not seem to be working for servo/media. The queue is empty while > there's an open PR [1]. And bors-servo does not

Re: [dev-servo] Error during compilation

2018-12-09 Thread Manish Goregaokar
Not in the example you're using. -Manish Goregaokar On Thu, Dec 6, 2018 at 5:09 PM Avanthikaa Ravichandran wrote: > Is it necessary to send any message to the GainNode? > > > On Dec 6, 2018, at 11:04 AM, Manish Goregaokar > wrote: > > > > Sorry, to clarify: thi

Re: [dev-servo] Error during compilation

2018-12-06 Thread Manish Goregaokar
Sorry, to clarify: this was a bug in the existing code, not your code. -Manish Goregaokar On Thu, Dec 6, 2018 at 11:04 AM Manish Goregaokar wrote: > I pushed a fix, please rebase your pull request to master to pull it in. > > Thanks, > -Manish Goregaokar > > > On Wed, De

Re: [dev-servo] Error during compilation

2018-12-06 Thread Manish Goregaokar
I pushed a fix, please rebase your pull request to master to pull it in. Thanks, -Manish Goregaokar On Wed, Dec 5, 2018 at 10:08 PM Avanthikaa Ravichandran wrote: > We pushed the final changes in the code and we have the same issue still. > On running with backtrace, I got the fol

Re: [dev-servo] Error during compilation

2018-11-30 Thread Manish Goregaokar
It would be helpful to see what your changes are and what test command you're running (along with a full backtrace, setting RUST_BACKTRACE=1 will let you get one). I'm unable to get this same error when I test your pull request locally. (Which github issue are you talking about

Re: [dev-servo] Implementing periodic wave options for Oscillator node

2018-11-27 Thread Manish Goregaokar
It doesn't matter for normalization. The second half of that segment is what's relevant: you need to calculate the maximum value of a single cycle of the wave, and then scale the wave down by that. No need to worry about N. It's fine if you don't implement this for now, thou

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-17 Thread Manish Goregaokar
> However, for channelsum.rs and channel.rs, clone() is not allowed since options is created with Default::default(); This is because of inference, use OscillatorOptions::default() instead, *or* just construct it twice instead of reusing it -Manish Goregaokar On Sat, Nov 17, 2018 at 4:15

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-15 Thread Manish Goregaokar
Just remove the Copy requirement on the OscillatorOptions type, it's not necessary. -Manish Goregaokar On Thu, Nov 15, 2018 at 4:15 PM Avanthikaa Ravichandran wrote: > Thank you so much. > We are also trying to implement the periodic wave option for the oscillator > node. Th

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-15 Thread Manish Goregaokar
Yes, it's f(x) = k. Note that `k` here is an AudioParam, so it's not always a constant -- similar to how frequency in OscillatorSourceNode or gain in GainNode can vary per frame. -Manish Goregaokar On Thu, Nov 15, 2018 at 2:48 PM Avanthikaa Ravichandran wrote: > Hi, > >

Re: [dev-servo] Rustfmt now checked on CI

2018-11-08 Thread Manish Goregaokar
Directly run rustfmt on the file, with `rustfmt foo.rs`. you may need to install it with `rustup component add rustfmt` On Thu, Nov 8, 2018, 6:50 PM Avanthikaa Ravichandran We are working on the media crate for servo and we were asked to run the > rustfmt to format the code. However, in the servo

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-07 Thread Manish Goregaokar
No, that creates an empty (silent) buffer for the oscillator generation to write to. The code that needs rewriting is the code that calls sin(). -Manish Goregaokar On Wed, Nov 7, 2018 at 3:27 PM Avanthikaa Ravichandran wrote: > Thank you for your response. > I was also wondering

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-06 Thread Manish Goregaokar
Yeah, it is fine to remove the Copy. On Tue, Nov 6, 2018, 5:09 PM Avanthikaa Ravichandran Hi, > I am trying to write an implementation for the PeriodicWaveOptions in the > oscillator node. The parameters for this - real and imaginary, do not have > fixed sizes at compile time since they depend on

Re: [dev-servo] Trychooser support now live!

2018-08-15 Thread Manish Goregaokar
eding that yesterday when doing infra upgrades. Thanks, -Manish Goregaokar On Thu, Aug 9, 2018 at 3:31 PM Manish Goregaokar wrote: > > Trychooser support <https://github.com/servo/homu/pull/167> is now live > on homu! > > This means that instead of `@bors-servo try`, you ca

[dev-servo] Trychooser support now live!

2018-08-09 Thread Manish Goregaokar
me) Let me know if there are any issues! Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] ./mach build vs. cargo build

2018-04-04 Thread Manish Goregaokar
IMO those reasons do not apply to toplevel flags; and given that Cargo profiles are a thing we really should have a rustflags key there. I've always had trouble with getting IDEs working with servo because of this. -Manish Goregaokar On Wed, Apr 4, 2018 at 6:12 AM, Lars Bergstrom

Re: [dev-servo] RFC: Require rustup.rs to build Servo with mach

2017-11-14 Thread Manish Goregaokar
We can explicitly call `cargo +stable build` for geckolib, and have a min version check in mach. We'll only get the rust-toolchain file pinning for one of the two and will have to build some mach stuff for the other, but it will be considerably simpler than what we have right now. I think we shou

Re: [dev-servo] Should commits landed in servo individually pass all tests?

2017-11-03 Thread Manish Goregaokar
I also think that if we care so strongly about tests passing per-commit we should be testing that (though that's also expensive); because as-is I'm quite certain that bisect without first-parent would *regularly* break tests on the way; and that's not just because *I*'ve not be

[dev-servo] Should commits landed in servo individually pass all tests?

2017-11-02 Thread Manish Goregaokar
sically forces large refactorings to be a single commit Thoughts? -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Memory reporting in Servo: the next step

2017-10-05 Thread Manish Goregaokar
If we do impls in the mallocsizeof crate is we can't make use of the custom derive functionality and have to manually write out impls (which in many cases won't be possible). So I'm not sure if we can completely get rid of the dependency problem. -Manish Goregaokar On Thu, Oct 5

Re: [dev-servo] Memory reporting in Servo: the next step

2017-10-05 Thread Manish Goregaokar
bstitute MallocSizeOfOps as would be good. -Manish Goregaokar On Thu, Oct 5, 2017 at 9:05 PM, Nicholas Nethercote wrote: > On Fri, Oct 6, 2017 at 2:33 PM, Xidorn Quan wrote: > > > > > There are multiple Servo dependencies on crates.io depend on heapsize. > > [1] How are they handl

Re: [dev-servo] Categorizing Stylo reftest failures

2017-08-09 Thread Manish Goregaokar
https://gist.github.com/Manishearth/086118c940ff86a6cfc573f53c508279 I've now gone through the failures and categorized them as yes/no/maybe based on whether they should block shipping. I've filed bugs for and partially investigated all of the "yes" ones (and fixed some of them). Some of these bug

Re: [dev-servo] Zhitin Zhu's intern presentation on Magic DOM

2017-07-25 Thread Manish Goregaokar
Update: Simran's presentation is now at 3:15pm – 3:30pm PDT -Manish Goregaokar On Tue, Jul 25, 2017 at 3:37 PM, Manish Goregaokar wrote: > Servo has a whole block of intern presentations then! > > Starting at 2PM PDT: > > >- 2PM: Liz Lucas on detecting interstitia

Re: [dev-servo] Zhitin Zhu's intern presentation on Magic DOM

2017-07-25 Thread Manish Goregaokar
Servo has a whole block of intern presentations then! Starting at 2PM PDT: - 2PM: Liz Lucas on detecting interstitials via machine learning - 2:15PM: Simran Gujral on TLS in Servo - 2:30PM: Zhiting Zhu on Magic DOM Hope you join us for all of these! Thanks, -Manish Goregaokar On

Re: [dev-servo] Categorizing Stylo reftest failures

2017-07-24 Thread Manish Goregaokar
We aren't! I'm just not seeing that bug in the reftests outside of audio and video, and TYLin is already looking into it anyway. Thanks, -Manish Goregaokar On Mon, Jul 24, 2017 at 8:20 AM, Boris Zbarsky wrote: > On 7/24/17 1:53 AM, Manish Goregaokar wrote: >> >> and

Re: [dev-servo] Categorizing Stylo reftest failures

2017-07-23 Thread Manish Goregaokar
w are first-line and the styloVsGecko / issue (which does not block landing since it's a slight discrepancy between stylo and gecko) -Manish Goregaokar On Thu, May 11, 2017 at 5:19 PM, Manish Goregaokar wrote: > And, it's done! All reftest failures classified. > > Perma

Re: [dev-servo] Consider using GitCop

2017-06-02 Thread Manish Goregaokar
Note that in most cases "bug X" isn't deliberate, it's due to `git am`ing a patch extracted from a gecko repo and forgetting to remove the Gecko stuff. That said, it does get linkified on the gecko side if it's in the PR title. I'm not very fond of the length lim

[dev-servo] All properties implemented in Stylo!

2017-05-28 Thread Manish Goregaokar
incomplete in their implementation (the basic property is supported but not some specific value), or may have bugs, but that will get fixed as we attack the reftests. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https

Re: [dev-servo] Categorizing Stylo reftest failures

2017-05-11 Thread Manish Goregaokar
of what needs to be fixed. I will try to investigate things which still fail when their corresponding bug lands. Thanks, -Manish Goregaokar On Wed, May 10, 2017 at 5:14 PM, Manish Goregaokar wrote: > So I took a try push with all expectations set as passing and went about > categorizing th

Re: [dev-servo] Categorizing Stylo reftest failures

2017-05-10 Thread Manish Goregaokar
First link in the file! https://treeherder.mozilla.org/#/jobs?repo=try&revision=bff0878649f10db8946d50e760b0d13f0f3be9be Also, each section in the file already links to the analyzer results for that subset of the tests. -Manish Goregaokar ___

[dev-servo] Categorizing Stylo reftest failures

2017-05-10 Thread Manish Goregaokar
o write some scripts that let me keep this doc somewhat up to date as major groups of failures get fixed. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] good work, just a typo to fix

2017-03-25 Thread Manish Goregaokar
Fixed, thanks. https://github.com/servo/download.servo.org/pull/23 -Manish Goregaokar On Sat, Mar 25, 2017 at 2:55 PM, Tom Caldwell wrote: > Good work so far team! Servo is with faster load times (better than > Firefox > 52, latest Chrome, and MS Edge.) > > > > Here

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Manish Goregaokar
FWIW gps planned to strip @mentions in the autosync service, so most of the pain here could go away. It already strips the boilerplate. -Manish Goregaokar On Wed, Mar 1, 2017 at 9:35 AM, Jack Moffitt wrote: > I agree that seems noisy and irrelevant I could have sworn we > previously

[dev-servo] Useful tools for current Stylo workflow

2017-02-18 Thread Manish Goregaokar
arth/1d1da99296dbff10c003bd3db4bf6e58 for quickly setting test expectations. You can just copy the error summary into a file and feed it to the script, which will update all the relevant list files. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Quantum CSS (stylo) builds now on m-c

2017-02-13 Thread Manish Goregaokar
will run CI as usual so Firefox can't introduce bugs. Servo may uncover a bug that needs Firefox changes to fix, in which case you have to submit the unified change via the Firefox contribution process. -Manish Goregaokar On Mon, Feb 13, 2017 at 1:40 PM, Anthony Ramine wrote: > I ha

Re: [dev-servo] stylo: Consider spliting gecko bindings (style/gecko_{bindings, string_cache}) into a separate crate / component?

2016-12-15 Thread Manish Goregaokar
ch as possible :) -Manish Goregaokar On Thu, Dec 15, 2016 at 12:50 AM, Xidorn Quan wrote: > Oh, I see what did you mean. ElementData and AtomicRefCell would be a > problem. I don't see anything else, though. > > - Xidorn > > On Thu, Dec 15, 2016, at 05:29 PM, Manish Goregaokar w

Re: [dev-servo] stylo: Consider spliting gecko bindings (style/gecko_{bindings, string_cache}) into a separate crate / component?

2016-12-14 Thread Manish Goregaokar
it with the types replaced. Generating it would still require the bindings build step to write code for the style crate however. I wasn't sure if we could trust manually writing it. On Dec 14, 2016 10:45 PM, "Simon Sapin" wrote: > On 15/12/16 02:01, Manish Goregaokar wrote: &g

Re: [dev-servo] stylo: Consider spliting gecko bindings (style/gecko_{bindings, string_cache}) into a separate crate / component?

2016-12-14 Thread Manish Goregaokar
The sugar stuff is just helpers. The crossover happens in the bindings file itself, where &ServoOpaqueType gets replaced with &RealType, etc. On Dec 14, 2016 5:13 PM, "Xidorn Quan" wrote: > On Thu, Dec 15, 2016, at 12:01 PM, Manish Goregaokar wrote: > > They used

Re: [dev-servo] stylo: Consider spliting gecko bindings (style/gecko_{bindings, string_cache}) into a separate crate / component?

2016-12-14 Thread Manish Goregaokar
They used to be a different crate. I merged them so that we can do replacements with safer wrappers and have fewer coherence issues. Perhaps we can make triggering local build time bindgen regen more explicit? On Dec 14, 2016 2:57 PM, "Xidorn Quan" wrote: > I'm thinking about splitting those pa

Re: [dev-servo] CSSOM ownership woes

2016-11-14 Thread Manish Goregaokar
be wrapped in a cleaner API (haven't had a chance to properly look through that yet, and most of the parsing is just parsing of PropertyDeclarationBlocks). -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] CSSOM ownership woes

2016-11-11 Thread Manish Goregaokar
> Or probably asserting that we're not in a Servo Layout thread when we > `borrow_mut`? Not perfect, but... Extra runtime check and I'm not fond of this solution in general, since it's runtime. The token thing is a pure compile time option. Making it !Send+!Sync means that it's hard to make it ac

[dev-servo] CSSOM ownership woes

2016-11-11 Thread Manish Goregaokar
le/stylesheets/struct.Stylesheet.html [2]: https://doc.servo.org/style/stylesheets/struct.MediaRule.html Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] PSA: Mac debugging tips for Servo and Stylo

2016-11-09 Thread Manish Goregaokar
move the -g if you're not hacking on gdb itself.) -Manish Goregaokar On Wed, Nov 9, 2016 at 11:43 AM, Jim Blandy wrote: > If you're on Linux, GDB 7.12 has Rust support. Fedora hasn't packaged that > yet, but I did this to get a fresh GDB that I can run from ~/gdb/bin: > >

Re: [dev-servo] Upgrading Hyper version in Servo

2016-10-29 Thread Manish Goregaokar
./mach update-cargo -p hyper should work -Manish Goregaokar On Fri, Oct 28, 2016 at 10:09 PM, Raghavendra Nayak Muddur wrote: > Hi, > > We are 3 people from NCSU working on "Network Security Project". We have > completed initial steps and got pull request to add 2 enum

[dev-servo] Servo is a featured project on Hacktoberfest!

2016-09-30 Thread Manish Goregaokar
lks to contribute to. I got Servo added to the list -- expect an uptick in new contributors in this month. I'll start filing more easy issues. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/l

Re: [dev-servo] Weekly status updates

2016-09-22 Thread Manish Goregaokar
orked more on X", with standups this might become cluttered. But this is minor, and probably could be fixed by being more descriptive of the subtasks. Thanks, -Manish Goregaokar On Thu, Sep 22, 2016 at 9:37 PM, Lars Bergstrom wrote: > I've noticed that while some people are s

Re: [dev-servo] Filterable list of all CSS properties and their syntax

2016-08-29 Thread Manish Goregaokar
anish Goregaokar On Mon, Aug 29, 2016 at 4:41 PM, Manish Goregaokar wrote: > On Mon, Aug 29, 2016 at 2:23 PM, Chris Peterson > wrote: > > Stylo has implemented exactly one property Gecko has not: column-width. > > Oh, that's because Firefox implements it as -moz-column-width. I

Re: [dev-servo] Filterable list of all CSS properties and their syntax

2016-08-29 Thread Manish Goregaokar
field, but I didn't because I don't know how to prioritize most of these properties. The Alexa numbers will certainly help, though. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

[dev-servo] Filterable list of all CSS properties and their syntax

2016-08-28 Thread Manish Goregaokar
rg/p/stylo-wikipedia-properties with difficulty and priority included. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Moving style out of tree as an alternative to frankenbuild?

2016-08-25 Thread Manish Goregaokar
> Your proposal scares me in the sense that (if I read it well) it would > be at least temporarily allowing changing the style system without > gating on Servo. There are architectural changes to the style system > that work for Gecko, but would completely break Servo. > Right now landing a change

Re: [dev-servo] Moving style out of tree as an alternative to frankenbuild?

2016-08-25 Thread Manish Goregaokar
> The other proposal includes making sure Gecko related stylo changes > don't break Servo, but this does not. It seems easy enough to add > Servo's test suite to the m-c side CI, so I would propose to add that > to your proposal. That means we only have to resolve conflicts until > CI is fully bake

[dev-servo] Moving style out of tree as an alternative to frankenbuild?

2016-08-25 Thread Manish Goregaokar
Hi, The current situation with the m-c vendoring for stylo is to put all of stylo in-tree and have an autolander dance between homu (or at least Servo buildbot) and the Gecko autolander that ensures that changes to servo/servo or m-c are always mirrored and fully tested, on both ends. There are a

Re: [dev-servo] Problem compiling servo

2016-08-13 Thread Manish Goregaokar
rm -rf target/*/build/mozjs* should do the trick. There was a spidermonkey update and the old build artefacts mess the build up. Sorry! -Manish Goregaokar On Sat, Aug 13, 2016 at 7:18 PM, Peter Hall wrote: > Hi, > I upgraded OSX this week (to 10.11.6), but also it's been a wh

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-08-09 Thread Manish Goregaokar
of trying to marry two opposite CI models together. But like I said it's expected to be rare so it shouldn't be an issue. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Feature detector detector for Servo debugging

2016-08-09 Thread Manish Goregaokar
It triggers for all, but the python script filters for accesses to properties that actually should be there. I wanted it to be easy to change the filtering logic without recompiling everything. -Manish Goregaokar ___ dev-servo mailing list dev-servo

[dev-servo] Feature detector detector for Servo debugging

2016-08-09 Thread Manish Goregaokar
is, so I'm seeing if a cleaned-up version of this might be something we can merge into the main codebase. Let me know if there are sites you'd like to see this run against! Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-08-04 Thread Manish Goregaokar
irefox, because these aren't bootstrapping compilers :) Rust finally went with manual rollups -- they used to be really time consuming but now it's mostly okay. Intermittents were a big problem then, too, and would have broken this model completely. Currently Servo has a pretty high rate o

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-08-02 Thread Manish Goregaokar
This sounds like a useful optimization; and it can be applied to the system after it is set up. I believe that the autoland model works like this anyway, though I'm not 100% sure. But we could do this on the Servo side. -Manish Goregaokar __

Re: [dev-servo] Web console protocol support for Servo

2016-07-08 Thread Manish Goregaokar
ses some HTML/CSS features that Servo doesn't yet > support. We could file bugs for these if they would be of interest to you; > would they? Yes please :) Might be worth creating some labels similar to the browserhtml ones to help prioritize these. -Manish Goregaokar __

Re: [dev-servo] Getting rid of the "Servo unexpectedly quit last time; reopen/don't reopen" dialog on OS X

2016-07-05 Thread Manish Goregaokar
The `defaults` command can be used directly on plist files, so done: https://github.com/servo/servo/pull/12267 -Manish Goregaokar On Tue, Jul 5, 2016 at 9:42 PM, Josh Matthews wrote: > Servo occasionally gets into a state where it continually wants to reopen > the windows from the la

Re: [dev-servo] Panic reports belong in a separate repository

2016-07-05 Thread Manish Goregaokar
I like this idea -Manish Goregaokar On Mon, Jul 4, 2016 at 9:06 PM, Josh Matthews wrote: > While there can be advantages to having them integrated directly into > servo/servo, the sheer volume of reports is making my usual practices of > keeping on top of things happening in se

Re: [dev-servo] Stacks reported in automated panic reports cannot be trusted

2016-07-03 Thread Manish Goregaokar
Right. I think we should do both -- Servo should report these errors in a truncated form (single line with error contents and location), and bhtml can either filter these out or include them in the error reporting box until it gets a real backtrace -Manish Goregaokar On Sun, Jul 3, 2016 at 9:11

Re: [dev-servo] Stacks reported in automated panic reports cannot be trusted

2016-07-02 Thread Manish Goregaokar
At one point we were silencing MPSC and IPC errors so that the main backtrace is the only thing you see. Perhaps we should do that again? dev-servo@lists.mozilla.org wrote: > Is it possible to get the correct stack somehow? > > jack. > > On Sat, Jul 2, 2016 at 3:33 PM, Josh Matthews wrote: >>

[dev-servo] New github milestone: Tech Demo

2016-06-29 Thread Manish Goregaokar
I've created a new milestone on GitHub, Tech Demo <https://github.com/servo/servo/milestones/Tech%20Demo>. Please use it for issues or pull requests that are related to or must be landed before the tech demo. Thanks, -Manish Goregaokar __

Re: [dev-servo] Standardizing upgrade procedures for crates.io dependencies for servo/servo

2016-06-23 Thread Manish Goregaokar
resumably we want to crawl >> the Cargo.toml files in that case? And again, will it be obvious that needs >> to happen from the Cargo.lock diff? >> >> On Thu, Jun 23, 2016 at 9:32 AM, Manish Goregaokar >> wrote: >>> We rarely use ranges, just a minimum version,

Re: [dev-servo] Standardizing upgrade procedures for crates.io dependencies for servo/servo

2016-06-23 Thread Manish Goregaokar
We rarely use ranges, just a minimum version, and aside from major version differences cargo just picks the max. dev-servo@lists.mozilla.org wrote: > Is there a risk that non-overlapping version ranges in dependent Cargo.toml > files will cause multiple versions of the package to be imported? Or

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-22 Thread Manish Goregaokar
Coordinating rollups across two repos will be a pain. The proposed automation sounds better to me. -Manish Goregaokar On Thu, Jun 23, 2016 at 10:08 AM, Michael Howell wrote: > If the model you're proposing is "almost isomorphic" to roll ups, then why > not just use roll up

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-22 Thread Manish Goregaokar
icts. > You make it sound like refactorings don't introduce bugs. ;) > Sure they can, but they should be less likely to :) We will still have the full CI run on a sync so these will get caught, just not immediately. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-22 Thread Manish Goregaokar
become less of a pain, while actual changes affecting both will still be tested. The reverse can also exist, as a checkbox in the trychooser interface. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-22 Thread Manish Goregaokar
anges will trigger a m-c CI build in Servo. Do lockfile changes cause this build? What about edits to util? Thanks, -Manish Goregaokar On Tue, Jun 21, 2016 at 4:16 PM, Manish Goregaokar wrote: > My main issue is that backouts aren't addressed. They are reasonably > common in m-c (admitt

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

2016-06-21 Thread Manish Goregaokar
oo, mostly script and then layout -- so it might be best to not split style out. Thanks, -Manish Goregaokar On Mon, Jun 20, 2016 at 8:31 PM, Lars Bergstrom wrote: > As many of you may have seen from the document > ( > https://docs.google.com/document/d/1uubYE7JXaVY10PoAY9BVx8A-T11Zx

Re: [dev-servo] Servo without Bluetooth

2016-06-02 Thread Manish Goregaokar
It seems like it's still checking the git repo for the feature. Might be worth landing your devices changes and proceeding from there. -Manish Goregaokar On Thu, Jun 2, 2016 at 12:56 PM, Dirkjan Ochtman wrote: > On Wed, Jun 1, 2016 at 10:53 AM, Manish Goregaokar > wrote: > >

Re: [dev-servo] Servo without Bluetooth

2016-06-01 Thread Manish Goregaokar
It should be net/device/bluetooth. For some reason the crate is imported as "device" instead of "devices" in net -Manish Goregaokar On Wed, Jun 1, 2016 at 1:29 PM, Dirkjan Ochtman wrote: > On Tue, May 31, 2016 at 4:51 PM, Simon Sapin wrote: > >> It is possi

Re: [dev-servo] Servo without Bluetooth

2016-05-31 Thread Manish Goregaokar
Oh, interesting. I have had strange errors when not fully specifying the features but the reason might have been something else. We should just do that, then, agreed. -Manish Goregaokar On Tue, May 31, 2016 at 8:21 PM, Simon Sapin wrote: > On 31/05/16 16:40, Manish Goregaokar wrote: >

Re: [dev-servo] Servo without Bluetooth

2016-05-31 Thread Manish Goregaokar
endency paths do not have it enabled). If this turns out to be working reliably I'd prefer to do this, though it may unexpectedly break in the future. -Manish Goregaokar On Tue, May 31, 2016 at 8:04 PM, Jack Moffitt wrote: > > Doing it via Cargo features sounds like the better

Re: [dev-servo] Difficulty getting access to Rust nightly build while building Servo.

2016-05-16 Thread Manish Goregaokar
This is the folder you want: https://static.rust-lang.org/dist/2016-05-14/index.html -Manish Goregaokar On Mon, May 16, 2016 at 3:17 PM, wrote: > Hi, > > I am trying to port Servo to Power8/LE platform (ref thread: > https://groups.google.com/forum/#!topic/mozilla.dev.servo

Re: [dev-servo] Pull request template

2016-05-07 Thread Manish Goregaokar
ntry. It might also be nice to have bors' approval message note travis failures (only travis for now, appveyor isn't always passing) if a travis-failing PR is approved. -Manish Goregaokar On Fri, May 6, 2016 at 8:43 PM, Josh Matthews wrote: > Github introduced templates for issue

Re: [dev-servo] Moving away from merge commits

2016-05-05 Thread Manish Goregaokar
it > doesn't. If there is a bad merge commit, `git bisect` will clearly point > to it as the culprit; while problems introduced in a rebase will in no > way indicate the rebase as the cause. > note that git bisect gets rather muddled with merge commits unless you teach it to on

Re: [dev-servo] Moving away from merge commits

2016-04-27 Thread Manish Goregaokar
Yeah, it does, that's what homu does currently. -Manish Goregaokar On Wed, Apr 27, 2016 at 9:08 PM, Nick Fitzgerald wrote: > On Wed, Apr 27, 2016 at 8:34 AM, Matt Brubeck > wrote: > > > On Wed, Apr 27, 2016 at 7:25 AM, Manish Goregaokar < > manishsm...@gmail.com>

Re: [dev-servo] Moving away from merge commits

2016-04-27 Thread Manish Goregaokar
s some use of rev-list and skip. But it's possible; I recall doing this once. Thanks, -Manish Goregaokar On Tue, Apr 26, 2016 at 11:50 PM, Gregory Szorc wrote: > Servo developers, > > I noticed that Servo and a number of other Servo related Git repos have > tons of merge commi

Re: [dev-servo] Proposal: cancel the weekly meeting

2016-04-14 Thread Manish Goregaokar
etings aren't happening anyway. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] when to switch to webrender by default

2016-03-28 Thread Manish Goregaokar
Last time I tried it, Servo with LLVMpipe and WR wasn't too bad, even on the moire demo. It was slightly worse than Servo without WR, which IIRC has similar performance as Gecko. -Manish Goregaokar On Tue, Mar 29, 2016 at 2:20 AM, Bobby Holley wrote: > In general, does the software-

Re: [dev-servo] Questions about GSoC File Support project

2016-03-15 Thread Manish Goregaokar
-Manish Goregaokar On Wed, Mar 16, 2016 at 1:37 AM, Manish Goregaokar wrote: > > On Tue, Mar 15, 2016 at 3:13 PM, Zhen Zhang wrote: > >> >> 1. About FileList API, It is said to be *at risk* to be replaced by >> Array. <https://w3c.github.io/FileAPI/#filelist-secti

Re: [dev-servo] PSA: incoming Windows CI (AppVeyor)

2016-03-07 Thread Manish Goregaokar
It's a key milestone for stability on windows. We don't release nightlies for any desktop platform yet. Thanks, -Manish Goregaokar On Sun, Mar 6, 2016 at 8:23 AM, Phil Sweeney wrote: > Great works.. is this a key milestone for the eventual delivery of Windows > nightly bu

Re: [dev-servo] PSA: incoming Windows CI (AppVeyor)

2016-03-05 Thread Manish Goregaokar
This has been deployed. https://github.com/servo/servo/pull/9884#issuecomment-192805671 The builder is called "status-appveyor" and behaves similar to Travis. I'll be watching the queue today and tomorrow. Revert the salt deployment if anything goes wrong. Thanks, -Manish larsb...@mozilla.co

Re: [dev-servo] Fwd: Re: Suggested code review workflow

2016-02-21 Thread Manish Goregaokar
ype PR messages since nobody wants to retype what the issue says. -Manish Goregaokar On Sun, Feb 21, 2016 at 5:58 AM, Lars Bergstrom wrote: > This may also be less of a big deal here at Mozilla, where there's > (presumably?) only been one bug database since 1998 and will only be > one

Re: [dev-servo] IndexDB project

2015-12-14 Thread Manish Goregaokar
More or less. If you're going to pick leveldb it would be better to use rocksdb (which is a leveldb fork, IIRC) since there is a Rust wrapper that's in use by others. -Manish Goregaokar On Tue, Dec 15, 2015 at 11:03 AM, Shing Lyu wrote: > Thank you guys. > > So from what I

Re: [dev-servo] IndexDB project

2015-12-14 Thread Manish Goregaokar
g necessary things too, not only focusing on new experiments :) Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] IndexDB project

2015-12-14 Thread Manish Goregaokar
Apparently SQlite4 has a good kv store included, but nox knows it better and understands the justification. I think firefox uses sqlite (3?); it uses sqlite for everything. -Manish Goregaokar On Tue, Dec 15, 2015 at 9:12 AM, Jack Moffitt wrote: > Why would we use a nearly full sql eng

Re: [dev-servo] IndexDB project

2015-12-14 Thread Manish Goregaokar
We were thinking of SQLite4, however there seem to be people <https://twitter.com/floydophone/status/676540491068891137> using rocksdb+rust in production (https://github.com/spacejam/rust-rocksdb?) -Manish Goregaokar On Tue, Dec 15, 2015 at 8:57 AM, Jack Moffitt wrote: > Probably th

  1   2   >