If we do impls in the mallocsizeof crate is we can't make use of the custom derive functionality and have to manually write out impls (which in many cases won't be possible).
So I'm not sure if we can completely get rid of the dependency problem. -Manish Goregaokar On Thu, Oct 5, 2017 at 10:11 PM, Simon Sapin <simon.sa...@exyr.org> wrote: > On 06/10/2017 06:05, Nicholas Nethercote wrote: > >> If we went with the second option from my original mail (i.e. stop using >> heapsize) then it would probably make sense to deprecate heapsize >> entirely, >> stop those crates from depending on it, and implement the MallocSizeOf >> trait for those crates' types within Servo. >> > > I’m in favor of this. > > It does create a contention point in the dependency graph (malloc_size_of > depends on many crates, and many other crates depend on malloc_size_of). > But the current heapsize situation (crates in many repositories depend on > heapsize) is also a pain whenever we want to make breaking changes to > heapsize. > > -- > Simon Sapin > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
