Note that in most cases "bug X" isn't deliberate, it's due to `git am`ing a patch extracted from a gecko repo and forgetting to remove the Gecko stuff. That said, it does get linkified on the gecko side if it's in the PR title.
I'm not very fond of the length limit imposed by GitCop. -Manish Goregaokar On Fri, Jun 2, 2017 at 8:00 AM, Boris Zbarsky <bzbar...@mit.edu> wrote: > On 6/2/17 5:18 AM, Anthony Ramine wrote: > >> In the following screenshot, you can see one doesn't even know what that >> commit is supposed to do from its title, because it is way too long to be >> informative. >> > > OK, what is the proposed cap on first line of commit message? > > Everything I've seen suggests the first line should be a one-sentence > simple summary of what's going on. The fact that github insists on cutting > it off to pretty short lengths, shorter than most sentences, is a bit > unfortunate. > > Or concretely, what would you say one should use instead of "Being > affected by id selectors should not prevent an element from being inserted > in the style sharing cache" as a first line? > > I also want to argue that the very "bug X - " prefix is counterproductive >> in Servo commits >> > > If we don't propagate those servo commits as separate commits to the Gecko > side, then I agree. I've just been putting the full bugzilla link in the > non-first line of the commit message. > > -Boris > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
