IMO those reasons do not apply to toplevel flags; and given that Cargo profiles are a thing we really should have a rustflags key there. I've always had trouble with getting IDEs working with servo because of this.
-Manish Goregaokar On Wed, Apr 4, 2018 at 6:12 AM, Lars Bergstrom <larsb...@mozilla.com> wrote: > Cargo has traditionally not wanted to add full support for arbitrary > RUSTFLAGS, for reasonable reasons: > https://github.com/rust-lang/cargo/issues/60#issuecomment-51705597 > > What we've done in the past is for each flag that we needed exposed opened > a specific Issue or PR to Cargo to have just that one feature either added > to the allowed flags list or as a new toplevel item in the profile. I'd at > least check those out first before regressing link performance > significantly or adding a local development footgun (only checking certain > warnings in CI and requiring people to take an extra trip through the homu > queue to find out things they could have tested locally). > > FWIW, I agree totally - any reasonable IDE is not going to respect usage of > `mach` to set env vars and we'd LOVE to have all this stuff in Cargo > configs. The use of RUSTFLAGS in mach has traditionally been a staging area > for features not yet turned on by default in rustc or not yet supported for > configuration in cargo (especially in the dark old days of cross > compilation woes - much better now!). > - Lars > > > On Tue, Apr 3, 2018 at 4:44 PM, Simon Sapin <simon.sa...@exyr.org> wrote: > > > On 03/04/18 23:30, Emilio Cobos Álvarez wrote: > > > >> or the bit to use the gold linker. > >> > > > > The best outcome IMO would be to make that the default: > > https://github.com/rust-lang/rust/issues/30783 > > > > This was implemented and then reverted because of Debian Wheezy > > (oldoldstable), whose LTS ends next month in May. > > > > My pings on the issue a few months ago did not get a response, so the > next > > step is probably sending a PR and picking someone on the compiler team to > > nag for review. > > > > -- > > Simon > > > > _______________________________________________ > > dev-servo mailing list > > dev-servo@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-servo > > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
