The reviewer has to leave a comment saying `@bors-servo r+` to inform our bot that the pull request needs merging. Once that happens, you can wait.
If you have an approving Github review but no r+, make sure you've addressed any straggling issues and ping the reviewer. -Manish Goregaokar On Mon, Apr 29, 2019 at 4:24 PM Maria Sable <masa...@ncsu.edu> wrote: > Hi all, > > Sorry if this is a dumb question. I looked at the Contributing page on the > Servo wiki and was not able to find an answer for it. > > Once I have a pull request with an approving review, do I need to take any > additional steps to get it merged into master? Or will the person who > reviewed it merge it? > > Kind regards, > Maria Sable > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
