dependabot[bot] opened a new pull request, #31:
URL: https://github.com/apache/tomcat-training/pull/31
Bumps [socket.io](https://github.com/socketio/socket.io) from 2.3.0 to 4.7.2.
Release notes
Sourced from https://github.com/socketio/socket.io/releases";>socket.io's
releases.
dependabot[bot] commented on PR #30:
URL: https://github.com/apache/tomcat-training/pull/30#issuecomment-1745284397
Looks like grunt-contrib-connect is no longer a dependency, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the messa
dependabot[bot] commented on PR #31:
URL: https://github.com/apache/tomcat-training/pull/31#issuecomment-1745284410
Looks like socket.io is no longer a dependency, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dependabot[bot] closed pull request #30: Bump grunt-contrib-connect from 2.1.0
to 4.0.0
URL: https://github.com/apache/tomcat-training/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
dependabot[bot] commented on PR #29:
URL: https://github.com/apache/tomcat-training/pull/29#issuecomment-1745284506
Looks like grunt-zip is no longer a dependency, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dependabot[bot] closed pull request #32: Bump grunt-contrib-uglify from 3.4.0
to 5.2.2
URL: https://github.com/apache/tomcat-training/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dependabot[bot] closed pull request #29: Bump grunt-zip from 0.17.1 to 0.20.0
URL: https://github.com/apache/tomcat-training/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
dependabot[bot] closed pull request #28: Bump node-sass from 4.13.0 to 9.0.0
URL: https://github.com/apache/tomcat-training/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
dependabot[bot] opened a new pull request, #33:
URL: https://github.com/apache/tomcat-training/pull/33
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.7 to 8.4.31.
Release notes
Sourced from https://github.com/postcss/postcss/releases";>postcss's
releases.
8.4.3
dependabot[bot] closed pull request #31: Bump socket.io from 2.3.0 to 4.7.2
URL: https://github.com/apache/tomcat-training/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
dependabot[bot] commented on PR #32:
URL: https://github.com/apache/tomcat-training/pull/32#issuecomment-1745284562
Looks like grunt-contrib-uglify is no longer a dependency, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the messag
dependabot[bot] commented on PR #28:
URL: https://github.com/apache/tomcat-training/pull/28#issuecomment-1745284673
Looks like node-sass is no longer a dependency, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chenggwang opened a new pull request, #671:
URL: https://github.com/apache/tomcat/pull/671
NioChannel's toString() causes NioEndpoint's setSocketOptions method to
throw a NullPointerException in some scenarios (e.g. idea breakpoint debugging).
--
This is an automated message from the Apac
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1755822815
`protected boolean setSocketOptions(SocketChannel socket) {
NioSocketWrapper socketWrapper = null;
try {
// Allocate channel and wrapper
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1755896980
```java
protected boolean setSocketOptions(SocketChannel socket) {
NioSocketWrapper socketWrapper = null;
try {
// Allocate channel and wrapper
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1756826381
Can someone please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
CharliesAngel1 commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1756870192
oook
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
michael-o commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1761073554
@markt-asf Are we good to merge this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
rmaucher commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1761084688
The benefit seems null IMO, in the debugger it will print out that this is
null instead of a NPE, which should mean the same for a developer. Also,
Nio2Channel.toString is the same.
--
T
michael-o opened a new pull request, #20:
URL: https://github.com/apache/tomcat-native/pull/20
…fig#certificateKeystorePasswordFile
This has been done on purpose because Tomcat is not the only consumer of
this library and this should be available consistently to everyone out there.
michael-o opened a new pull request, #672:
URL: https://github.com/apache/tomcat/pull/672
NOTE: Disregard the `[TEMPORARY]` commits, they are for testing purposes
only and will *not* be merged.
Test matrix:
* OpenSSL: 1.1.1, 3.0
* Tomcat Native: 1.2, 2.0
* OS: Windows, HP
michael-o commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1761094466
> The benefit seems null IMO, in the debugger it will print out that this is
null instead of a NPE, which should mean the same for a developer. Also,
Nio2Channel.toString is the same.
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761136665
I don't get it overall. Since that's what ultimately happens (the
tomcat-native patch simply does that), I think the content of the files should
simply be loaded as the password in the Java
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761153823
> I don't get it overall. Since that's what ultimately happens (the
tomcat-native patch simply does that), I think the content of the files should
simply be loaded as the password in the J
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761170846
Ok trying again. So the code addition in tomcat-native simply uses a file
BIO to load the contents of the file and use it as a password. So overall, I do
not understand the benefit of the r
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761175235
> Ok trying again. So the code addition in tomcat-native simply uses a file
BIO to load the contents of the file and use it as a password. So overall, I do
not understand the benefit of th
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761197570
For certificate (key) file, there's an attempt to always use PEMFile. When
that fails, it uses the code path where it simply passes the file name, since
that's what the native API has had s
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761201586
> For certificate (key) file, there's an attempt to always use PEMFile. When
that fails, it uses the code path where it simply passes the file name, since
that's what the native API has ha
rmaucher commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358020057
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
michael-o commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358027078
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
michael-o commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358027078
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
rmaucher commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358035893
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
michael-o commented on code in PR #672:
URL: https://github.com/apache/tomcat/pull/672#discussion_r1358038098
##
java/org/apache/tomcat/util/net/SSLHostConfig.java:
##
@@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws
FileNotFoundExceptio
michael-o opened a new pull request, #21:
URL: https://github.com/apache/tomcat-native/pull/21
This patch has been recently removed because it does not apply to the latest
version. Bring back an updated patch because Tomcat Native 1.2.x still supports
1.1.1 for those who need it on Windows,
ChristopherSchultz commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762120662
I'm a -0 on loading the password from native code. I would support
"consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in
libtcnative if we wanted to go fo
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762123047
> I'm a -0 on loading the password from native code. I would support
"consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in
libtcnative if we wanted to go for that.
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762132365
> I'm a -0 on loading the password from native code. I would support
"consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in
libtcnative if we wanted to go for that.
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762134403
> > I'm a -0 on loading the password from native code. I would support
"consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in
libtcnative if we wanted to go for tha
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1762749332
> The benefit seems null IMO, in the debugger it will print out that this is
null instead of a NPE, which should mean the same for a developer. Also,
Nio2Channel.toString is the same.
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1762757733
@rmaucher @markt-asf @michael-o Such a change in tomcat functionality does
not help, but after the initialization of the NioChannel object should provide
a reliable, stable function, can
kkolinko commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763032642
I do not like the use of "?:" operator here.
Just simple `... + ":" + sc;` is enough, or if you want to be explicit `+
":" + String.valueOf(sc);`
--
This is an automated message from
kkolinko commented on PR #667:
URL: https://github.com/apache/tomcat/pull/667#issuecomment-1763097366
From code review point of view: -1
1. No error handling.
2. No configuration.
The `rollbackOnReturn` option should take care of the original BZ issue. And
if there is a bug,
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763120686
> I do not like the use of "?:" operator here. Just simple `... + ":" + sc;`
is enough, or if you want to be explicit `+ ":" + String.valueOf(sc);`
If we don't consider the constant
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763157260
This is a bug that tomcat itself just doesn't realize. Because it doesn't
need to call toString immediately after the `NioChannel` object is
created.However, for third-party software that
markt-asf commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763192873
If we are going to do anything for this
> Just simple `... + ":" + sc;` is enough
works for me if applied to both NIO and NIO2 rather than just NIO.
--
This is an automated
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763278643
> If we are going to do anything for this
>
> > Just simple `... + ":" + sc;` is enough
>
> works for me if applied to both NIO and NIO2 rather than just NIO
Ok!Mark，I'
michael-o commented on PR #20:
URL: https://github.com/apache/tomcat-native/pull/20#issuecomment-1766101658
@ChristopherSchultz @rmaucher To sum up your thoughts from
https://github.com/apache/tomcat/pull/672: you are rather neutral on this,
don't see a need, but won't object the merge? Is
michael-o commented on PR #21:
URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766102093
If I don't have any objections I will merge this in the next couple of days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
markt-asf commented on PR #21:
URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766206442
I don't think this PR should be applied. 1.1.1 is no longer supported on
Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
michael-o commented on PR #21:
URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766217900
> I don't think this PR should be applied. 1.1.1 is no longer supported on
Windows.
The problem *I* have is that we still allow 1.x to build and link against
1.1.1, thus any ch
markt-asf commented on PR #21:
URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766227205
I disagree. OpenSSL 1.1.1 is no longer supported on Windows. There is no
need to support building Tomcat Native with OpenSSL on Windows.
OpenSSL 1.1.1 is supported on some Linux dis
michael-o commented on PR #21:
URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766232407
> I disagree. OpenSSL 1.1.1 is no longer supported on Windows. There is no
need to support building Tomcat Native with OpenSSL on Windows. OpenSSL 1.1.1
is supported on some Linux dis
markt-asf commented on PR #21:
URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766273379
No, that is not my position. I've updated my comment to clarify my position.
Users that want to build for Windows from source can do so. They need to use a
currently supported version
markt-asf commented on PR #20:
URL: https://github.com/apache/tomcat-native/pull/20#issuecomment-1766282488
That wasn't how I read their comments.
I don't see the need for this. We should be minimising use of Native code
and the transitions between Java and Native code. If functionality c
michael-o commented on PR #20:
URL: https://github.com/apache/tomcat-native/pull/20#issuecomment-1766301394
> That wasn't how I read their comments. I don't see the need for this. We
should be minimising use of Native code and the transitions between Java and
Native code. If functionality c
michael-o commented on PR #21:
URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766350741
> No, that is not my position. I've updated my comment to clarify my
position. Users that want to build for Windows from source can do so. They need
to use a currently supported versi
michael-o commented on PR #20:
URL: https://github.com/apache/tomcat-native/pull/20#issuecomment-1769102946
Closing as described in
https://github.com/apache/tomcat/pull/672#issuecomment-1769101843.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
michael-o closed pull request #20: BZ 66670: Add
SSLHostConfig#certificateKeyPasswordFile and SSLHostCon…
URL: https://github.com/apache/tomcat-native/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1769101843
Guys, I have now changed the code by reading the password file for OpenSSL
in Java, instead of C. Please have a look again.
--
This is an automated message from the Apache Git Service.
T
michael-o opened a new pull request, #22:
URL: https://github.com/apache/tomcat-native/pull/22
…ented default verify paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
michael-o commented on PR #21:
URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1770165905
Closing this and will leave the branch for some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
michael-o closed pull request #21: Reinstantiate an updated patch for OpenSSL
1.1.1 on Windows
URL: https://github.com/apache/tomcat-native/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1770353017
The Java code is a lot simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rmaucher commented on PR #22:
URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1770378729
This comes from:
https://github.com/apache/tomcat-native/commit/270c9acf8651bb1cbb4fa884e12a9761c8293938
And in ssl.c it was added in one big commit.
I don't know what the purpose
rmaucher commented on PR #22:
URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1770410908
No testsuite failures from this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
michael-o commented on PR #22:
URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1770439509
> This comes from:
[270c9ac](https://github.com/apache/tomcat-native/commit/270c9acf8651bb1cbb4fa884e12a9761c8293938)
And in ssl.c it was added in one big commit. I don't know what th
Hakky54 opened a new pull request, #673:
URL: https://github.com/apache/tomcat/pull/673
Tomcat supports configuring a custom SSLContext when configuring the
`SSLHostConfigCertificate`. However the custom SSLContext gets ignored during
the server startup and ssl initialization. A new SSLCont
rmaucher commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1772201584
It doesn't work like that because it was not supposed to. The item that
is/was supposed to be configured is the SSLImplementation, which then provides
the SSLUtil which will create the SSLC
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1772265010
I see indeed clearly that it was not the intention of the
developers/maintainers to expose a setter method to set a custom sslcontext
which is later on ignored. As it is clearly not a bug it
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1772580776
I'd like to merge this weekend unless there will be objections after my
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
rmaucher commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1772689379
Ok, and I'll update the new OpenSSLContext to do things properly
(eventually) since it would be better to use a memory BIO rather than a file
BIO.
--
This is an automated message from th
michael-o closed pull request #672: BZ 66670: Add
SSLHostConfig#certificateKeyPasswordFile and
SSLHostConfig#certificateKeystorePasswordFile
URL: https://github.com/apache/tomcat/pull/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
michael-o commented on PR #672:
URL: https://github.com/apache/tomcat/pull/672#issuecomment-1774954495
Merged into all branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775825928
There is also AES128 with OpenSSL anf should be tried as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
michael-o commented on code in PR #674:
URL: https://github.com/apache/tomcat/pull/674#discussion_r1369136617
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -64,8 +66,40 @@ public class PEMFile {
private static final byte[] OID_EC_PUBLIC_KEY =
ne
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775933882
The more ASN.1 I see in Tomcat the more I think is that we should import
Kerby ASN.1 at some point in time...
--
This is an automated message from the Apache Git Service.
To respond to t
michael-o commented on code in PR #674:
URL: https://github.com/apache/tomcat/pull/674#discussion_r1369211534
##
test/org/apache/tomcat/util/net/jsse/TestPEMFile.java:
##
@@ -118,4 +127,17 @@ private String getPath(String file) throws IOException {
return f.getCanonic
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775942678
Thanks for the hard work. I will try this tomorrow/Wednesday!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776767268
Built from your branch and I can confirm that this works with a selfsigned
and one issued by our enterprise CA.
--
This is an automated message from the Apache Git Service.
To respond to
markt-asf commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776785906
Added a test key using AES128 (test passed without additional code changes).
Fixed typo.
Removed debug code that wasn't intended to be part of the commit.
I might be persuaded to in
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776796215
Yes, through shading only to make them private. Looking at the vast amount
of code you have written already I bet that ther are also others which would
like to use such a PEM to Java Keyst
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1777163986
I am not sure whether you would consider to have this option at all. Would
you prefer me to close the issue?
--
This is an automated message from the Apache Git Service.
To respond to the
markt-asf merged PR #674:
URL: https://github.com/apache/tomcat/pull/674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
umar-sheik opened a new pull request, #41:
URL: https://github.com/apache/tomcat-maven-plugin/pull/41
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
umar-sheik closed pull request #41: Update ssh key
URL: https://github.com/apache/tomcat-maven-plugin/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
aooohan merged PR #671:
URL: https://github.com/apache/tomcat/pull/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
aooohan commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1780324734
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
aooohan commented on PR #632:
URL: https://github.com/apache/tomcat/pull/632#issuecomment-1780327810
Hi, If you want this PR to merge smoothly, please modify this change
according to markt‘s comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1780424297
> Thanks for the PR.
Thanks for all the REVIEWS!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
michael-o commented on PR #22:
URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1784891589
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
michael-o closed pull request #22: BZ 67818:
SSL#setVerify()/SSLContext#setVerify() silently set undocum…
URL: https://github.com/apache/tomcat-native/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
michael-o opened a new pull request, #675:
URL: https://github.com/apache/tomcat/pull/675
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
ChristopherSchultz commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376435849
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -56,6 +56,8 @@
import org.apache.tomcat.util.codec.binary.Base64;
import org.apache.tomcat.util.fi
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376474963
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -56,6 +56,8 @@
import org.apache.tomcat.util.codec.binary.Base64;
import org.apache.tomcat.util.file.Config
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376474963
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -56,6 +56,8 @@
import org.apache.tomcat.util.codec.binary.Base64;
import org.apache.tomcat.util.file.Config
aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377209435
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377209435
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
601 - 700 of 1988 matches
Mail list logo
