ChristopherSchultz commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376435849
########## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ########## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import org.apache.tomcat.util.file.ConfigFileLoader; import org.apache.tomcat.util.res.StringManager; +import org.ietf.jgss.GSSException; Review Comment: Where is this package sourced? It appears to be present in the JRE since at least 1.7. Interpreting the OID bytes in dotted-notation isn't very difficult. If it avoids adding a dependency or relying on a non-mandatory JRE package, I'd prefer a private implementation. If all JREs are required to provide this package, than it's safe to use IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
