kkolinko commented on PR #667: URL: https://github.com/apache/tomcat/pull/667#issuecomment-1763097366
From code review point of view: -1 1. No error handling. 2. No configuration. The `rollbackOnReturn` option should take care of the original BZ issue. And if there is a bug, behaviour of the patch should depend on the value of that option. See `o.a.t.jdbc.pool.ConnectionPool#terminateTransaction(...)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
