michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761201586
> For certificate (key) file, there's an attempt to always use PEMFile. When that fails, it uses the code path where it simply passes the file name, since that's what the native API has had since forever. It actually does not change the native code in a significant way since it would have to use a memory BIO rather than a file BIO, this is not a simple string like the password. So, if you are totally against adding the method overload in tomcat-native, please leave a comment in that specific PR. I still think, yes, you are partially right, but it does not hurt either, it just adds convenience. I'd like to know the opinion of other committers as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
