michael-o commented on PR #20: URL: https://github.com/apache/tomcat-native/pull/20#issuecomment-1766301394
> That wasn't how I read their comments. I don't see the need for this. We should be minimising use of Native code and the transitions between Java and Native code. If functionality can be performed on the Java side then it should be. And this looks like it can. A possible justification would be if there was a format of certificate that users wanted to use that could not be read by Java and had to be read by OpenSSL directly but I'm not aware of such a format at this point. Well, yes. I also admitted that this isn't necessarily crucial. I did it for the same of completeness and consistency, not just Tomcat, but also other consumers of tomcat-native. Of course, everything can be done in Java, if wanted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
