ChristopherSchultz opened a new pull request, #764:
URL: https://github.com/apache/tomcat/pull/764
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
Chenjp commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2403720730
> The performance results look odd to me. I'd expect throughput to be
significantly higher in all cases. I wonder if the request processing time is
dominating the results rather than any over
rmaucher commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794983398
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1209,7 +1213,11 @@ public void setStatus(int status) {
return;
}
-getCoyoteRes
isapir commented on PR #760:
URL: https://github.com/apache/tomcat/pull/760#issuecomment-2403740181
Oh, I see the code that you use to benchmark in the PR. Have you tried to
run an external tool like `ab` or `wrk2`?
--
This is an automated message from the Apache Git Service.
To respond
isapir commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794575451
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1069,16 +1069,20 @@ public void sendError(int status, String message)
throws IOException {
return;
isapir commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794578764
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1209,7 +1213,11 @@ public void setStatus(int status) {
return;
}
-getCoyoteRespo
LQxdu opened a new pull request, #762:
URL: https://github.com/apache/tomcat/pull/762
We found that the 10.0.x branch is also affected by
CVE-2024-24549(https://github.com/advisories/GHSA-7w75-32cg-r6g2), but it has
not been fixed yet. Therefore, we have created this patch for 10.0.x based
michael-o commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404487095
Is there now static final for that status code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
markt-asf commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405469155
> I originally wrote this patch just for Tomcat 11 but now that I think
about it, I think I should re-write it for Tomcat 12/main so that the behavior
is consistent regardless of version.
LQxdu commented on PR #762:
URL: https://github.com/apache/tomcat/pull/762#issuecomment-2404037105
During a recent network asset mapping assessment, we identified that a
significant number of services are still deployed on Tomcat 10.0.x. Given the
continued widespread use of this version, w
n828cl closed pull request #762: Report HTTP/2 header parsing errors earlier
URL: https://github.com/apache/tomcat/pull/762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
n828cl commented on PR #762:
URL: https://github.com/apache/tomcat/pull/762#issuecomment-2404044482
As previously stated, the 10.0.x branch is well past end-of-life (over three
years ago); there will be no further updates to this level. Anyone not updating
a product in that length of time c
ChristopherSchultz commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2429756034
I was also surprised recently to discover that the JVM does not cache
results of `Class.getMethods` and similar calls. Maybe it's returning a clone
each time, but either way it ta
aleferri opened a new pull request, #44:
URL: https://github.com/apache/tomcat-maven-plugin/pull/44
- Merged every PR i could
- Fixed all conflicts
- Updated deps to the last possibile version
- Build successfully with Java 8
I need both Tomcat 7 and 9 because of some in
mturk opened a new pull request, #10:
URL: https://github.com/apache/tomcat-connectors/pull/10
Wow, didn't touch that in years.
Anyhow, the changes allow building with Hybrid CRT model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rmaucher commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2442698504
Ok, I give up on that one, since it's already done for copyResource. I gave
you credit in the commit message.
--
This is an automated message from the Apache Git Service.
To respond to th
Chenjp commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2436588929
> If the `ExpiresFilter` is setting cache control headers when it shouldn't
then that Filter should be fixed. The same goes for any other component setting
cache headers incorrectly.
mturk commented on code in PR #10:
URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815580677
##
native/apache-2.0/Makefile.vc:
##
@@ -16,38 +16,25 @@
PROJECT = mod_jk
# Tools
CC = cl.exe
-LINK = link.exe
+LN = link.exe
RC = rc.exe
-MT = mt.exe
!IF !D
ChristopherSchultz commented on code in PR #10:
URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815478755
##
native/apache-2.0/Makefile.vc:
##
@@ -16,38 +16,25 @@
PROJECT = mod_jk
# Tools
CC = cl.exe
-LINK = link.exe
+LN = link.exe
RC = rc.exe
-MT = mt.
ChristopherSchultz commented on code in PR #10:
URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815482357
##
native/apache-2.0/Makefile.vc:
##
@@ -16,38 +16,25 @@
PROJECT = mod_jk
# Tools
CC = cl.exe
-LINK = link.exe
+LN = link.exe
RC = rc.exe
-MT = mt.
ChristopherSchultz commented on code in PR #10:
URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815478755
##
native/apache-2.0/Makefile.vc:
##
@@ -16,38 +16,25 @@
PROJECT = mod_jk
# Tools
CC = cl.exe
-LINK = link.exe
+LN = link.exe
RC = rc.exe
-MT = mt.
markt-asf commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434998619
If the `ExpiresFilter` is setting cache control headers when it should then
that Filter should be fixed. The same goes for any other component setting
cache headers incorrectly.
--
This
isapir commented on code in PR #767:
URL: https://github.com/apache/tomcat/pull/767#discussion_r1828114910
##
java/org/apache/catalina/util/RateLimiter.java:
##
@@ -65,4 +94,33 @@ public interface RateLimiter {
* @param filterConfig The FilterConfig used to configure the a
rmaucher merged PR #773:
URL: https://github.com/apache/tomcat/pull/773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or
markt-asf commented on code in PR #767:
URL: https://github.com/apache/tomcat/pull/767#discussion_r1828019091
##
java/org/apache/catalina/filters/RateLimitFilter.java:
##
@@ -63,6 +67,10 @@
* information that it has, e.g. allow more requests to certain users based on
roles, e
isapir commented on code in PR #767:
URL: https://github.com/apache/tomcat/pull/767#discussion_r1828122723
##
java/org/apache/catalina/filters/RateLimitFilter.java:
##
@@ -63,6 +67,10 @@
* information that it has, e.g. allow more requests to certain users based on
roles, etc.
markt-asf commented on PR #765:
URL: https://github.com/apache/tomcat/pull/765#issuecomment-2457602402
The test case isn't (directly) related to the fix in the PR but it does
improve code coverage so I'll commit that separately.
--
This is an automated message from the Apache Git Service.
Chenjp opened a new pull request, #773:
URL: https://github.com/apache/tomcat/pull/773
Modify unused webdav status codes:
* 418 is sc of a 1 April Rfc. (418 I'm a teapot).
* 422 (Unprocessable Content) Comply with
[Rfc9110](https://httpwg.org/specs/rfc9110.html#changes.from.rfc.7231)
Chenjp commented on PR #772:
URL: https://github.com/apache/tomcat/pull/772#issuecomment-2453765273
Commit ```c65d66d``` has prevented most of unexpected cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
markt-asf merged PR #774:
URL: https://github.com/apache/tomcat/pull/774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #774:
URL: https://github.com/apache/tomcat/pull/774#issuecomment-2455972048
Tx for the PR. Back-ported to 11.0.x, 10.1.x and 9.0.x as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jonatasemidio opened a new pull request, #774:
URL: https://github.com/apache/tomcat/pull/774
Fixing a typo in a class comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
jengebr commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448015687
Thanks, I get your points about caching scope and cleanup.
@ChristopherSchultz what prevents changes to `javax.el.Util`?
--
This is an automated message from the Apache Git Service.
markt-asf commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448093530
I think the changes will have to go into `Util`. Something like a map of
caches, keyed by class loader with appropriate use of weak references to avoid
class loader leaks.
--
This is an
jengebr commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448111787
This complexity led me to try a fallback plan, which can be faster: if the
method has zero parameters, retrieve the Method by name. This works because
there is no confusion about parameter
markt-asf commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2447798338
Any caching approach needs to consider the case of two classes in different
web applications with the same name but different structures. Essentially,
caching needs to be per class loader.
ChristopherSchultz commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2447969657
> I'd also like to see the key remove from the cache when the value expires.
+1
So I think your technique @jengebr is good, but the cache just needs to be
pulled-up i
markt-asf commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448199694
Actually, it does belong to us. It isn't part of the public API. We are free
to change it how we wish. If you compare our version to the equivalent code in
the EL API JAR from Jakarta EE t
ChristopherSchultz commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448176904
> @ChristopherSchultz what prevents changes to `javax.el.Util`?
That class doesn't "belong" to us. Depending upon how it changes, we might
fail the TCK. It's just better to
markt-asf commented on PR #772:
URL: https://github.com/apache/tomcat/pull/772#issuecomment-2452244382
This doesn't need to be this complicated.
RFC 9110 does not define the list of cacheable status codes, it defines a
list of "heuristically cacheable" status codes. Also, the filter a
markt-asf closed pull request #772: ExpiresFilter enhance should-not-cacheable
verification
URL: https://github.com/apache/tomcat/pull/772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
markt-asf commented on PR #772:
URL: https://github.com/apache/tomcat/pull/772#issuecomment-2452249501
Having looked at the spec again, we don;t need to be that strict about
Cache-Control headers set by the application.
--
This is an automated message from the Apache Git Service.
To respo
jengebr commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2448361853
Changes are committed as discussed, ready for re-review. Specifically:
1. Cache is removed, fast-path is added for zero-arg cases
1. Unit tests are added for:
- Zero-args method look
Chenjp commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2441143076
> +1 for the third one (the request will not work so it's better to send the
specified 400 code immediately), I just fixed it. For the other two, about
depth, I left it as is on purpose. Ther
Chenjp opened a new pull request, #772:
URL: https://github.com/apache/tomcat/pull/772
- Skip response with Cache-Control: no-store.
- Introduce "ExpiresIncludedMethods", "ExpiresIncludedResponseStatusCodes"
initial parameters to improve configurability.
- Testcase added.
--
Thi
rw7 commented on PR #57:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/57#issuecomment-2437224817
Would be nice if there was any feedback on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ChristopherSchultz commented on PR #57:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/57#issuecomment-2438031225
This looks okay to me. I'll give it a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Chenjp commented on PR #767:
URL: https://github.com/apache/tomcat/pull/767#issuecomment-2440574350
@markt-asf @rmaucher wondering if this PR is appropriate? tks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
markt-asf closed pull request #776: fix message parameters -
expiresFilter.skippedStatusCode
URL: https://github.com/apache/tomcat/pull/776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
markt-asf commented on PR #776:
URL: https://github.com/apache/tomcat/pull/776#issuecomment-2467491170
Thanks for the PR. Translations are handled a little differently to the rest
of the code. We use POEditor. See
https://cwiki.apache.org/confluence/display/TOMCAT/Managing+translations for
Chenjp opened a new pull request, #776:
URL: https://github.com/apache/tomcat/pull/776
expiresFilter.skippedStatusCode: fix message parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Chenjp opened a new pull request, #777:
URL: https://github.com/apache/tomcat/pull/777
Currently ExpiresFilter pickup the first-added cache-control header as the
effective field, cause follow-up directives (like no-store or max-age) to be
ignored.
rfc9111 - 4.2.1 - If directives conf
Chenjp commented on PR #776:
URL: https://github.com/apache/tomcat/pull/776#issuecomment-2469980519
👍quick response.
> Thanks for the PR. Translations are handled a little differently to the
rest of the code. We use POEditor. See
https://cwiki.apache.org/confluence/display/TOMCAT/Man
markt-asf commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2450753071
I'm planning on applying this manually to main and then back-porting. So far
I've made the following changes:
- refactored the inner test classes to align with the rest of the package
jengebr commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2450799286
Thank you so much! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
markt-asf commented on PR #770:
URL: https://github.com/apache/tomcat/pull/770#issuecomment-2450776553
Those were the only changes required. Fix applied to main, 11.0.1, 10.1.x
and 9.0.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
markt-asf closed pull request #770: Reducing memory usage while evaluating
reflective EL expressions
URL: https://github.com/apache/tomcat/pull/770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Chenjp commented on PR #755:
URL: https://github.com/apache/tomcat/pull/755#issuecomment-2367044717
> In theory this is an upstream issue (commons-modeler), however it is no
longer maintained.
got it.
--
This is an automated message from the Apache Git Service.
To respond to the me
PaulLodge opened a new pull request, #756:
URL: https://github.com/apache/tomcat/pull/756
This Unit test makes sure that the expires and date headers are consistent
and both use GMT, as per the bug report
https://bz.apache.org/bugzilla/show_bug.cgi?id=62476
--
This is an automated messag
dsoumis commented on PR #753:
URL: https://github.com/apache/tomcat/pull/753#issuecomment-2379031764
I have refactored the valve and the request as discussed here.
There were 2 failing tests after the change to Request's constructor which
introduced method accessing of Connector.
The
dsoumis commented on code in PR #753:
URL: https://github.com/apache/tomcat/pull/753#discussion_r1778454482
##
test/org/apache/catalina/valves/TestSSLValve.java:
##
@@ -314,12 +352,14 @@ public void testSslCipherUserKeySizeHeaderPresent()
throws Exception {
@Test(expecte
rmaucher merged PR #756:
URL: https://github.com/apache/tomcat/pull/756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or
markt-asf commented on PR #751:
URL: https://github.com/apache/tomcat/pull/751#issuecomment-2363434819
OK. I'll merge this then fix the missing ALv2 header and any other issues
before porting it to the other versions.
--
This is an automated message from the Apache Git Service.
To respond
markt-asf merged PR #751:
URL: https://github.com/apache/tomcat/pull/751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #755:
URL: https://github.com/apache/tomcat/pull/755#issuecomment-2363483158
Why would MBean info change at runtime? The MBeans pretty much all represent
Tomcat internals and they don't change structure at runtime. I'm not seeing the
use case for this.
--
This i
rmaucher commented on PR #755:
URL: https://github.com/apache/tomcat/pull/755#issuecomment-2363500940
In theory this is an upstream issue (commons-modeler), however it is no
longer maintained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
Chenjp commented on PR #750:
URL: https://github.com/apache/tomcat/pull/750#issuecomment-2360303343
@markt-asf Would you please review detail of
```Http2Protocol#setHttp11Protocol```? reconfigure stack limitation occurs.
--
This is an automated message from the Apache Git Service.
To resp
Chenjp opened a new pull request, #755:
URL: https://github.com/apache/tomcat/pull/755
1. ensure evict cache for each modification like returnType, name, desc,
addAttribute etc.
2. code refactoring.
3. testcase added.
--
This is an automated message from the Apache Git Service.
To
markt-asf commented on PR #750:
URL: https://github.com/apache/tomcat/pull/750#issuecomment-2360404011
`maxConnections` is rarely changed at runtime. When it is changed, it is
more likely to be increased than decreased. In the extremely rare cases it is
decreased, the stack will remain larg
nwzg opened a new pull request, #754:
URL: https://github.com/apache/tomcat/pull/754
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
n828cl closed pull request #754: 9.xwang
URL: https://github.com/apache/tomcat/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
n828cl commented on PR #754:
URL: https://github.com/apache/tomcat/pull/754#issuecomment-2357457555
Surely, you can't be serious. 3,308 files changed? Entirely inappropriate
for a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmaucher commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434585666
All of the WebDAV methods are "must not cache" actually (except PROPFIND,
but IMO it's a bad idea to cache it), and it is 100% obvious why. If the proxy
feels like it doesn't have to send t
rmaucher commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434710548
OTOH, +1 if you want to rewrite (they are too verbose right now) and expand
the WebDAV tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
Chenjp commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434716856
> This change is unnecessary. As per RFC 9111, methods other than GET are
only cached if the method definition allows it. RFC 4918 is explicit that these
methods are not cacheable.
Cur
markt-asf commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2434618560
This change is unnecessary. As per RFC 9111, methods other than GET are only
cached if the method definition allows it. RFC 4918 is explicit that these
methods are not cacheable.
--
Thi
markt-asf closed pull request #771: webdav lock and unlock: ensure response
must not be cached
URL: https://github.com/apache/tomcat/pull/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
rmaucher commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2437336012
+1 for the third one (the request will not work so it's better to send the
specified 400 code immediately), I just fixed it.
For the other two, about depth, I left it as is on purpose. Th
Chenjp commented on PR #771:
URL: https://github.com/apache/tomcat/pull/771#issuecomment-2437231617
@markt-asf @rmaucher please advise following issue need fix or not? -- If
necessary, I will submit PR.
```java
java.lang.AssertionError: 9.10.2. Refreshing Locks - Values other than 0 or
MartinLei closed pull request #722: Tomcat-jdbc causes problem with graalvm
URL: https://github.com/apache/tomcat/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
markt-asf merged PR #764:
URL: https://github.com/apache/tomcat/pull/764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf closed pull request #765: Bug/bug 55470 class not found exception
during startup patch
URL: https://github.com/apache/tomcat/pull/765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
markt-asf commented on PR #765:
URL: https://github.com/apache/tomcat/pull/765#issuecomment-2459193788
The remaining changes are essentially a copy of Ralf Hauser's patch on BZ
55470. I'll follow up on that on the BZ issue.
--
This is an automated message from the Apache Git Service.
To r
Chenjp opened a new pull request, #775:
URL: https://github.com/apache/tomcat/pull/775
smaller PR from #767 .
comply draft-ietf-httpapi-ratelimit-headers. enhance exposeHeaders
parameter, true to output rate limit header fields.
update testcase.
--
This is an automated message f
markt-asf commented on PR #188:
URL: https://github.com/apache/tomcat/pull/188#issuecomment-2508119669
Agree this doesn't belong in the Tomcat source tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
markt-asf closed pull request #188: Introduce Tomcat Source-to-Image (S2I)
URL: https://github.com/apache/tomcat/pull/188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Chenjp opened a new pull request, #790:
URL: https://github.com/apache/tomcat/pull/790
- Bug: incorrect partial content response to HEAD request with-Range-header
***Tomcat*** - 206:
```
C:\Users\chenjp>curl http://localhost:55263/index.html -i -H "Range:
bytes=0-10" -I
Chenjp opened a new pull request, #791:
URL: https://github.com/apache/tomcat/pull/791
Request that ranges are not strictly in ascending order, indicates either a
broken client or a deliberate denial-of-service attack.
--
This is an automated message from the Apache Git Service.
To respon
Chenjp commented on PR #791:
URL: https://github.com/apache/tomcat/pull/791#issuecomment-2508272217
simpler and elegant logic to detect both overlap and ASC order in same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Chenjp commented on PR #764:
URL: https://github.com/apache/tomcat/pull/764#issuecomment-2489895080
@markt-asf @ChristopherSchultz Per HttpServletResponse#sendEarlyHints(),
where can I find "Servlet 6.2" spec?
```java
/**
* Sends a 103 response to the client using the
Chenjp commented on PR #778:
URL: https://github.com/apache/tomcat/pull/778#issuecomment-2489897959
> Ok, that's correct, the end is also inclusive.
@rmaucher any further comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
markt-asf commented on code in PR #784:
URL: https://github.com/apache/tomcat/pull/784#discussion_r1853716196
##
java/org/apache/coyote/http2/Stream.java:
##
@@ -604,10 +611,23 @@ final void writeAck() throws IOException {
final void writeEarlyHints() throws IOException {
markt-asf commented on code in PR #785:
URL: https://github.com/apache/tomcat/pull/785#discussion_r1853737908
##
java/org/apache/coyote/http11/Http11Processor.java:
##
@@ -1250,8 +1255,19 @@ protected final void ack(ContinueResponseTiming
continueResponseTiming) {
@Overr
Chenjp commented on PR #783:
URL: https://github.com/apache/tomcat/pull/783#issuecomment-2493271822
Ok, new PR will enhance this feature instead of revoke it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Chenjp opened a new pull request, #785:
URL: https://github.com/apache/tomcat/pull/785
twin PR of #784 .
1. automatically flush when earlyHints called, to enable the possibility of
server-think-time between the Early Hints headers and the final response.
Speeding up page loads is the ma
Chenjp commented on code in PR #784:
URL: https://github.com/apache/tomcat/pull/784#discussion_r1853796863
##
java/org/apache/coyote/http2/Stream.java:
##
@@ -604,10 +611,23 @@ final void writeAck() throws IOException {
final void writeEarlyHints() throws IOException {
Chenjp commented on code in PR #784:
URL: https://github.com/apache/tomcat/pull/784#discussion_r1853796379
##
java/org/apache/coyote/http2/Stream.java:
##
@@ -604,10 +611,23 @@ final void writeAck() throws IOException {
final void writeEarlyHints() throws IOException {
Chenjp commented on code in PR #784:
URL: https://github.com/apache/tomcat/pull/784#discussion_r1853796379
##
java/org/apache/coyote/http2/Stream.java:
##
@@ -604,10 +611,23 @@ final void writeAck() throws IOException {
final void writeEarlyHints() throws IOException {
Chenjp commented on code in PR #784:
URL: https://github.com/apache/tomcat/pull/784#discussion_r1853814408
##
java/org/apache/coyote/http2/Stream.java:
##
@@ -604,10 +611,23 @@ final void writeAck() throws IOException {
final void writeEarlyHints() throws IOException {
markt-asf commented on code in PR #784:
URL: https://github.com/apache/tomcat/pull/784#discussion_r1853813923
##
java/org/apache/coyote/http2/Stream.java:
##
@@ -604,10 +611,23 @@ final void writeAck() throws IOException {
final void writeEarlyHints() throws IOException {
1301 - 1400 of 2012 matches
Mail list logo
