Chenjp commented on PR #760: URL: https://github.com/apache/tomcat/pull/760#issuecomment-2403720730
> The performance results look odd to me. I'd expect throughput to be significantly higher in all cases. I wonder if the request processing time is dominating the results rather than any overhead in Tomcat. In Performance Test, request client threads have sleep ops. Average cost of each rateLimiter is about 3500ns. The difference in time cost between Fast and Exact rate limiters is less than ***0.001 milliseconds***. @markt-asf Shall we make ExactRateLimiter as a default implementation? According to the performance test results, for FastRateLimiter, the configuration of 120/4s is actually converted to 123/4s. Then the number of requests passing through each IP is more than that of ExactRateLimiter, and the number of blocked requests is less than that of ExactRateLimiter, and the throughput will decrease. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
