dsoumis commented on PR #753: URL: https://github.com/apache/tomcat/pull/753#issuecomment-2379031764
I have refactored the valve and the request as discussed here. There were 2 failing tests after the change to Request's constructor which introduced method accessing of Connector. The change at TestPersistentManager.java is just a reordering of when the mock Connector object is activated. Regarding TestSSLValve.java, I introduced a singleton implementation of Mockrequest giving more flexibility for Connector values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
