mturk commented on code in PR #10: URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815580677
########## native/apache-2.0/Makefile.vc: ########## @@ -16,38 +16,25 @@ PROJECT = mod_jk # Tools CC = cl.exe -LINK = link.exe +LN = link.exe RC = rc.exe -MT = mt.exe !IF !DEFINED(APACHE2_HOME) || "$(APACHE2_HOME)" == "" !ERROR Cannot find APACHE2_HOME. Use nmake -f Makefile.vc APACHE2_HOME=dir !ENDIF !IF !DEFINED(APACHE2_LDIR) || "$(APACHE2_LDIR)" == "" -APACHE2_LDIR=$(APACHE2_HOME)\lib +APACHE2_LDIR = lib Review Comment: My intention was to simplify the things by not requiring the full path for lib and include dirs, since APACHE2_HOME should point to the directory containing both lib and include/httpd and include/apr-1. The APACHE2_IDIR makes no sence, since it should always be $(APACHE2_HOME)\include. Same for APACHE2_LDIR that is by default $(APACHE2_HOME)\lib. However one can set APACHE2_LDIR=lib64, which would evaluate to $(APACHE2_HOME)\lib64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
