ChristopherSchultz commented on code in PR #10: URL: https://github.com/apache/tomcat-connectors/pull/10#discussion_r1815478755
########## native/apache-2.0/Makefile.vc: ########## @@ -16,38 +16,25 @@ PROJECT = mod_jk # Tools CC = cl.exe -LINK = link.exe +LN = link.exe RC = rc.exe -MT = mt.exe !IF !DEFINED(APACHE2_HOME) || "$(APACHE2_HOME)" == "" !ERROR Cannot find APACHE2_HOME. Use nmake -f Makefile.vc APACHE2_HOME=dir !ENDIF !IF !DEFINED(APACHE2_LDIR) || "$(APACHE2_LDIR)" == "" -APACHE2_LDIR=$(APACHE2_HOME)\lib +APACHE2_LDIR = lib Review Comment: This looks like it should probably continue to have the `$(APACHE2_HOME)/` prefix. Why is this being removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
