markt-asf commented on PR #772: URL: https://github.com/apache/tomcat/pull/772#issuecomment-2452244382
This doesn't need to be this complicated. RFC 9110 does not define the list of cacheable status codes, it defines a list of "heuristically cacheable" status codes. Also, the filter already has a mechanism to exclude some status codes. For the purposes of this filter it is sufficient to only add the cache headers for GET and HEAD. I don't see a need to make that list configurable. If the application has set any sort of Cache-Control header, this filter shouldn't be adding to or changing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
