Upgrade Tomcat 6 from ECJ 3.7 to ECJ 3.7.1?

2012-03-12 Thread Nick Williams
our customers they can still run our application on Tomcat 6. Furthermore, are there any compelling reasons *not* to upgrade Tomcat 6 to ECJ 3.7.1? Thanks, Nick Williams

RE: Upgrade Tomcat 6 from ECJ 3.7 to ECJ 3.7.1?

2012-03-15 Thread Nick Williams
JCT 3.7.0” like below. Not sure where the “JTC” came from… Nick *From:* Nick Williams [mailto:nicholas.willi...@puresafety.com] *Sent:* Monday, March 12, 2012 3:12 PM *To:* 'dev@tomcat.apache.org' *Subject:* Upgrade Tomcat 6 from ECJ 3.7 to ECJ 3.7.1? We are researching upgrading ou

RE: Upgrade Tomcat 6 from ECJ 3.7 to ECJ 3.7.1?

2012-03-15 Thread Nick Williams
7;t. Nick -Original Message- From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] Sent: Thursday, March 15, 2012 12:41 PM To: Tomcat Developers List Subject: Re: Upgrade Tomcat 6 from ECJ 3.7 to ECJ 3.7.1? 2012/3/15 Nick Williams : > A correction to my previous email: > > > >&g

RE: Upgrade Tomcat 6 from ECJ 3.7 to ECJ 3.7.1?

2012-03-15 Thread Nick Williams
2012/3/15 Nick Williams : > Good to know. What about the next version of Tomcat 6? Will it also > get > 3.7.2 (or at least 3.7.1)? Or will it stay on 3.7.0 for the > foreseeable future? That's my big concern. As long as Tomcat 6 has > 3.7.1 or better, it should be able to com

RE: Upgrade Tomcat 6 from ECJ 3.7 to ECJ 3.7.1?

2012-03-15 Thread Nick Williams
2012/3/15 Nick Williams : > 2012/3/15 Nick Williams : >> Good to know. What about the next version of Tomcat 6? Will it also >> get >> 3.7.2 (or at least 3.7.1)? Or will it stay on 3.7.0 for the >> foreseeable future? That's my big concern. As long as Tomcat 6 has

[debug] ( javajni.c:195 ) Invalid RuntimeLib should be a warning or error?

2012-03-20 Thread Nick Williams
So, I’ll file a bug about this, but I wanted to get a general feel from the list first. This happens in both Tomcat 6 and 7 (haven’t looked at 5.5), but I’ve only included the Tomcat 7 log info here for succinctness. When running Tomcat as a service under Windows, if you mess up the Java Virtual

RE: [debug] ( javajni.c:195 ) Invalid RuntimeLib should be a warning or error?

2012-03-20 Thread Nick Williams
-Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Tuesday, March 20, 2012 4:59 PM To: Tomcat Developers List Subject: Re: [debug] ( javajni.c:195 ) Invalid RuntimeLib should be a warning or error? On 20/03/2012 21:54, Nick Williams wrote: > Thoughts? That i

Improving Ant Task for JSP Compilation

2012-03-31 Thread Nick Williams
re background information about me on request, but I didn't want to introduce myself with a novel. :-) Nick Williams

RE: Improving Ant Task for JSP Compilation

2012-04-04 Thread Nick Williams
-Original Message- From: Christopher Schultz [mailto:ch...@christopherschultz.net] Sent: Monday, April 02, 2012 4:24 PM To: Tomcat Developers List Subject: Re: Improving Ant Task for JSP Compilation Nick, On 3/31/12 4:34 PM, Nick Williams wrote: > This morning I filed issues 53011

Catching up

2014-12-02 Thread Nick Williams
Guys, For a myriad of personal, professional, and health reasons, I've been out of pocket for many months. I'm finally starting to catch up today on 9200 Tomcat developer and user list messages. It will take me many days. I just wanted to let y'all know that I'm still alive, and head off any "w

Re: [PROPOSAL] Drop comet support in Tomcat 9 onwards

2014-12-02 Thread Nick Williams
On Jun 19, 2014, at 10:45 AM, Rémy Maucherat wrote: > 2014-06-18 23:40 GMT+02:00 Mark Thomas : > >> I have been thinking about connector refactoring for Tomcat 9. Currently >> BIO is planned to be dropped due to the number of features in the >> servlet spec that rely on non-blocking IO. >> >> I

Re: Catching up

2014-12-02 Thread Nick Williams
Huh. Amazing how fast that went. I'm caught up on everything since May 7 (last time I checked my email in this folder). Good job, everyone involved, on releasing 8.0.x stable, beginning 9.0.x, and addressing many bugs. Kudos! Nick On Dec 2, 2014, at 1:20 PM, Nick Williams wrote: &

Re: svn commit: r1539036 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappLoader.java test/org/apache/catalina/loader/TestVirtualWebappLoader.java test/org/apache/catalina/loader/TestWebappCl

2013-11-05 Thread Nick Williams
On Nov 5, 2013, at 9:41 AM, ma...@apache.org wrote: > Author: markt > Date: Tue Nov 5 15:41:53 2013 > New Revision: 1539036 > > URL: http://svn.apache.org/r1539036 > Log: > Fix remainder of failing tests and a related TODO spotted in the tests as > well. > > > > Modified: > tomcat/trunk/te

Re: svn commit: r1542836 - /tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java

2013-11-17 Thread Nick Williams
On Nov 17, 2013, at 4:10 PM, Jeremy Boynes wrote: > On Nov 17, 2013, at 1:42 PM, ma...@apache.org wrote: > >> Author: markt >> Date: Sun Nov 17 21:42:26 2013 >> New Revision: 1542836 >> >> URL: http://svn.apache.org/r1542836 >> Log: >> Revert part of r1542565 which added rather than removed an

Re: [VOTE] Release Apache Tomcat 8.0.1

2014-02-01 Thread Nick Williams
Looks good! On Jan 29, 2014, at 5:43 PM, Mark Thomas wrote: > > > [X ] Beta - go ahead and release as 8.0.1 (beta) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.

Re: support for salted passwords

2014-02-01 Thread Nick Williams
On Feb 2, 2014, at 1:23 AM, Gabriel E. Sánchez Martínez wrote: > Hi developers, > > I am very new to Tomcat but am already getting my feet wet with a web > application. A requirement for this application is form-based password > authentication, and I would like to store passwords in a databas

Re: [VOTE] Release Apache Tomcat 8.0.3

2014-02-10 Thread Nick Williams
On Feb 7, 2014, at 12:16 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.3 release is now available for voting. > > > > The proposed 8.0.3 release is: > [ ] Broken - do not release > [ ] Alpha - go ahead and release as 8.0.3 (alpha) > [X] Beta - go ahead and release as 8.0.3 (beta)

OT: New Email Address

2013-02-13 Thread Nick Williams
FYI, since some of you may be used to seeing emails from me come from nicholas dot williams at ul dot com: I have used my work email addresses for the Tomcat list for some time, but I have switched now to my personal email address for a variety of reasons: 1) I'm tired of the "privileged or con

Re: svn commit: r1445517 - in /tomcat/trunk: java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/s

2013-02-13 Thread Nick Williams
_bug.cgi?id=54552 >> Servlet 3.1 >> Implement HttpSessionIdListener and HttpServletRequest#changeSessionId() >> Patch provided by Nick Williams. >> > I think that this code itself is not a problem at all. (I think prety good.) Thanks! I was a bit nervous about my first code contribu

Re: svn commit: r1446072 - in /tomcat/trunk/java/org/apache/catalina: Manager.java Session.java ha/session/DeltaManager.java session/ManagerBase.java session/StandardSession.java

2013-02-14 Thread Nick Williams
On Feb 14, 2013, at 2:57 AM, kfuj...@apache.org wrote: > Author: kfujino > Date: Thu Feb 14 08:57:43 2013 > New Revision: 1446072 > > URL: http://svn.apache.org/r1446072 > Log: > Remove duplicate code on ManagerBase and DeltaManager. > Introduce following interfaces. > Manager#changeSessionId(S

Jasper: "use of final," "reduce visibility"

2013-02-16 Thread Nick Williams
Mark, I've noticed in the past few days you've committed several change sets with comments like "use of final" and "reduce visibility" (mostly the latter). I'm trying to understand the Tomcat source code better so that I can potentially contribute more in the future, and I'm wondering what the

Re: Jasper: "use of final," "reduce visibility"

2013-02-16 Thread Nick Williams
On Feb 16, 2013, at 10:51 AM, Mark Thomas wrote: > On 16/02/2013 16:42, Nick Williams wrote: >> Mark, >> >> I've noticed in the past few days you've committed several change >> sets with comments like "use of final" and "reduce visibility&q

Re: JarScanning

2013-02-21 Thread Nick Williams
On Feb 21, 2013, at 10:42 AM, Romain Manni-Bucau wrote: > Hi, > > the best IMO would be to have a WEB-INF/tomcat.properties with the ability > to configure the scanner + its properties (thanks a prefix) from the webapp > itself > > PS: META-INF/context.xml would work too but i'm not a fan of xm

OT: No web-jsptaglibrary_2_2.xsd?

2013-03-01 Thread Nick Williams
General question for all the Tomcat developers out there, but I'm betting Mark has the best shot at answering: Perusing the Tomcat sources I noticed that there are JSP tag library XSD files web-jsptaglibrary_1_1.xsd, web-jsptaglibrary_1_2.xsd, web-jsptaglibrary_2_0.xsd and web-jsptaglibrary_2_1

Re: OT: No web-jsptaglibrary_2_2.xsd?

2013-03-05 Thread Nick Williams
On Mar 2, 2013, at 12:48 PM, Christopher Schultz wrote: > Nick, Sorry for the delayed reply. I've been sick and was way behind on emails. > > On 3/1/13 9:29 PM, Nick Williams wrote: >> Perusing the Tomcat sources I noticed that there are JSP tag library >> XSD files

Re: WebSocket progress report

2013-03-09 Thread Nick Williams
On Mar 7, 2013, at 5:33 PM, Mark Thomas wrote: > The current status of the WebSocket implementation is largely complete. > > The remaining TODOs are (in roughly the order I intend to tackle them): > > 1. Implement decoding > 2. Figure out why there are failures in Autobahn with WSS and NIO and

Question on SERVLET_SPEC-57 (getSubmittedFileName)

2013-03-09 Thread Nick Williams
I'm implementing the Part#getSubmittedFileName method introduced in SERVLET_SPEC-57 [1]. o.a.c.core.ApplicationPart already has a getFilename method that accomplishes this that is not part of the interface but IS public. This method is used only in o.a.c.connector.Request (once), but that's eas

Re: Question on SERVLET_SPEC-57 (getSubmittedFileName)

2013-03-09 Thread Nick Williams
On Mar 9, 2013, at 3:15 PM, Nick Williams wrote: > I'm implementing the Part#getSubmittedFileName method introduced in > SERVLET_SPEC-57 [1]. > > o.a.c.core.ApplicationPart already has a getFilename method that accomplishes > this that is not part of the interface but IS

Re: Question on SERVLET_SPEC-57 (getSubmittedFileName)

2013-03-09 Thread Nick Williams
e and wrapped it around getSubmittedFileName and submitted patch via bug #54658. Let me know if I should just remove it and re-submit patch. Nick > > Nick Williams wrote: > >> I'm implementing the Part#getSubmittedFileName method introduced in >> SERVLET_SPEC-57 [1]

Servlet 3.1 Request Upgrade

2013-03-09 Thread Nick Williams
Mark, I noticed the HttpServletRequest upgrade method still had the signature void upgrade(HttpUpgradeHandler) when it should be T upgrade(Class) per the latest spec. What's your status on getting this changed? I started to try to clean this up a bit (I can email you a partial patch that has

Re: Question on SERVLET_SPEC-57 (getSubmittedFileName)

2013-03-09 Thread Nick Williams
On Mar 9, 2013, at 4:57 PM, Mark Thomas wrote: > Nick Williams wrote: > >> >> On Mar 9, 2013, at 3:49 PM, Mark Thomas wrote: >> >>> Renaming the method is fine. >>> >>> We don't change the API for the sake of it but if there is a need

Re: Autobahn test results for Tomcat 8's web socket implementation

2013-03-13 Thread Nick Williams
On Mar 13, 2013, at 6:46 PM, Mark Thomas wrote: > FYI > > http://people.apache.org/~markt/dev/autobahn-tomcat-8/ > > I'll post updates periodically. > > Mark Updates? Looks like you're done. :-) - To unsubscribe, e-mail: dev

Re: [Bug 54721] New: RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders

2013-03-18 Thread Nick Williams
On Mar 18, 2013, at 5:01 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=54721 > >Bug ID: 54721 > Summary: RemoteEndpoint blocks indefinitely if sendObject >called with BinaryStream of TextStream encoders > P

WebSockets: Automatic closure on HttpSession invalidation?

2013-03-18 Thread Nick Williams
Mark, I was reading on the expert mailing list the other day a discussion about containers automatically closing WebSocket sessions when the corresponding HttpSession instance is invalidate. I have a strange race condition going on that I think could be caused by that. Is Tomcat automatically c

Changelog has training whitespace

2013-03-19 Thread Nick Williams
validate: [mkdir] Created dir: C:\Tomcat-Build\Source\output\res\checkstyle [checkstyle] Running Checkstyle 5.6 on 2516 files [checkstyle] C:\Tomcat-Build\Source\webapps\docs\changelog.xml:128: Line matches the illegal pattern '\s+$'. BUILD FAILED C:\Tomcat-Build\Source\build.xml:485: Got 1 e

AJP + WebSockets

2013-03-19 Thread Nick Williams
I was working on the recent change in the Servlet 3.1 spec for HttpServletRequest#upgrade(...) and noticed that the AbstractAjpProcessor doesn't support HTTP Upgrade (and, by extension, doesn't support WebSockets). Only the AbstractHttp11Processor does. Is there a plan for AJP to support Upgrad

Re: Servlet 3.1 Request Upgrade

2013-03-19 Thread Nick Williams
On Mar 11, 2013, at 3:37 PM, Mark Thomas wrote: > On 09/03/2013 23:03, Nick Williams wrote: >> Mark, >> >> I noticed the HttpServletRequest upgrade method still had the >> signature void upgrade(HttpUpgradeHandler) when it should be > extends HttpUpgradeHandler>

Re: Time for 7.0.39

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 3:55 PM, Mark Thomas wrote: > I plan to get the most recent FileUpload changes (if any), run the unit > tests, run the TCKs and then tag 7.0.39 so that should happen some time > early tomorrow if all goes well. > > Mark In 54734 I propose a patch that needs to also be back-p

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 3:53 PM, Mark Thomas wrote: > On 20/03/2013 20:50, Remy Maucherat wrote: >> On Wed, 2013-03-20 at 20:46 +, ma...@apache.org wrote: >>> Author: markt >>> Date: Wed Mar 20 20:46:04 2013 >>> New Revision: 1459043 >>> >>> URL: http://svn.apache.org/r1459043 >>> Log: >>> Add n

WebServlets and HttpSessions (again) ... How to update last accessed time?

2013-03-20 Thread Nick Williams
Reading through the expert mailing list for the WebSocket spec, I gather that the experts did not feel it appropriate to update the last access time for HttpSession objects when messages are received. I DO agree with this; there's no way to know what the user really wants here, and it could be a

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 5:48 PM, Mark Thomas wrote: > On 20/03/2013 21:35, Nick Williams wrote: >> >> On Mar 20, 2013, at 3:53 PM, Mark Thomas wrote: >> >>> On 20/03/2013 20:50, Remy Maucherat wrote: >>>> On Wed, 2013-03-20 at 20:46 +, ma...@apache

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 6:45 PM, Mark Thomas wrote: > On 20/03/2013 22:50, Nick Williams wrote: >> >> On Mar 20, 2013, at 5:48 PM, Mark Thomas wrote: >> >>> On 20/03/2013 21:35, Nick Williams wrote: > > > >>>> Also agreed. However, r1459028

Re: Use of JAXB api to process Base64 in Tomcat 7 and 8

2013-03-20 Thread Nick Williams
On Mar 21, 2013, at 12:35 AM, Konstantin Kolinko wrote: > Hi! > > Recent Mark's commits in Tomcat 7, 8 replaced custom > implementations(*) of base64 > with use of the following class from JAXB: > > javax.xml.bind.DatatypeConverter > > This affects base64 processing in our own classes and in o

Re: OT: Will web containers be required to implement WebSockets

2013-03-21 Thread Nick Williams
On Mar 21, 2013, at 9:54 AM, Christopher Schultz wrote: > Nick, > > On 3/21/13 10:17 AM, Nicholas Williams wrote: >> I know that WebSockets will be a part of the Java EE 7 specification >> for full application servers. But will web containers also be required >> to implement this? Or will it be

Re: [Bug 54721] New: RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders

2013-03-21 Thread Nick Williams
On Mar 21, 2013, at 9:07 AM, Christopher Schultz wrote: > Nick, > > On 3/18/13 6:03 PM, Nick Williams wrote: >> >> I've been busy fleshing out all kinds of problems. :-) > > Careful: you might inadvertently become the babysitter of Tomcat's > Websocke

Re: WebServlets and HttpSessions (again) ... How to update last accessed time?

2013-03-21 Thread Nick Williams
On Mar 20, 2013, at 5:24 PM, Nick Williams wrote: > Reading through the expert mailing list for the WebSocket spec, I gather that > the experts did not feel it appropriate to update the last access time for > HttpSession objects when messages are received. I DO agree with this; ther

Re: svn commit: r1459389 - /tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java

2013-03-21 Thread Nick Williams
On Mar 21, 2013, at 11:37 AM, ma...@apache.org wrote: > Author: markt > Date: Thu Mar 21 16:37:49 2013 > New Revision: 1459389 > > URL: http://svn.apache.org/r1459389 > Log: > Improve performance for typical use cases by roughly an order of magnitude > > Modified: >tomcat/trunk/java/org/apa

Can we get another Maven 8.0.0.SNAPSHOT?

2013-03-21 Thread Nick Williams
Been a week since the last snapshot. LOTS of big WebSocket changes since then, including a fix for a problem with the core artifact JAR. Can we get another snapshot build sometime today? Thanks! - To unsubscribe, e-mail: dev-uns

Re: Can we get another Maven 8.0.0.SNAPSHOT?

2013-03-21 Thread Nick Williams
On Mar 21, 2013, at 5:49 PM, Mark Thomas wrote: > On 21/03/2013 18:06, Nick Williams wrote: >> Been a week since the last snapshot. LOTS of big WebSocket changes since >> then, including a fix for a problem with the core artifact JAR. Can we get >> another snapshot

Missing Classes in latest tomcat-embed-logging-log4j snapshot

2013-03-22 Thread Nick Williams
In the latest snapshot (3/21) of tomcat-embed-logging-log4j, all of the classes in org.apache.juli.logging.* are missing. They are there in the 3/14 snapshot, and they are there in the 3/21 SOURCES snapshot, but they are not there in the 3/21 binaries snapshot. Something foobar happened here. Th

Re: Missing Classes in latest tomcat-embed-logging-log4j snapshot

2013-03-22 Thread Nick Williams
On Mar 22, 2013, at 11:28 AM, Nick Williams wrote: > In the latest snapshot (3/21) of tomcat-embed-logging-log4j, all of the > classes in org.apache.juli.logging.* are missing. They are there in the 3/14 > snapshot, and they are there in the 3/21 SOURCES snapshot, but they are not &

Re: Getting my head around NIO 'simulated' blocking (trying to)

2013-03-23 Thread Nick Williams
On Mar 23, 2013, at 10:05 AM, igaz wrote: > So I won't bury the lede: what exactly (and why) is Tomcat doing 'simulated' > read blocking when using the NIO connector? > > I've done some due diligence including downloading the latest source > (7.0.37) and searching the tomcat mailing lists. > Fi

Re: svn commit: r1460700 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java

2013-03-25 Thread Nick Williams
On Mar 25, 2013, at 10:01 AM, ma...@apache.org wrote: > Author: markt > Date: Mon Mar 25 15:01:41 2013 > New Revision: 1460700 > > URL: http://svn.apache.org/r1460700 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54740 > Update SCI scan to reflect changes in spec > > Modified:

Re: My recent contributions and my ICLA

2013-03-27 Thread Nick Williams
I have made several contributions to Tomcat recently. Upon beginning some work on implementing a log4j-taglib module for Log4j 2, it came to my attention that I need to have an Individual Contributor License Agreement on file with the ASF Secretary. This has been done now, and my ICLA has been a

Re: My recent contributions and my ICLA

2013-03-27 Thread Nick Williams
On Mar 27, 2013, at 9:41 AM, Mark Thomas wrote: > On 27/03/2013 14:35, Nick Williams wrote: >> I have made several contributions to Tomcat recently. Upon beginning >> some work on implementing a log4j-taglib module for Log4j 2, it came >> to my attention that I need

Re: JarScanning

2013-03-28 Thread Nick Williams
On Feb 26, 2013, at 11:21 AM, Christopher Schultz wrote: > Mark, > > On 2/21/13 8:34 AM, Mark Thomas wrote: >> JRE JARs. >> I think scanning of these should be made optional and disabled by >> default. This will reduce the list of JARs we have to maintain in >> jarsToSkip. I intend to implement

Re: JarScanning

2013-03-29 Thread Nick Williams
On Mar 29, 2013, at 12:57 PM, Konstantin Kolinko wrote: > 2013/3/29 Nick Williams : >> >> >> (..) Note that Log4j2 is going to have a log4j-taglib artifact that >> (naturally) will have a TLD in its META-INF. Since Tomcat by default >> excludes log4j*

Re: Java 7 support on Tomcat 5.5

2013-04-01 Thread Nick Williams
On Apr 1, 2013, at 3:44 PM, Satheesh Babu wrote: > Good Evening! > > We're running our production applications in Tomcat 5.5/JRE 1.5, and there is > a need for us to migrate our applications to Java 7(JRE 1.7). There is no > information available either on java or on Apace Tomcat site regradin

Re: svn commit: r1479179 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/examples/WEB-INF/web.xml

2013-05-04 Thread Nick Williams
On May 4, 2013, at 4:20 PM, ma...@apache.org wrote: > Author: markt > Date: Sat May 4 21:20:27 2013 > New Revision: 1479179 > > URL: http://svn.apache.org/r1479179 > Log: > 204 responses are permitted entity headers > > Modified: >tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Pr

Re: svn commit: r1480974 [1/4] - in /tomcat/trunk: ./ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/ res/META-INF/

2013-05-10 Thread Nick Williams
On May 10, 2013, at 5:07 AM, ma...@apache.org wrote: > Author: markt > Date: Fri May 10 10:07:21 2013 > New Revision: 1480974 > > URL: http://svn.apache.org/r1480974 > Log: > Add the Java EE 7 XSDs. Mark, were these hand-coded or copied from some other source? If copied, could you let me know

Re: svn commit: r1480974 [1/4] - in /tomcat/trunk: ./ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/ res/META-INF/

2013-05-10 Thread Nick Williams
On May 10, 2013, at 8:35 AM, Mark Thomas wrote: > On 10/05/2013 14:22, Nick Williams wrote: >> >> On May 10, 2013, at 5:07 AM, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Fri May 10 10:07:21 2013 >>> New Revision: 1480974 >>>

OT: How do I subscribe to the Tomcat Dev/User lists with my @apache.org address?

2013-05-14 Thread Nick Williams
I recently became a committer on the Logging project and thus I now have an @apache.org address. Since it's a forwarding address, I'm having it forward to my Google Apps email address (the address I'm sending from now). I'd like to subscribe to the Tomcat Dev and User lists with my @apache.org

LOG4J2-223: IllegalStateException thrown during Tomcat shutdown (memory leak, it looks like)

2013-05-18 Thread Nick Williams
Can one of the very knowledgeable developers that have been discussing memory leaks in the last few days (re: Possible false-postive with JreMemoryLeakPreventionListener and Tomcat's JDBC Pool and OracleTimeoutPollingThread) chime in on this Log4j 2 bug [1]? Log4j 2 appears to be registering a

Timeline for beginning EL 3.0 implementation?

2013-06-11 Thread Nick Williams
I was looking through EE 7 and the changes to trunk in the last six months or so and realized that no work had yet been done to implement EL 3.0. Does anyone know what the anticipated timeline is for beginning work on EL 3.0? I don't even know who the EL expert(s) on the Tomcat project is(are).

Re: svn commit: r1491940 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/catalina/core/LocalStrings.properties test/org/apache/catalina/core/TestAsyncContextImp

2013-06-11 Thread Nick Williams
On Jun 11, 2013, at 3:28 PM, Mark Thomas wrote: > On 11/06/2013 21:25, Konstantin Kolinko wrote: >> 2013/6/12 : >>> Author: markt >>> Date: Tue Jun 11 20:18:10 2013 >>> New Revision: 1491940 >>> >>> URL: http://svn.apache.org/r1491940 >>> Log: >>> Servlet 3.1 requires an ISE if getRequest() or

Re: Timeline for beginning EL 3.0 implementation?

2013-06-11 Thread Nick Williams
On Jun 11, 2013, at 3:36 PM, Mark Thomas wrote: > On 11/06/2013 21:29, Nick Williams wrote: >> I was looking through EE 7 and the changes to trunk in the last six >> months or so and realized that no work had yet been done to implement >> EL 3.0. Does anyone know what the an

Re: Jar scanning, SCI scanning, fragment scanning

2013-06-13 Thread Nick Williams
On Jun 13, 2013, at 11:23 AM, Mark Thomas wrote: > As I make my way through the Servlet 3.1 spec reviewing all the changes to > make sure they have all been implemented, I have reached section 8.2. There > are a number of related issues here. > > 1. Three known issues with the current SCI / fr

Re: svn commit: r1493584 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java

2013-06-16 Thread Nick Williams
On Jun 16, 2013, at 4:14 PM, ma...@apache.org wrote: > Author: markt > Date: Sun Jun 16 21:14:37 2013 > New Revision: 1493584 > > URL: http://svn.apache.org/r1493584 > Log: > Fix FindBugs warnings in test code > > Modified: >tomcat/trunk/res/findbugs/filter-false-positives.xml > > tomca

CVE-2013-1571, VU#225657

2013-06-18 Thread Nick Williams
Oracle has announced a Javadoc vulnerability (CVE-2013-1571 [1], VU#225657 [2]) whereby Javadoc generated with Java 5, Java 6, or Java 7 < 7u25 is vulnerable to a frame injection attack. Oracle has provided a repair-in-place tool for Javadoc that cannot be easily regenerated, but is urging devel

Re: CVE-2013-1571, VU#225657

2013-06-19 Thread Nick Williams
On Jun 19, 2013, at 3:15 AM, Mark Thomas wrote: > On 19/06/2013 00:42, Nick Williams wrote: >> Oracle has announced a Javadoc vulnerability (CVE-2013-1571 [1], >> VU#225657 [2]) whereby Javadoc generated with Java 5, Java 6, or Java >> 7 < 7u25 is vulnerable to a frame

Re: Jasper improvements

2013-06-26 Thread Nick Williams
On Jun 26, 2013, at 1:57 PM, Jeremy Boynes wrote: > On Jun 26, 2013, at 7:49 AM, Christopher Schultz > wrote: > >> Jeremy, >> >> On 6/26/13 1:44 AM, Jeremy Boynes wrote: >>> On Jun 11, 2013, at 1:50 PM, Nick Williams >>> wrote: >>>>

Re: svn commit: r1497299 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 6:08 AM, ma...@apache.org wrote: > Author: markt > Date: Thu Jun 27 11:08:03 2013 > New Revision: 1497299 > > URL: http://svn.apache.org/r1497299 > Log: > WebSocket 1.0, Section 4.8 > Don't look for annotations on inherited methods. > > Modified: >tomcat/trunk/java/org/a

Re: svn commit: r1497299 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 9:42 AM, Mark Thomas wrote: > On 27/06/2013 15:29, Nick Williams wrote: >> >> On Jun 27, 2013, at 6:08 AM, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Thu Jun 27 11:08:03 2013 >>> New Revision: 1497299 >

Re: svn commit: r1497569 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 4:32 PM, ma...@apache.org wrote: > Author: markt > Date: Thu Jun 27 21:32:39 2013 > New Revision: 1497569 > > URL: http://svn.apache.org/r1497569 > Log: > With an eye to the future, First phrase of your new novel? :-) ---

Re: svn commit: r1497552 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 6:14 PM, Konstantin Kolinko wrote: > 2013/6/28 : >> Author: markt >> Date: Thu Jun 27 20:10:40 2013 >> New Revision: 1497552 >> >> URL: http://svn.apache.org/r1497552 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 >> Fix bugs in test >> >> Modified:

Re: svn commit: r1497670 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java

2013-06-28 Thread Nick Williams
On Jun 28, 2013, at 2:35 AM, ma...@apache.org wrote: > Author: markt > Date: Fri Jun 28 07:35:49 2013 > New Revision: 1497670 > > URL: http://svn.apache.org/r1497670 > Log: > WebSocket 1.0, section 8.2 > There is an implied restriction that any initial upgrade request must use > HTTP GET. > >

Re: svn commit: r1497670 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java

2013-06-28 Thread Nick Williams
On Jun 28, 2013, at 11:27 AM, Mark Thomas wrote: > On 28/06/2013 17:00, Nick Williams wrote: >> >> On Jun 28, 2013, at 2:35 AM, ma...@apache.org wrote: >> >>> Author: markt Date: Fri Jun 28 07:35:49 2013 New Revision: 1497670 >>> >>> URL: h

Re: svn commit: r1504148 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/el/ java/org/apache/jasper/runtime/ test/javax/el/ test/org/apache/el/ test/org/apache/el/parser/ t

2013-07-17 Thread Nick Williams
On Jul 17, 2013, at 9:21 AM, Caldarale, Charles R wrote: >> From: ma...@apache.org [mailto:ma...@apache.org] >> Subject: svn commit: r1504148 > >> URL: http://svn.apache.org/r1504148 >> Log: >> Add the two new resolver types (stream and static) to Jasper in the correct >> order and modify Jasp

Re: 8.0-SNAPSHOT updated

2013-07-18 Thread Nick Williams
No objection here. Things seem to be working well. I'm rather excited about it. :-) Nick On Jul 18, 2013, at 11:11 AM, Mark Thomas wrote: > Given recent progress, I have uploaded a snapshot of the current state > of trunk to the Maven snapshot repository. Note that our Maven builds > include fu

Re: 8.0.0 (was: 8.0-SNAPSHOT updated)

2013-07-25 Thread Nick Williams
On Jul 25, 2013, at 6:49 PM, Rainer Jung wrote: > On 26.07.2013 00:34, Mark Thomas wrote: >> On 21/07/2013 09:10, Mark Thomas wrote: >>> On 20/07/2013 17:42, Konstantin Kolinko wrote: 2013/7/18 Mark Thomas : >> >> >> > Any objections to starting the 8.0.0 release process? W

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Nick Williams
On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote: > This flags as a warning for me in IDEA without the suppression. Isn't this > an unchecked cast (Object to List)? Yes, that's an unchecked cast. The @SuppressWarnings was not unnecessary. N > > > On Mon, Jul 29, 2013 at 11:38 AM, wrote: > >

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Nick Williams
On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote: > On 29/07/2013 21:04, Nick Williams wrote: >> On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote: >> >>> This flags as a warning for me in IDEA without the suppression. Isn't this >>> an unchecked cast (Object

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Nick Williams
On Jul 29, 2013, at 3:02 PM, Mark Thomas wrote: > On 29/07/2013 21:45, Nick Williams wrote: >> >> On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote: >> >>> On 29/07/2013 21:04, Nick Williams wrote: >>>> On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote:

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Nick Williams
r (Object o : orderedLibs) { > +String lib = (String) o; > URL jarUrl = context.getResource(LIB + lib); > if (jarUrl == null) { > // should not happen, just ignore > > > > On Mon, Jul 29, 2013 at 12:40 PM, Mark

Re: Using a mock framework for testing?

2013-07-31 Thread Nick Williams
On Jul 31, 2013, at 11:09 AM, Jeremy Boynes wrote: > Any objection to adding a dependency on a mocking framework to aid unit > testing? > The one I have used most is EasyMock which is Apache License 2.0. > > Cheers > Jeremy EasyMock is fantastic. I use it for everything I do, and we're using i

Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-03 Thread Nick Williams
On Aug 1, 2013, at 3:53 PM, Mark Thomas wrote: > The proposed 8.0.0-RC1 release is: > [ ] Broken - do not release > [ X] Alpha - go ahead and release as 8.0.0-RC1 alpha (Non-binding) Tested the .zip distribution on Windows 7 SP1 64-bit. Everything seems to be functioning properly.

Re: svn commit: r1510210 - /tomcat/trunk/build.xml

2013-08-04 Thread Nick Williams
On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote: > On 04/08/2013 21:02, Jeremy Boynes wrote: >> On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: >>> Log: >>> Treat javax.servlet.ServletContainerInitializer files as text in source >>> >>> >>> + >>> >> >> Would this work to catch

Re: svn commit: r1510210 - /tomcat/trunk/build.xml

2013-08-04 Thread Nick Williams
On Aug 4, 2013, at 2:40 PM, Mark Thomas wrote: > On 04/08/2013 21:31, Nick Williams wrote: >> >> On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote: >> >>> On 04/08/2013 21:02, Jeremy Boynes wrote: >>>> On Aug 4, 2013, at 8:37 AM, ma..

Re: svn commit: r1510665 [26/26] - in /tomcat/site/trunk/docs/tomcat-8.0-doc/servletapi: ./ javax/ javax/servlet/ javax/servlet/annotation/ javax/servlet/descriptor/ javax/servlet/http/ resources/

2013-08-05 Thread Nick Williams
On Aug 5, 2013, at 2:10 PM, ma...@apache.org wrote: > Added: tomcat/site/trunk/docs/tomcat-8.0-doc/servletapi/serialized-form.html > URL: > http://svn.apache.org/viewvc/tomcat/site/trunk/docs/tomcat-8.0-doc/servletapi/serialized-form.html?rev=1510665&view=auto > =

Re: [VOTE][RESULT] Release Apache Tomcat 8.0.0-RC1

2013-08-06 Thread Nick Williams
On Aug 6, 2013, at 4:22 AM, Ognjen Blagojevic wrote: > Mark, > > On 5.8.2013 22:56, Mark Thomas wrote: >> The site has been updated with the various parts required for a new >> major release (security, migration, download, docs, navigation, which >> version etc.) but I haven't posted the release

Re: [VOTE][RESULT] Release Apache Tomcat 8.0.0-RC1

2013-08-06 Thread Nick Williams
On Aug 6, 2013, at 9:27 AM, Mark Thomas wrote: > On 06/08/2013 12:57, Nick Williams wrote: > >> The migration guide says Tomcat 8 supports Expression Language 2.3. >> Should be 3.0. You (might) also want to call it Java Unified >> Expression Language. That'

Re: [VOTE][RESULT] Release Apache Tomcat 8.0.0-RC1

2013-08-06 Thread Nick Williams
On Aug 6, 2013, at 9:53 AM, Mark Thomas wrote: > On 06/08/2013 16:30, Nick Williams wrote: >> >> On Aug 6, 2013, at 9:27 AM, Mark Thomas wrote: >> >>> On 06/08/2013 12:57, Nick Williams wrote: >>> >>>> The migration guide says Tomcat 8 suppor

Re: Use (or not) of @SuppressWarnings

2013-08-07 Thread Nick Williams
On Aug 7, 2013, at 2:41 AM, Mark Thomas wrote: > For trunk we have been running a policy of zero warnings in the code. > This has helped to highlight issues as code is edited as any warnings > are immediately clear. Obviously, this depends on what warnings are enabled. > > Currently, we use Ecli

Re: Code style rules: Line length

2013-08-08 Thread Nick Williams
On Aug 8, 2013, at 12:50 PM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line

Re: Back-porting JSR-356 implementation to 7.0.x

2013-08-15 Thread Nick Williams
On Aug 15, 2013, at 5:47 PM, Mark Thomas wrote: > This isn't going to be quite as simple as I first thought. > > The WebSocket client API requires Java SE 7 or later. > The WebSocket server API requires Java EE 6 or later. > Java EE 6 requires Java 6 or later. > The WebSocket server API depends

Re: Using log4j under a security manager

2013-08-17 Thread Nick Williams
On Aug 17, 2013, at 7:36 AM, Christopher Schultz wrote: > All, > > See this SO thread: > http://stackoverflow.com/questions/18147885/use-log4j-in-a-tomcat-with-security-manager > > ...and refer to the Tomcat 7 log4j instructions: > > http://tomcat.apache.org/tomcat-7.0-doc/logging.html#Using_L

Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 6:14 AM, ma...@apache.org wrote: > Author: markt > Date: Tue Aug 20 11:14:39 2013 > New Revision: 1515779 > > URL: http://svn.apache.org/r1515779 > Log: > Add the rather crucial missing i++ in the wait loop Lol. Don't you hate when you do that?

Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 7:59 AM, Mark Thomas wrote: > On 20/08/2013 13:45, Nick Williams wrote: >> >> On Aug 20, 2013, at 6:14 AM, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Tue Aug 20 11:14:39 2013 >>> New Revision: 1515779 >>>

Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never gotten all the existing tests to pass on my machine. Last time I ran them it too

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 8:25 AM, Mark Thomas wrote: > On 20/08/2013 14:13, Nick Williams wrote: >> I'm working on implementing bugzilla 55317. It's a pretty important >> change (weaving) to a pretty import class (WebappClassLoader), so it >> obviously needs some u

  1   2   >