On Feb 16, 2013, at 10:51 AM, Mark Thomas wrote: > On 16/02/2013 16:42, Nick Williams wrote: >> Mark, >> >> I've noticed in the past few days you've committed several change >> sets with comments like "use of final" and "reduce visibility" >> (mostly the latter). I'm trying to understand the Tomcat source code >> better so that I can potentially contribute more in the future, and >> I'm wondering what the motivation is behind reducing visibility of >> Jasper components. I've always viewed reducing visibility as a >> hindrance to extension (which, of course, is sometimes desired), so >> I'm curious why the sudden attempt to do this to Jasper? (Is it as >> simple as just cleaning things up before beginning the JSP 2.3/EL 3.0 >> implementation?) > > http://svn.apache.org/repos/asf/tomcat/trunk/TOMCAT-NEXT.txt > Item 5.
AH! Haha. I didn't even see that. I will enjoy looking over this list. Thanks. > > Making fields private should never be an issue as accessors should be used. True. I just didn't know if you were also reducing the visibility of classes or methods. > > Reducing visibiity encourages good design. Agreed. Reducing the visibility of fields and using encapsulation are good design approaches. However, sometimes reducing the visibility of methods can be troublesome, depending on the situation. > > Visibility can always be increased if required. > >> Specifically, sometime last year I mentioned on the list perhaps >> contributing an improved Ant task for JSP compilation (bugs 53011, >> 53012, and 53492, dev list topic "Improving Ant Task for JSP >> Compilation" from March 31, 2012). After successfully contributing my >> first bit of new code to trunk, I'm thinking about finally getting >> around to doing this. Are any of the changes you are making going to >> hinder my ability to do this? (I gave it a cursory glance in version >> control and didn't see anything that stood out, but I may be missing >> something). > > No. Visibility can be increased, accessors can be added as necessary. Understood. Thanks! Nick
smime.p7s
Description: S/MIME cryptographic signature
