On Nov 17, 2013, at 4:10 PM, Jeremy Boynes wrote: > On Nov 17, 2013, at 1:42 PM, ma...@apache.org wrote: > >> Author: markt >> Date: Sun Nov 17 21:42:26 2013 >> New Revision: 1542836 >> >> URL: http://svn.apache.org/r1542836 >> Log: >> Revert part of r1542565 which added rather than removed an IDE warning >> >> Modified: >> tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java >> >> Modified: >> tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java?rev=1542836&r1=1542835&r2=1542836&view=diff >> ============================================================================== >> --- tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java >> (original) >> +++ tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java Sun >> Nov 17 21:42:26 2013 >> @@ -138,7 +138,8 @@ class TagLibraryInfoImpl extends TagLibr >> // Add TLD within the JAR to the dependency list >> String entryName = tldResourcePath.getEntryName(); >> try { >> - pageInfo.addDependant(jar.getURL(entryName), >> jar.getLastModified(entryName)); >> + pageInfo.addDependant(jar.getURL(entryName), >> + Long.valueOf(jar.getLastModified(entryName))); >> } catch (IOException ioe) { >> throw new JasperException(ioe); >> } > > Hmm, differences in IDE's opinion I assume - with this IDEA gives me a > warning about unnecessary boxing and nothing without. What are you seeing?
Yea, by all rules of Java boxing that I'm aware of, the use of Long.valueOf() here is unnecessary boxing. Not sure why your IDE is saying it's necessary. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
