rmaucher merged PR #875:
URL: https://github.com/apache/tomcat/pull/875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or
ShinKwang2 opened a new pull request, #875:
URL: https://github.com/apache/tomcat/pull/875
This PR fixes a documentation inaccuracy in `cluster-howto.xml`.
The original text incorrectly states that static memberships are configured
using `StaticMembershipInterceptor`.
However, the
rincoj01 closed pull request #46: Jorge patch 1
URL: https://github.com/apache/tomcat-maven-plugin/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
rincoj01 opened a new pull request, #46:
URL: https://github.com/apache/tomcat-maven-plugin/pull/46
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
ChristopherSchultz merged PR #874:
URL: https://github.com/apache/tomcat/pull/874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat
dgriffith-lx opened a new pull request, #874:
URL: https://github.com/apache/tomcat/pull/874
Update package for OneLineFormatter to match
[logging.properties](https://github.com/apache/tomcat/blob/9.0.x/conf/logging.properties)
--
This is an automated message from the Apache Git Service.
Chenjp closed pull request #873: Filter to limit target file size of ranged put
request
URL: https://github.com/apache/tomcat/pull/873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
skempken closed pull request #16: Fixes MTCOMCAT-294: Add URL decoding to fix
file lookup for paths containing spaces
URL: https://github.com/apache/tomcat-maven-plugin/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
marcosemiao commented on code in PR #78:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/78#discussion_r2184804118
##
src/main/java/org/apache/tomcat/jakartaee/Migration.java:
##
@@ -322,7 +325,7 @@ private void migrateArchiveStreaming(InputStream src,
OutputStr
ChristopherSchultz commented on code in PR #78:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/78#discussion_r2183806056
##
src/main/java/org/apache/tomcat/jakartaee/Migration.java:
##
@@ -322,7 +325,7 @@ private void migrateArchiveStreaming(InputStream src,
Ou
marcosemiao opened a new pull request, #78:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/78
For example use directory with non-writable files, example git repository :
java -jar jakartaee-migration-1.0.8-shaded.jar C:\work\
jakartaee-migration read and write al
Chenjp commented on PR #871:
URL: https://github.com/apache/tomcat/pull/871#issuecomment-3021435704
@markt-asf servlet project contains a testcase (CanonicalUriPathTest.java),
is it a part of servlet TCK?
--
This is an automated message from the Apache Git Service.
To respond to the messa
rmannibucau commented on PR #870:
URL: https://github.com/apache/tomcat/pull/870#issuecomment-2997222319
@markt-asf hmm, you're right, wonder if it can be a timing issue so it would
be helpful to set the "original status" in notes (or internal attributes) and
check it in access log to not r
markt-asf commented on PR #870:
URL: https://github.com/apache/tomcat/pull/870#issuecomment-2996647475
The check you've added is a duplicate of the first check that happens when
the method in the `if` block is called.
--
This is an automated message from the Apache Git Service.
To respond
rmannibucau commented on PR #870:
URL: https://github.com/apache/tomcat/pull/870#issuecomment-2996544211
@markt-asf hmm, can you detail how it is unecessary since it happens in
async exchanges? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the mess
markt-asf commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2996468008
Fixed in 4dc1a0f9 and back-ported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
markt-asf closed pull request #868: recycle RequestInfo when Request is reused
in pool
URL: https://github.com/apache/tomcat/pull/868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
markt-asf commented on PR #870:
URL: https://github.com/apache/tomcat/pull/870#issuecomment-2996428405
This is unnecessary. See
https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/connector/Response.java#L1220
--
This is an automated message from the Apache Git Service.
To
markt-asf closed pull request #870: Avoid to change the status of the response
in StandardHostValve.java …
URL: https://github.com/apache/tomcat/pull/870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ChristopherSchultz closed pull request #869: Discard unsupported part header
field while handling multipart fileupload request
URL: https://github.com/apache/tomcat/pull/869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ChristopherSchultz commented on PR #869:
URL: https://github.com/apache/tomcat/pull/869#issuecomment-2988597530
I've got bad news: this code is a packaged-renamed copy of Apache
commons-fileupload, so this PR actually should be re-worked and filed against
that project instead. We are downst
rmannibucau opened a new pull request, #870:
URL: https://github.com/apache/tomcat/pull/870
…if response is committed
main issue: you get a 500 in the access log whereas it was a 200 (for
example)
--
This is an automated message from the Apache Git Service.
To respond to the messag
Chenjp opened a new pull request, #869:
URL: https://github.com/apache/tomcat/pull/869
comply rfc7578 section
[4.8](https://datatracker.ietf.org/doc/html/rfc7578#section-4.8)
```
4.8. Other "Content-" Header Fields
The multipart/form-data media type does not support any MIME hea
jfclere merged PR #29:
URL: https://github.com/apache/tomcat-native/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apach
qingdaoheze commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2978822957
> HTTP/2 is handled differently because of the multiplexing. We probably do
need a `recycle()` method on `RequestInfo`. It looks like it should be called
around line 440 (current 9.0.x c
jfclere opened a new pull request, #29:
URL: https://github.com/apache/tomcat-native/pull/29
Sorry I forgot to remove it in my previous PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
jfclere opened a new pull request, #28:
URL: https://github.com/apache/tomcat-native/pull/28
make native/WIN7_X64_DLL_RELEASE\tcnative-2.dll available for tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rmaucher commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2976593193
> HTTP/2 is handled differently because of the multiplexing. We probably do
need a `recycle()` method on `RequestInfo`. It looks like it should be called
around line 440 (current 9.0.x code
jfclere closed pull request #3: scripts, maven pom.xml and class to help to
load libraries from a jar
URL: https://github.com/apache/tomcat-native/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jfclere merged PR #26:
URL: https://github.com/apache/tomcat-native/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apach
qingdaoheze commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2976145027
https://github.com/user-attachments/assets/f15d8b35-a570-4bf3-a5be-325404a9d409";
/>
@rmaucher When the org.apache.coyote.Request pool is used, its
org.apache.coyote.Request#reqPr
markt-asf closed pull request #76: git branch and tomcat
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
markt-asf merged PR #74:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf commented on PR #76:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/76#issuecomment-2975216506
The ASF repositories are not playgrounds for you to experiment with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
markt-asf merged PR #77:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
dependabot[bot] opened a new pull request, #77:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/77
Bumps [org.apache:apache](https://github.com/apache/maven-apache-parent)
from 34 to 35.
Release notes
Sourced from https://github.com/apache/maven-apache-parent/release
ChristopherSchultz merged PR #867:
URL: https://github.com/apache/tomcat/pull/867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat
markt-asf commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2967321515
HTTP/2 is handled differently because of the multiplexing. We probably do
need a `recycle()` method on `RequestInfo`. It looks like it should be called
around line 440 (current 9.0.x code)
rmaucher commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966635424
Definitely this PR is wrong. RequestInfo is not the stats for an individual
request, so it should not be reset.
--
This is an automated message from the Apache Git Service.
To respond to
rmaucher closed pull request #868: recycle RequestInfo when Request is reused
in pool
URL: https://github.com/apache/tomcat/pull/868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
qingdaoheze commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966572313
Sorry. I don't understand what you mean. My issue is that the metrics in
org.apache.coyote.RequestGroupInfo#removeRequestProcessor is not counted
correctly when
org.apache.coyote.http2.
rmaucher commented on PR #868:
URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966521488
Are you trying to fix a problem you noticed, or is this PR based on code
analysis ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
qingdaoheze opened a new pull request, #868:
URL: https://github.com/apache/tomcat/pull/868
The request statistics will be wrong when Request object is reused in the
object pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964764619
> What does your flame graph look like after this change?
After optimization, the consumption of `Request#getCharsetHolder` is only
present during the first parsing. Subsequently, d
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964740795
> Looks reasonable to me. Needs a change log entry.
Thank you for the feedback. I have added a changelog entry to
webapps/docs/changelog.xml for this change.
--
This is an automa
markt-asf commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2963154081
Looks reasonable to me. Needs a change log entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmaucher commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962991943
I think it is likely ok. I did not like it since it is backwards from the
original intent of the refactoring.
--
This is an automated message from the Apache Git Service.
To respond to th
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962535411
> What does your flame graph look like after this change?
Sorry, I don't have a flame graph right now. I can capture one tomorrow.
--
This is an automated message from the Apache
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962444324
What does your flame graph look like after this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962441562
This analysis looks correct to me, and the solution is staightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
morning-gu commented on code in PR #867:
URL: https://github.com/apache/tomcat/pull/867#discussion_r2139963921
##
java/org/apache/coyote/Request.java:
##
@@ -389,14 +389,18 @@ public void setLocalPort(int port) {
// encoding/type
ChristopherSchultz commented on code in PR #867:
URL: https://github.com/apache/tomcat/pull/867#discussion_r2139938437
##
java/org/apache/coyote/Request.java:
##
@@ -389,14 +389,18 @@ public void setLocalPort(int port) {
// encoding/type ---
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962314501
@morning-gu Please don't ping specific members of this team to ask for a
review. Everyone is aware that this PR is here, and it will be reviewed when
these volunteers have time to
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962026185
@rmaucher Please review and approve the workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961553998
reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961546330
> Why would the charset name be null ?
Because it is not included in the request headers, as shown below:
Content-Type=application/x-www-form-urlencoded
--
This is an automate
rmaucher commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961464959
Why would the charset name be null ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
rmaucher closed pull request #867: Optimize Request#getCharsetHolder to avoid
repeated parsing when charset is null
URL: https://github.com/apache/tomcat/pull/867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
StudentGu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961118047
@markt-asf @michael-o Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
StudentGu opened a new pull request, #867:
URL: https://github.com/apache/tomcat/pull/867
In org.apache.coyote.Request#getCharsetHolder, when charsetHolder.getName()
returns null, parsing is performed repeatedly, resulting in unnecessary
performance overhead. The following optimizations are
galkin-anton closed pull request #866: add set flag for use virtual threads by
connector
URL: https://github.com/apache/tomcat/pull/866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
galkin-anton commented on PR #866:
URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956356313
Thank you for your advice. Then I reject pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
markt-asf commented on PR #866:
URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956270535
If you want to set that property, use the `setProperty(String,String)`
method. There are a lot of properties that are just passed through from the
`Connector` to the `Endpoint`. Those prop
galkin-anton commented on PR #866:
URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956256549
With this flag, the executor will be created in
org.apache.tomcat.util.net.AbstractEndpoint#createExecutor
--
This is an automated message from the Apache Git Service.
To respond to t
galkin-anton commented on PR #866:
URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956249452
I thought this patch would be useful to everyone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
galkin-anton commented on PR #866:
URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956246322
> What is the purpose of this change? It does not appear to be necessary.
>
> Further, the patch as provided includes an unnecessary semi-colon.
In my case, I'd like to mana
markt-asf commented on PR #866:
URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956213892
What is the purpose of this change? It does not appear to be necessary.
Further, the patch as provided includes an unnecessary semi-colon.
--
This is an automated message from the
galkin-anton opened a new pull request, #866:
URL: https://github.com/apache/tomcat/pull/866
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
zyu-godaddy commented on PR #235:
URL: https://github.com/apache/tomcat/pull/235#issuecomment-2951104976
While this change makes sense to me, and it should be inexpensive for the
jdbc driver I am using (mysql-connector-java), I don't feel comfortable to add
this check unconditionally withou
jfclere opened a new pull request, #27:
URL: https://github.com/apache/tomcat-native/pull/27
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
jfclere commented on PR #27:
URL: https://github.com/apache/tomcat-native/pull/27#issuecomment-2949193162
Oops sorry I am working on the next improvement...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jfclere closed pull request #27: Test
URL: https://github.com/apache/tomcat-native/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132132598
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+env:
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132131888
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+env:
jfclere commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132092619
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Revi
jfclere commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132055363
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+en
jfclere commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132091663
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+en
jfclere commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132055363
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+en
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131962779
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
+
+env:
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131953860
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131934294
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131930251
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131930251
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131930251
##
.github/workflows/makefile.yml:
##
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+ push:
+branches: [ "trunk" ]
+ pull_request:
+branches: [ "trunk" ]
Review
jfclere opened a new pull request, #26:
URL: https://github.com/apache/tomcat-native/pull/26
Use a github workflow to test a build on windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zyu-godaddy commented on PR #235:
URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945093472
Cool, I will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
markt-asf commented on PR #235:
URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945085547
If you can address Chris's concerns with the test then I don't see why this
PR (or one based on it) could not be merged.
--
This is an automated message from the Apache Git Service.
To r
zyu-godaddy commented on PR #235:
URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945031973
Also reported: https://bz.apache.org/bugzilla/show_bug.cgi?id=66502
This bug is the only bug that has been bugging us; otherwise the pool works
flawlessly.
I wonder if you p
markt-asf commented on PR #865:
URL: https://github.com/apache/tomcat/pull/865#issuecomment-2943219506
This change is unnecessary. If cookies are supported, the original session
will have been created with a tracking cookie.
Irrespective of the above, if the client has, for whatever r
markt-asf closed pull request #865: Enhance isEncodeable to determine putting
session id in URL using path parameter
URL: https://github.com/apache/tomcat/pull/865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
rmaucher closed pull request #855: [Bug 69693] - Improve readability and type
safety by changing parsingRequestLinePhase to an enum in Http11InputBuffer
URL: https://github.com/apache/tomcat/pull/855
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
rmaucher commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2943043327
-1, let's keep an int instead. It works and nobody will change this code at
this point. If they do, they should have a good understanding of it.
--
This is an automated message from the A
devjohnpark commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942968996
@markt-asf I agree that explicitly including the order in enum constant
names, like PHASE_0_NEW, enhances clarity without requiring HTTP/1.1 spec
knowledge. So I updated RequestLineParse
YongGoose commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942917295
@markt-asf
This is just a simple question out of curiosity — doesn’t the Tomcat project
use Copilot for code reviews?
I’m a committer for the Seata project, and I’ve found that C
YongGoose commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942678690
> I'm not convinced. With `int` the order is clear and obvious. With the
proposed `enum` the correct order is less clear and depends on the reader
knowing the detail of the HTTP/1.1 spec f
Chenjp opened a new pull request, #865:
URL: https://github.com/apache/tomcat/pull/865
It is not suitable to encode session id in URL if client support cookie.
per discuss in #862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
markt-asf merged PR #858:
URL: https://github.com/apache/tomcat/pull/858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf merged PR #863:
URL: https://github.com/apache/tomcat/pull/863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
markt-asf commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2939822823
I'm not convinced. With `int` the order is clear and obvious. With the
proposed `enum` the correct order is less clear and depends on the reader
knowing the detail of the HTTP/1.1 spec for
markt-asf commented on PR #864:
URL: https://github.com/apache/tomcat/pull/864#issuecomment-2939391552
Potential security vulnerabilities **DO NOT** belong in public pull requests.
Guidance on how to report security vulnerabilities responsibly can be found
at:
https://tomcat.apache
1 - 100 of 1819 matches
Mail list logo
