jajik commented on code in PR #26:
URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2131930251


##########
.github/workflows/makefile.yml:
##########
@@ -0,0 +1,88 @@
+name: Makefile CI
+
+on:
+  push:
+    branches: [ "trunk" ]
+  pull_request:
+    branches: [ "trunk" ]

Review Comment:
   I would suggest using
   
   ```
   on:
       push
       pull_request:
   ```
   
   only, so that it can run in custom branches in forks for example. (This way, 
you would have to use trunk, or modify the CI).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to