ChristopherSchultz commented on code in PR #78:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/78#discussion_r2183806056
##########
src/main/java/org/apache/tomcat/jakartaee/Migration.java:
##########
@@ -322,7 +325,7 @@ private void migrateArchiveStreaming(InputStream src,
OutputStream dest) throws
String destName = profile.convert(srcName);
if (srcZipEntry.getMethod() == ZipEntry.STORED) {
ByteArrayOutputStream tempBuffer = new
ByteArrayOutputStream((int) (srcZipEntry.getSize() * 1.05));
- migrateStream(srcName, srcZipStream, tempBuffer);
+ convertedArchive = convertedArchive |
migrateStream(srcName, srcZipStream, tempBuffer);
Review Comment:
This looks fishy to me: once convertedArchive is true, no more streams will
be migrated.
Was that the intent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
