YongGoose commented on PR #855: URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942678690
> I'm not convinced. With `int` the order is clear and obvious. With the proposed `enum` the correct order is less clear and depends on the reader knowing the detail of the HTTP/1.1 spec for request lines. I hadn’t considered it from the order perspective — your point makes a lot of sense. > Better names for the constants (that explicitly include the order) might help. That’s a great idea! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
