marcosemiao commented on code in PR #78:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/78#discussion_r2184804118
##########
src/main/java/org/apache/tomcat/jakartaee/Migration.java:
##########
@@ -322,7 +325,7 @@ private void migrateArchiveStreaming(InputStream src,
OutputStream dest) throws
String destName = profile.convert(srcName);
if (srcZipEntry.getMethod() == ZipEntry.STORED) {
ByteArrayOutputStream tempBuffer = new
ByteArrayOutputStream((int) (srcZipEntry.getSize() * 1.05));
- migrateStream(srcName, srcZipStream, tempBuffer);
+ convertedArchive = convertedArchive |
migrateStream(srcName, srcZipStream, tempBuffer);
Review Comment:
ConvertedArchive lets you know if there's at least one modification in the
archive.
The process then continues with the other files.
I just tested it with a jar file and a directory, and it works fine.
However, the purpose of commit is to differentiate between modified and
unchanged files.
Example: I used the file "struts-1.2.9.jar."
After the migration, all files have a modification date of 2006-03-09.
It would be nice to have the migration date for the modified files.
This allows someone who arrives to quickly see the modified files.
I'll add a commit to handle this.
My test case with jar and directory:
java -jar jakartaee-migration-1.0.10-SNAPSHOT-shaded.jar -profile=EE
C:\temp\work\struts1 C:\temp\work\struts1
java -jar jakartaee-migration-1.0.10-SNAPSHOT-shaded.jar -profile=EE
C:\temp\work\struts-1.2.9.jar C:\temp\work\struts-1.2.9.jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
