Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

[via GitHub]

morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964764619

   > What does your flame graph look like after this change?
   
   After optimization, the consumption of `Request#getCharsetHolder` is only 
present during the first parsing. Subsequently, due to the caching of null 
values, this method's consumption is not visible on the flame graph.
   
![image](https://github.com/user-attachments/assets/62fe1298-09f8-4709-b7ea-d5d5b30c5a8e)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org