GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/480
GEODE-2825: Lucene query waits for defined index to be created
* If an index is in a defined state but not yet created, the
query will now wait until the index is created or no longer
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/479#discussion_r113565230
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
---
@@ -166,28 +166,28 @@ public void createIndex(final
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/481#discussion_r114160633
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
---
@@ -47,18 +48,22 @@
new
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/481#discussion_r114161620
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
---
@@ -111,6 +121,10 @@ protected
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/481#discussion_r114195735
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
---
@@ -111,6 +121,10 @@ protected
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/480
Sure, I can re-add the one second sleep.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/480
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/491
GEODE-2870: Local node function execution failure correctly returns eâ¦
â¦xception
* Race condition and escaping synchronized block led to function possibly
missing results
* It was
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/491#discussion_r114674904
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionResultSender.java
---
@@ -214,16 +214,15 @@ public void
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/502
GEODE-2900: push shadow key to the front of eventSeqNumQueue
Testing still needs to be done on this change, but wanted to get some
eyeballs on the change in parallel
@upthewaterspout
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/513
GEODE-2914: Tidy up LuceneService javadoc
Potential reviewers:
@karensmolermiller @nabarunnag @ladyVader
Fixing typos and javadoc issues
You can merge this pull request into a Git
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/505
Yeah I think so. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/502
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/517
We definitely have order by in the tests, whether or not they are adequate
I am not sure. doing a find on "order by" will show a log of queries in the
tests...
The changes look good to
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/519
GEODE-2937: Restore removeFromQueueOnException
Restoring the system property REMOVE_FROM_QUEUE_ON_EXCEPTION. This was
no-op'd in some refactoring code last year and should not have
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/511
I still get a conflicting file but it was simple enough to change. It
looks good to me. I'll merge this in when I get a chance (tomorrow?)
---
If your project is set up for it, you can rep
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/509
I think these changes are ok (I didn't check when these were deprecated but
I assume @metatype already did the grunt work on it. I can merge these changes
in if no one has any other reviews
-
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/509
@metatype Will do for both this and PR#511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/511
Hi Deepak,
Sorry, I've tried merging this into develop but had issues with the
conflicts and then was unable to credit you with the checkin. Will you be able
to recreate this pull re
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/558
Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/565
GEODE-3021: Any call after the first to setPdxStringFlag should no-op
* The flag isIndexedPdxKeysFlagSet is now checked before setting pdx
string flag
@nabarunnag @ladyVader
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/565
@boglesby @upthewaterspout @gesterzhou
Adding additional reviewers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/565#discussion_r121196596
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
---
@@ -2002,7 +2002,8 @@ void populateListForEquiJoin
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/565
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/588#discussion_r123060011
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java
---
@@ -510,6 +512,16 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/591#discussion_r123388223
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java
---
@@ -925,79 +917,89 @@ private SelectResults
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/589#discussion_r123553740
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
---
@@ -37,20 +38,25 @@
private String
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/589#discussion_r123830138
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
---
@@ -37,20 +38,25 @@
private String
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128586252
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128584345
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
---
@@ -85,8 +72,8 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128584677
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
---
@@ -472,12 +478,20 @@ public boolean waitUntilFlushed
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128585366
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r129418949
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r129624935
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/659#discussion_r130765375
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java
---
@@ -0,0 +1,1044 @@
+/*
+ * Licensed
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/659#discussion_r130765402
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java
---
@@ -0,0 +1,1044 @@
+/*
+ * Licensed
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r130952081
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
---
@@ -85,8 +72,10 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r132497282
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -331,6 +331,29 @@ public void queryJsonObject
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/688
Looks ok to me...I'll merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/712
GEODE-3434: Allow the modules to be interoperable with current and olâ¦
â¦der versions of tomcat 7
Modified DeltaSessions to use reflection to handle attributes fields incase
an earlier
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133270585
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
---
@@ -34,7 +34,6 @@
import
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133843558
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -586,6 +610,20 @@ public int
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133843603
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -553,8 +555,30 @@ public void fromData
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133843663
--- Diff: geode-old-versions/build.gradle ---
@@ -65,6 +92,21 @@ task createGeodeClasspathsFile {
new FileOutputStream(classpathsFile).withStream
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/712
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/718
GEODE-3434: Allow old tomcat server sessions to be compatible with new
tomcat session modules
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/718
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/732#discussion_r134622619
--- Diff:
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderImpl.java
---
@@ -107,6 +107,9 @@ public void stop
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/410#discussion_r103763944
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java ---
@@ -18,53 +18,77 @@
import java.util.Map;
import
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/410#discussion_r103763560
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java
---
@@ -17,34 +17,29 @@
import
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/410#discussion_r103764691
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/PageableLuceneQueryResults.java
---
@@ -15,30 +15,34 @@
package
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/427#discussion_r106482198
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventSubstitutionFilter.java
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/3#discussion_r108542208
--- Diff:
partitioned/src/main/java/org/apache/geode/examples/partitioned/Producer.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/3#discussion_r108541629
--- Diff: partitioned/README.md ---
@@ -0,0 +1,156 @@
+
+
+# Geode partitioned region example
+
+This example demonstrates the
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/3#discussion_r108542421
--- Diff:
partitioned/src/test/java/org/apache/geode/examples/partitioned/PartitionedTest.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/444#discussion_r110719505
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java
---
@@ -240,12 +240,37 @@ public boolean
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/444#discussion_r110702026
--- Diff:
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqQueryDUnitTest.java
---
@@ -1577,7 +1577,13 @@ public void run2() throws
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/444#discussion_r110718931
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java ---
@@ -1261,7 +1333,14 @@ void basicUpdateEntryVersion(EntryEventImpl
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/448#discussion_r111011735
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java
---
@@ -464,16 +464,21 @@ private void setLatestAcknowledgedKey
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/449#discussion_r111036455
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/CreateIndexFunction.java
---
@@ -93,6 +91,31 @@ public void execute
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/321
I've pulled these changes in. Had to resolve some conflicts but these
changes should be in geode now.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/447
I pulled the changes and it built fine. I collapsed and edited the commit
messages to match how geode commits generally look and made a minor tweak to
the wording on one parameter. This is now in
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/451
GEODE-2768: Lucene Queries executed before index is fully created shoâ¦
â¦uld be retried
* Added a sleep to prevent rapid retries which lead to stack overflow
* Sleep can be
Github user jhuynh1 commented on the issue:
https://github.com/apache/geode/pull/451
Tagging potential reviewers @nabarunnag @boglesby @ladyVader @gesterzhou
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/451#discussion_r111275346
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java
---
@@ -132,6 +133,25 @@ private
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/449#discussion_r111591894
--- Diff:
geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationIndexWithFromClauseDUnitTest.java
---
@@ -0,0
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user jhuynh1 opened a pull request:
https://github.com/apache/geode/pull/460
Feature/geode 2703
Modified transaction exception messaging when executing a lucene query
within a geode transaction.
The client transactions behave differently in geode depending on
Github user jhuynh1 closed the pull request at:
https://github.com/apache/geode/pull/460
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r89148312
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/BugGeode_1653DUnitTest.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to
Github user jhuynh1 commented on the issue:
https://github.com/apache/incubator-geode/pull/300
The changes look good, I've merged them in.
Thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90116715
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -0,0 +1,164
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91360319
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WANCommandTestBase.java
---
@@ -448,6 +452,37 @@ public void
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91348684
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java ---
@@ -400,4 +400,19 @@
public int
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91391868
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GatewaySenderDestroyFunction.java
---
@@ -0,0 +1,90
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91390603
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -55,7 +55,7
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91423780
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -282,13 +335,40
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/318#discussion_r92677783
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java
---
@@ -149,6 +154,92 @@ public void run
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/318#discussion_r92678100
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java
---
@@ -149,6 +154,92 @@ public void run
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/318#discussion_r92677109
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
---
@@ -8751,18 +8751,26 @@ public Index createIndex(boolean
Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/318#discussion_r92691796
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java
---
@@ -149,6 +154,92 @@ public void run
84 matches
Mail list logo
