Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/481#discussion_r114161620
  
    --- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
    @@ -111,6 +121,10 @@ protected IndexRepository computeRepository(Integer 
bucketId) {
         return repo;
       }
     
    +  protected void allowRepositoryComputation() {
    --- End diff --
    
    Nitpick isn't this representing that the repository is ready for use?  
Should rename the latch and method to reflect this, such as readyForUse and 
enableRepositoryForUse? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to