Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/609#discussion_r129418949
  
    --- Diff: 
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
 ---
    @@ -290,6 +295,24 @@ public void queryJsonObject() throws Exception {
       }
     
       @Test()
    +  public void testWaitUntilFlushedForException() throws Exception {
    +    Map<String, Analyzer> fields = new HashMap<String, Analyzer>();
    +    fields.put("name", null);
    +    fields.put("lastName", null);
    +    fields.put("address", null);
    +    
luceneService.createIndexFactory().setFields(fields).create(INDEX_NAME, 
REGION_NAME);
    +    Region region = 
cache.createRegionFactory(RegionShortcut.PARTITION).create(REGION_NAME);
    +    final LuceneIndex index = luceneService.getIndex(INDEX_NAME, 
REGION_NAME);
    +
    +    // This is to send IllegalStateException from WaitUntilFlushedFunction
    +    String nonCreatedIndex = "index2";
    +
    +    boolean b =
    +        luceneService.waitUntilFlushed(nonCreatedIndex, REGION_NAME, 
60000, TimeUnit.MILLISECONDS);
    +    assertFalse(b);
    --- End diff --
    
    @ameybarve15
    I was under the assumption that the client currently is being passed the 
IllegalArgumentException and instead we would just throw the 
IllegalStateException and piggy back off of how FunctionExecution handles 
exceptions.  When a function fails during function execution, I would think an 
exception is passed back to the user?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to