Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r128584677
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
---
@@ -472,12 +478,20 @@ public boolean waitUntilFlushed(String indexName,
String regionPath, long timeou
new WaitUntilFlushedFunctionContext(indexName, timeout, unit);
Execution execution = FunctionService.onRegion(dataRegion);
ResultCollector rs =
execution.setArguments(context).execute(WaitUntilFlushedFunction.ID);
- List<Boolean> results = (List<Boolean>) rs.getResult();
- for (Boolean oneResult : results) {
- if (oneResult == false) {
+ List<Object> results = (List<Object>) rs.getResult();
+ if (results != null) {
+ if (results.get(0) instanceof IllegalStateException) {
--- End diff --
Instead of checking types and silently handling this exception, it's
probably better to just throw it and not have to modify this portion of code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
