Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/30
The C++ integration test framework keeps the test files in a directory
specific to the current test. Can we not do the same thing here and avoid this
random thing?
---
If your
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/27
@dgkimura I think the GitHub UI would work better if the Geode repo was
actually hosted in GitHub but since this is a mirror it causes some strange
behaviors with pull requests
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005494
--- Diff: src/tests/cpp/security/XmlAuthzCredentialGenerator.hpp ---
@@ -27,7 +27,7 @@
#include
#include
--- End diff
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103004766
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
-#includ
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005369
--- Diff: src/tests/cpp/security/PkcsAuthInit.cpp ---
@@ -19,7 +19,7 @@
#include
#include
#include
-#include "st
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103004805
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
--
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005160
--- Diff: src/tests/cpp/fwklib/TaskClient.cpp ---
@@ -20,12 +20,12 @@
#include "fwklib/FwkLog.hpp"
#include "fwk
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005713
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.hpp ---
@@ -27,10 +27,10 @@
#include
#include
-#include
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103009272
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
-#includ
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103031038
--- Diff: src/cppcache/src/Utils.cpp ---
@@ -22,7 +22,7 @@
#include
extern "C" {
-#include
+#include
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103031314
--- Diff: src/tests/cpp/fwklib/Timer.hpp ---
@@ -28,18 +28,18 @@
#ifdef _WIN32
-#include
-#include
-#include
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/33
@PivotalSarge CMakeList.txt.in is there to build Antlr with CMake rather
than the very complicated and broken build process it ships with.
---
If your project is set up for it, you
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103054617
--- Diff: src/cppcache/src/CacheableBuiltins.cpp ---
@@ -19,7 +19,7 @@
#include
extern "C" {
-#include
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103054588
--- Diff: src/cppcache/integration-test/BuiltinCacheableWrappers.hpp ---
@@ -23,7 +23,7 @@
#include "CacheableWrapper.hpp"
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/36
GEODE-2494: Replace SpinLock with spinlock_mutex.
Replaces our non-standard SpinLock with spinlock_mutex that implements the
C++11 standard BasicLockable. Where applicable the spin
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/37
GEODE-2531: Replace HostAsm::atomic with std::atomic.
Focus on commit c3411fd since the others are from pull #36.
Replaces the HostAsm::atomic* functions and ACE::Atomic
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/38
GEODE-2549: Delete unused files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode-native
feature/GEODE
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/40
GEODE-2552: Remove NanoTimer
Please focus on commits e541e31 ... daf4234, others are artifacts of
unpulled requests.
You can merge this pull request into a Git repository by running
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/40
> Would adding const to variables like spentWorking and sleepDuration help
the compiler generate more efficient code?
I doubt the compilers would care since it will know
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/40
@PivotalSarge
> Why the switch to ACE_OS::localtime() from localtime()?
`localtime` AKA POSIX `localtime` is not thread safe. `ACE_OS::localtime`
wraps the platf
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/40
@PivotalSarge
> Nice fix of the broken window of catching exceptions by value.
If you enable `clang-tidy` you will see plenty of them. I am cleaning up
lots of these
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103350610
--- Diff: src/tests/cpp/security/Security.cpp ---
@@ -41,16 +41,18 @@
#include "security/CredentialGenerato
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103350612
--- Diff: src/cppcache/src/LRUEntriesMap.cpp ---
@@ -297,7 +295,7 @@ GfErrType LRUEntriesMap::put(const CacheableKeyPtr&
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103351422
--- Diff: src/tests/cpp/security/Security.cpp ---
@@ -1014,12 +1016,15 @@ int32_t Security::doEntryOperations
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103351757
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -41,6 +40,9 @@
#include
#include "TombstoneList.hpp"
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103351894
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
m_entryFactory->newMapEntry(
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352019
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
m_entryFactory->newMapEntry(
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352237
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
#include "fw_dunit.hpp"
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352781
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -108,21 +98,21 @@ CqQueryStatType::CqQueryStatType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352845
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
* limitations under the License.
*/
#include "LRULis
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353400
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -19,18 +19,22 @@
#include "TrackedMapEntry.hpp"
#include "Reg
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353360
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -96,33 +102,38 @@ void LRUList::getLRUEntry(LRUListEntryPtr& result) {
temp
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353568
--- Diff: src/cppcache/src/LRUList.hpp ---
@@ -20,32 +20,32 @@
* limitations under the License.
*/
+#include
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353607
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -316,16 +320,16 @@ GfErrType MapSegment::remove(const CacheableKeyPtr&
key, Cacheabl
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353683
--- Diff: src/cppcache/src/LRUEntriesMap.cpp ---
@@ -20,6 +20,9 @@
#include "MapSegment.hpp"
#include &quo
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103354398
--- Diff: src/cppcache/include/geode/CacheStatistics.hpp ---
@@ -102,8 +102,8 @@ class CPPCACHE_EXPORT CacheStatistics : public
SharedBase
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103355323
--- Diff: src/cppcache/include/geode/SharedBase.hpp ---
@@ -56,11 +57,12 @@ class CPPCACHE_EXPORT SharedBase {
protected
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103355539
--- Diff: src/cppcache/src/statistics/AtomicStatisticsImpl.cpp ---
@@ -330,7 +329,13 @@ double AtomicStatisticsImpl::_incDouble(int32_t
offset
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103359636
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -20,43 +20,38 @@
#include "CqQueryVsdStats.hpp"
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/44
@PivotalSarge looks like some unit tests are failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/44
@PivotalSarge can you rebase your branch off of develop. We backed out all
those C++11 changes and now they are showing up in your pull.
---
If your project is set up for it, you can
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/42
@dgkimura You need to remove the C++ parser and Antlr from the LICENSE and
dist/LICENSE files too.
---
If your project is set up for it, you can reply to this email and have your
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104816808
--- Diff: src/cppcache/include/geode/DataOutput.hpp ---
@@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
*/
inline void
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/46
@davebarnes97 you will need to do what @PivotalSarge did. Create a new
branch from develop and cherry pick your changes from your old branch and then
submit a new pull request. Your
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura I would suggest getting a few of those integration tests updated
to test this. They were marked flaky a long time ago when the tests ran through
several iterations with
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura It will give the CI something to chew on to prove that this
message actually works with the server now. ;)
---
If your project is set up for it, you can reply to this email
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura I will pull this and work on some of the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
This will get closed when pull #63 is committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/63
GEODE-2657
Please make a quick review.
Fixes all the integration tests around Function Execution and adds test of
AppDomain Function Execution.
Test
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/61
I will go ahead and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106927339
--- Diff:
src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
@@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106927884
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106928287
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929690
--- Diff:
src/clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs ---
@@ -0,0 +1,282
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929867
--- Diff:
src/clicache/integration-test/ThinClientFunctionExecutionTestsN.cs ---
@@ -959,7 +959,7 @@ public void ExecuteFETimeOut
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106930126
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1506,48 +1353,10 @@ void runFunctionExecution(bool
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106930234
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1158,9 +1160,10 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/53#discussion_r106998634
--- Diff: src/docs/win_index.html ---
@@ -19,21 +19,21 @@
- Pivotal™ GemFire® Native Client Documentation
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/53#discussion_r107039971
--- Diff: src/docs/win_index.html ---
@@ -19,21 +19,21 @@
- Pivotal™ GemFire® Native Client Documentation
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/64#discussion_r107040822
--- Diff:
docs/geode-native-docs/continuous-querying/3-native-client-cq-api.html.md.erb
---
@@ -21,9 +21,10 @@ limitations under the License
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/64#discussion_r107045279
--- Diff:
docs/geode-native-docs/continuous-querying/3-native-client-cq-api.html.md.erb
---
@@ -21,9 +21,10 @@ limitations under the License
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006150
--- Diff: src/cppcache/src/ThinClientPoolDM.hpp ---
@@ -463,7 +463,8 @@ class FunctionExecution : public PooledWork {
void
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006260
--- Diff: src/cppcache/src/ThinClientPoolDM.hpp ---
@@ -625,7 +626,7 @@ class OnRegionFunctionExecution : public
PooledWork
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006001
--- Diff: src/cppcache/src/ThinClientPoolDM.cpp ---
@@ -609,7 +609,8 @@ GfErrType ThinClientPoolDM::sendRequestToAllServers(
HostAsm
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006315
--- Diff: src/cppcache/src/ThinClientRegion.cpp ---
@@ -3350,7 +3350,8 @@ bool ThinClientRegion::executeFunctionSH(
HashMapT
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006539
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -407,17 +407,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/90
You shouldn't merge develop into your feature branch. You should rebase
your feature branch on develop. This creates a much cleaner merge of the
feature back into develop when app
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/342
GEODE-2309: Replace Pivotal Copyright and add Apache License notice.
Can I please get quick review of the copyright and license changes.
You can merge this pull request into a Git
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/341
I would suggest a little more detail on the building in windows since the
command provided will use NMake and suck for the person building. Include
statement about -G generator options
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/341
Let's also move the BUILDING.md down to the root directory so it is easier
to find.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/341
@upthewaterspout, Its an easy change. We went for consistency with the
CMake community on the explicit variable setting. It is however consistent to
have the module "find" the
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/342
In this push I am only trying to tackle the changing of licenses and adding
to the obvious sources. We will integrated something a little more like rat
(see email GEODE-2312 about rat issues
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
I've been down this ordering road before. Pretty sure this change will
break on Windows and possibly Solaris. If the known to work platforms in the
BUILDING doc, which have you tested
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
Looking at this a little more... I don't think that gfppcache directly
depends on -lz. If it is just a transitive dependency from libxml2 then we
should move the -lz to target li
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
@metatype looks good if you want to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/350
Feature/geode 2316
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode feature/GEODE-2316
Alternatively you can
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/355
Looks good, will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/357
rejecting as duplicate of #356
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/356
Rejecting.
Path "pivotal-gemfire-*" should be "apache-geode-*".
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/199
Please close this pull request. It has seen no attention or corrections in
over 6 months.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/199
Yes, you can correct it but please make sure its agains the latest branch.
It may be easier to close and open a new one.
---
If your project is set up for it, you can reply to this email
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/365
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/367
We should include links to CTest documents.
To run singles or subsets of tests you need to use ctest directly.
ctest -R
---
If your project is set up for it, you
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/371
[GEODE-2308] Change library names to for Apache Geode branding.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/369
Merged, please close pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/370
Merged, please close pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/372
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/367
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/373
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/376
I will just add a comment to the line that this is the Geode 1.0.0 ordinal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/376
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/377
GEODE-1435: Adds binary distribution licensing.
* Adds binary licensing to binary package.
* Corrects error in source LICENSE file.
@metatype can you please review this?
You
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/378
@echobravopapa merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98807616
--- Diff: src/CMakeLists.txt ---
@@ -71,7 +71,7 @@ set(CPACK_PACKAGE_FILE_NAME
${CPACK_PACKAGE_NAME}-${PRODUCT_VERSION}-${CPACK_SYS
set
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98807604
--- Diff: dist/LICENSE ---
@@ -0,0 +1,390 @@
+ Apache License
+ Version 2.0, January
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98807830
--- Diff: dist/LICENSE ---
@@ -0,0 +1,390 @@
+ Apache License
+ Version 2.0, January
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98808052
--- Diff: dist/NOTICE ---
@@ -0,0 +1,8 @@
+Apache Geode Native Client
+Copyright 2017 The Apache Software Foundation.
+
+This product
101 - 200 of 209 matches
Mail list logo
