Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106927884
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
SafeConvertClassGeneric::SetAppDomainEnabled(appDomainEnable);
+ if (appDomainEnable)
+ {
+ // Register managed AppDomain context with unmanaged.
+ apache::geode::client::createAppDomainContext =
&Apache::Geode::Client::createAppDomainContext;
--- End diff --
No, it just looked better here since the surrounding code was doing things
with the appDomainEnabled flag. Where it came from had no other AppDomain code
and didn't check the flag so it was always "enabled". Now it will be enable
only when the `appdomain-enabled` property is set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
