Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103355323
--- Diff: src/cppcache/include/geode/SharedBase.hpp ---
@@ -56,11 +57,12 @@ class CPPCACHE_EXPORT SharedBase {
protected:
inline SharedBase(bool noInit) {}
+ inline SharedBase(const SharedBase&) {}
virtual ~SharedBase() {}
private:
- mutable volatile int32_t m_refCount;
+ std::atomic<int32_t> m_refCount;
--- End diff --
It didn't appear that the `mutable` attribute was necessary for operations
on this value. This `SharedBase` thing is a little funky so I didn't poke too
deep. The compiler did not find any issues where a `const` function or
reference was making changes to this value. It may be worth more investigation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
