Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353360
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -96,33 +102,38 @@ void LRUList<TEntry,
TCreateEntry>::getLRUEntry(LRUListEntryPtr& result) {
template <typename TEntry, typename TCreateEntry>
typename LRUList<TEntry, TCreateEntry>::LRUListNode*
-LRUList<TEntry, TCreateEntry>::getHeadNode(bool& isLast) {
- LOCK_HEAD;
+LRUList<TEntry, TCreateEntry>::getHeadNode(bool* isLast) {
--- End diff --
Good questions... Adherence to Google C++ Style Guide on references vs.
pointers. I think I did this before writing my questions about the practice on
the dev@geode. I can back this change out.
For reference, the guide dictates that references must be const and should
be used for in variables only. For out variable you should use pointer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
