GitHub user pivotal-jbarrett opened a pull request: https://github.com/apache/geode-native/pull/36
GEODE-2494: Replace SpinLock with spinlock_mutex. Replaces our non-standard SpinLock with spinlock_mutex that implements the C++11 standard BasicLockable. Where applicable the spin lock was completely removed and replaced with other thread safe constructs. Singleton protection, until singletons are removed entirely, converted to C++11 thread synchronized static initialization. Atomic operations converted to std::atomic. Can I get some reviews form the other C++ contributors before I merge this lovely change? You can merge this pull request into a Git repository by running: $ git pull https://github.com/pivotal-jbarrett/geode-native feature/GEODE-2494 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 ---- commit 4f8ee0ba64bae9cbc3fd204e759745236d174d6e Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-16T06:29:09Z GEODE-2494: Adds spinlock_mutex. commit 74efeb5d4ff807720aa051be5765471c64f3d8ea Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-16T06:29:37Z GEODE-2494: Replace SpinLock with spinlock_mutex. - Cleanup C++11 standards. commit f2ec96e50c974f0f8999b0d7b0ae3e0b2ea64244 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-16T07:33:21Z GEODE-2494: Replaced spin lock protected counter with std::atomic. - Cleanup C++11 standards. commit ab13aca81d084570d47c090363b5ba92b9ebec3b Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-20T21:42:19Z GEODE-2494: Replace SpinLock with spinlock_mutex. commit 84e5b333d7f53000593d41dcfe7f4011ea823f9f Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-22T05:46:27Z GEODE-2494: Replace SpinLock with spinlock_mutex. - Cleanup C++ standards. commit 76ca82febc1d68bd1e09b7639c92d59745d626f9 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-22T05:55:33Z GEODE-2494: Replace SpinLock with spinlock_mutex. - Cleanup C++ standards. commit 46131bea0d787698c124b822d8348b683633c6a2 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-22T06:00:21Z GEODE-2494: Replace SpinLock with spinlock_mutex. - Cleanup C++ standards. commit 9c8a9d6644a566f2b2d927da6c69a73ece9f5105 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-22T06:14:50Z GEODE-2494: Replace SpinLock with spinlock_mutex. - Cleanup C++ standards. commit ed88029b45b4b4d5155a76e0b0d0c2c882274581 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-22T06:52:50Z GEODE-2494: Replace SpinLock with spinlock_mutex. - Cleanup C++ standards. commit 2e2c36b52b48342e59e7f0dac671c59dfb994148 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-23T01:58:05Z GEODE-2494: Replace SpinLock with spinlock_mutex. - Cleanup C++ standards. commit 8898a1c9b3dc514bd6b8c2630d021a01729d4df8 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-23T03:04:10Z GEODE-2494: Replace SpinLock with spinlock_mutex. - Cleanup C++ standards. commit ec2e69431c88d00a63b05b3f6fdcec8b970fe780 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-02-23T05:29:49Z GEODE-2494: Removed SpinLock. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---